Google Git
Sign in
chromium / v8 / v8 / 0b15565fdaac4e60d9a6fb8e6c7e63780fb9f252
commit0b15565fdaac4e60d9a6fb8e6c7e63780fb9f252[log] [tgz]
authorClemens Backes <clemensb@chromium.org>Fri Feb 21 16:57:25 2025
committerV8 LUCI CQ <v8-scoped@luci-project-accounts.iam.gserviceaccount.com>Sun Feb 23 22:14:29 2025
tree08b9bce1df8025c6333a85cacc64f06a7d0713ce
parent6d7dced8663d1c6d032f9324214228c217188847 [diff]
[sandbox] Check that GetIsolateForSandbox returns the current sandbox

We want to replace all calls to GetIsolateForSandbox via
GetCurrentIsolateForSandbox. Before doing that, this CL adds a SBXCHECK
to verify that both methods return the same isolate.

One exception are shared objects, where we do return a pointer to the
main isolate instead. For those cases we do check that the isolates are
"compatible" in the sense that they share the same shared pointer table.
This is a pretty costly check, but it is not executed in production code
and it should soon (maybe after the next branch cut) be removed by
replacing all callers of `GetIsolateForSandbox` by
`GetCurrentIsolateForSandbox`.

R=dinfuehr@chromium.org
CC=mlippautz@chromium.org

Bug: 396607238, 393402168
Change-Id: I3a5bc983b7e79db157f8dfe5088a327fc2a75e32
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6276459
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#98872}
3 files changed
tree: 08b9bce1df8025c6333a85cacc64f06a7d0713ce
  1. .github/
  2. bazel/
  3. build_overrides/
  4. custom_deps/
  5. docs/
  6. gni/
  7. include/
  8. infra/
  9. samples/
  10. src/
  11. test/
  12. testing/
  13. third_party/
  14. tools/
  15. .bazelrc
  16. .clang-format
  17. .clang-tidy
  18. .editorconfig
  19. .flake8
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gn
  24. .mailmap
  25. .style.yapf
  26. .vpython3
  27. .ycm_extra_conf.py
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CODE_OF_CONDUCT.md
  32. codereview.settings
  33. COMMON_OWNERS
  34. DEPS
  35. DIR_METADATA
  36. ENG_REVIEW_OWNERS
  37. INFRA_OWNERS
  38. INTL_OWNERS
  39. LICENSE
  40. LICENSE.fdlibm
  41. LICENSE.strongtalk
  42. LICENSE.v8
  43. LOONG_OWNERS
  44. MIPS_OWNERS
  45. MODULE.bazel
  46. OWNERS
  47. PPC_OWNERS
  48. PRESUBMIT.py
  49. pyrightconfig.json
  50. README.md
  51. RISCV_OWNERS
  52. S390_OWNERS
  53. WATCHLISTS
README.md

V8 JavaScript Engine

V8 is Google's open source JavaScript engine.

V8 implements ECMAScript as specified in ECMA-262.

V8 is written in C++ and is used in Google Chrome, the open source browser from Google.

V8 can run standalone, or can be embedded into any C++ application.

V8 Project page: https://v8.dev/docs

Getting the Code

Checkout depot tools, and run

    fetch v8

This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run

    git pull origin
    gclient sync

For fetching all branches, add the following into your remote configuration in .git/config:

    fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
    fetch = +refs/tags/*:refs/tags/*

Contributing

Please follow the instructions mentioned at v8.dev/docs/contribute.