Google Git
Sign in
chromium / v8 / v8 / 398c8737c9312d516172421b58100c562798516d
commit398c8737c9312d516172421b58100c562798516d[log] [tgz]
authorVictor Gomes <victorgomes@chromium.org>Tue May 20 06:37:35 2025
committerV8 LUCI CQ <v8-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 20 08:48:59 2025
treefe8a886f75f70d3b03db404d708fce8933653160
parent2c25dcb2827d77c38f5f6b8f1d831c45e237741c [diff]
[context] Fix Global IC script context store without cells

GlobalIC builtin calls StoreScriptContextElementImpl with a
script context regardless of the flag --script-context-cells.

We shouldn't dcheck HasContextCells, but instead
check it before allocating a cell.

This also fixes bot:
https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite%20-%20debug/35262/overview

Fixed: 418820291
Change-Id: I4f6ca8c8df802f8907d83efc215e46372001cda1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6564411
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#100373}
2 files changed
tree: fe8a886f75f70d3b03db404d708fce8933653160
  1. .github/
  2. bazel/
  3. build_overrides/
  4. custom_deps/
  5. docs/
  6. gni/
  7. include/
  8. infra/
  9. samples/
  10. src/
  11. test/
  12. testing/
  13. third_party/
  14. tools/
  15. .bazelrc
  16. .clang-format
  17. .clang-tidy
  18. .editorconfig
  19. .flake8
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gn
  24. .mailmap
  25. .style.yapf
  26. .vpython3
  27. .ycm_extra_conf.py
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CODE_OF_CONDUCT.md
  32. codereview.settings
  33. COMMON_OWNERS
  34. DEPS
  35. DIR_METADATA
  36. ENG_REVIEW_OWNERS
  37. INFRA_OWNERS
  38. INTL_OWNERS
  39. LICENSE
  40. LICENSE.fdlibm
  41. LICENSE.strongtalk
  42. LICENSE.v8
  43. LOONG_OWNERS
  44. MIPS_OWNERS
  45. MODULE.bazel
  46. OWNERS
  47. PPC_OWNERS
  48. PRESUBMIT.py
  49. pyrightconfig.json
  50. README.md
  51. RISCV_OWNERS
  52. S390_OWNERS
  53. WATCHLISTS
README.md

V8 JavaScript Engine

V8 is Google's open source JavaScript engine.

V8 implements ECMAScript as specified in ECMA-262.

V8 is written in C++ and is used in Google Chrome, the open source browser from Google.

V8 can run standalone, or can be embedded into any C++ application.

V8 Project page: https://v8.dev/docs

Getting the Code

Checkout depot tools, and run

    fetch v8

This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run

    git pull origin
    gclient sync

For fetching all branches, add the following into your remote configuration in .git/config:

    fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
    fetch = +refs/tags/*:refs/tags/*

Contributing

Please follow the instructions mentioned at v8.dev/docs/contribute.