Google Git
Sign in
chromium / v8 / v8 / 3d58b82addcdc72755539631b1d5dc603a9b2135
commit3d58b82addcdc72755539631b1d5dc603a9b2135[log] [tgz]
authorMichael Stanton <mvstanton@chromium.org>Fri Nov 21 10:14:08 2014
committerMichael Stanton <mvstanton@chromium.org>Fri Nov 21 10:14:19 2014
tree2185184b96a4eda7a30e64a4a463e71fddcf9225
parentfada2a08e561510a5c1e440eed28fdfa5ffa6d81 [diff]
Fix for 435073: CHECK failure in CHECK(p->IsSmi()) failed.

The bug was an error when copying arrays in crankshaft. If it's a holey smi
array, the copy must be done as FAST_HOLEY_ELEMENTS to prevent representation
changes from being inserted that deopt on encountering the hole.

Also, prevent inlining array pop() and shift() if the length is read-only.

BUG=435073
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/737383002

Cr-Commit-Position: refs/heads/master@{#25455}
4 files changed
tree: 2185184b96a4eda7a30e64a4a463e71fddcf9225
  1. benchmarks/
  2. build/
  3. include/
  4. samples/
  5. src/
  6. test/
  7. testing/
  8. tools/
  9. .clang-format
  10. .gitignore
  11. AUTHORS
  12. BUILD.gn
  13. ChangeLog
  14. codereview.settings
  15. DEPS
  16. LICENSE
  17. LICENSE.strongtalk
  18. LICENSE.v8
  19. LICENSE.valgrind
  20. Makefile
  21. Makefile.android
  22. Makefile.nacl
  23. OWNERS
  24. PRESUBMIT.py
  25. README.md
  26. WATCHLISTS
README.md

V8 JavaScript Engine

V8 is Google's open source JavaScript engine.

V8 implements ECMAScript as specified in ECMA-262.

V8 is written in C++ and is used in Google Chrome, the open source browser from Google.

V8 can run standalone, or can be embedded into any C++ application.

V8 Project page: https://code.google.com/p/v8/

Getting the Code

V8 Git repository: https://chromium.googlesource.com/v8/v8.git GitHub mirror: https://github.com/v8/v8-git-mirror

For fetching all branches, add the following into your remote configuration in .git/config:

    fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
    fetch = +refs/tags/*:refs/tags/*