commit 9f4bea8e781260e7b7a1e3c8ef6598cb52dc1dd4
author Jakob Linke <jgruber@chromium.org> Wed Apr 12 10:34:15 2023
committer V8 LUCI CQ <v8-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 12 12:12:21 2023
tree e3ef683462a8aac899099044cf4554c06619baeb
parent 9e2bddc2b103fd3fd8751a133749c2a8f42ad972

Remove code/istream fields from RelocInfo

.. and simplify RelocIterator uses.

The code/istream fields on RelocInfo were (surprisingly) nullable
and were actually unset in many cases. It was never clear when one
could rely on them being set, and OTOH when one had to pass valid
code/istream objects to the ctor.

This CL simply removes them and explicitly passes code/istream to
the use-site when needed.

As a consequence of these weird nullable fields, RelocIterator
constructors also accepted nullable code/istream objects, and
were similarly hard to understand. They also attempted to handle
calls from within a GC context (i.e. in the presence of forwarding
pointers) by sprinkling various unchecked casts around.

This CL removes unused ctors, and extensively comments the remaining
ones.

Finally, as a drive-by, various minor refactors in reloc-info.h
and friends.

No-Try: true
Bug: v8:13789
Change-Id: I2ef3c27faaec84e4bff8f42b32c62bfd631ec6c2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4406533
Commit-Queue: Jakob Linke <jgruber@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#87031}