| commit | ade6d191c8566e3fe7331d2ef37e43760c7cb363 | [log] [tgz] |
|---|---|---|
| author | Benedikt Meurer <bmeurer@chromium.org> | Mon Oct 10 05:57:54 2022 |
| committer | V8 LUCI CQ <v8-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Oct 10 13:14:57 2022 |
| tree | dd8bc5dbb3692a28965df04393fc46376991c9af | |
| parent | 033c2e49a60d86ea57d6c2ce8bf64662e1161c9f [diff] |
[debug] Treat Comma-separated Expressions like Statements when Stepping. This CL introduces statement positions before the right-hand side of comma expressions, in order to align the stepping behavior (and also generally the breakpoint behavior) around semicolon (;) and comma (,) separated expressions. The motivation here is that left-hand sides of comma expressions are evaluated purely for their side-effects and as such, they aren't really any different from statements from a developers perspective. And more importantly, minifiers (like UglifyJS, terser, or esbuild) by default turn statement expression lists into comma-separated expressions, thus implicitly changing the stepping behavior in ways that are difficult to understand for developers. Doc: http://go/chrome-devtools:comma-stepping-proposal Demo: https://devtools-dbg-stories.netlify.app/crbug-1370200.html Video: https://i.imgur.com/5WC03wF.gif Fixed: chromium:1370200 Change-Id: I38f288d964bc992d1de0dce2ed2becd4220793df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3934288 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#83599}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned at v8.dev/docs/contribute.