commit | b121cde9011ac418249e14bf83e3e72349054de8 | [log] [tgz] |
---|---|---|
author | Dan Elphick <delphick@chromium.org> | Wed Jan 16 13:37:16 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 16 14:25:13 2019 |
tree | 784d502659ad436e6438973cef93c297f49e94f9 | |
parent | 4f261e9a5968d461cc0003876afcdbf5f8794917 [diff] |
[api] Add Check method to Maybe This new method returns no value and just verifies that the Maybe is not Empty. This is intended to be used for functions like Object::Set that return a Maybe<bool> but only use "emptiness" to indicate its result and where ToLocalChecked() appears to be discarding information. Also comments Object::Set to indicate that Check() is the preferred way of asserting that the Set should always succeed. R=yangguo Bug: v8:8562 Change-Id: Ic3b45e42fa9ba0b53f1a764660a56041e64f087b Reviewed-on: https://chromium-review.googlesource.com/c/1414912 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#58852}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies. To stay up to date, run
git pull origin gclient sync
For fetching all branches, add the following into your remote configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/* fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.