commit b838f9dedf4cdcd8acb585d92a562c6e581358f8
author Simon Zünd <szuend@chromium.org> Mon Jul 25 05:57:22 2022
committer V8 LUCI CQ <v8-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 25 06:58:16 2022
tree fb17dc6073cb2395cb0a2112591f6c1cef38f6a6
parent 8aca0dcd85635b3a6a1e3d57c35b12fcb627189d

[inspector] Replace 'Cast' with 'As' in async stack tagging

Minor cleanup CL for better readability.

R=kimanh@chromium.org

Bug: chromium:1334585
Change-Id: I430a33e2b7173e146ff9927e70b06a04770cd956
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779495
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81905}

src/inspector/v8-console.cc

diff --git a/src/inspector/v8-console.cc b/src/inspector/v8-console.cc
index 8a6222b..d2a1f1a 100644
--- a/src/inspector/v8-console.cc
+++ b/src/inspector/v8-console.cc
@@ -589,7 +589,7 @@
 void V8Console::scheduleTask(const v8::FunctionCallbackInfo<v8::Value>& info) {
   v8::Isolate* isolate = info.GetIsolate();
   if (info.Length() < 1 || !info[0]->IsString() ||
-      !v8::Local<v8::String>::Cast(info[0])->Length()) {
+      !info[0].As<v8::String>()->Length()) {
     isolate->ThrowError("First argument must be a non-empty string.");
     return;
   }
@@ -607,8 +607,7 @@
   auto [iter, inserted] = m_tasks.emplace(taskId, std::move(taskInfo));
   CHECK(inserted);
 
-  String16 nameArgument =
-      toProtocolString(isolate, v8::Local<v8::String>::Cast(info[0]));
+  String16 nameArgument = toProtocolString(isolate, info[0].As<v8::String>());
   StringView taskName =
       StringView(nameArgument.characters16(), nameArgument.length());
   m_inspector->asyncTaskScheduled(taskName, taskId, /* recurring */ true);
@@ -637,8 +636,7 @@
     return;
   }
 
-  v8::Local<v8::External> taskExternal =
-      v8::Local<v8::External>::Cast(maybeTaskExternal);
+  v8::Local<v8::External> taskExternal = maybeTaskExternal.As<v8::External>();
   TaskInfo* taskInfo = reinterpret_cast<TaskInfo*>(taskExternal->Value());
 
   m_inspector->asyncTaskStarted(taskInfo->Id());