commit | dce5e6291ea8810eee16bf5fee2fcbe402840bda | [log] [tgz] |
---|---|---|
author | Deepti Gandluri <gdeepti@chromium.org> | Mon Aug 12 23:13:31 2024 |
committer | V8 LUCI CQ <v8-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 12 23:14:06 2024 |
tree | d157bca45153b65476e9fba1aa300e5fce820413 | |
parent | 28d8b301adc22225cbc144915308145b1541bfb9 [diff] |
Revert "[parser] Fix scope id overlap for wrapped functions" This reverts commit 231dd5ce3bf5cc06fd7b82676a443e2750e07a4a. Reason for revert: MSVC fails: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20msvc%20-%20builder/11238/overview Original change's description: > [parser] Fix scope id overlap for wrapped functions > > Wrapped functions don't have parentheses, so their start position is > also the start position of the body. This means that UniqueIdInScript > for a wrapped function is 0. If there is a scope starting at position 0 > in the wrapped function body, it will have an id conflict. > > Found in https://github.com/nodejs/node/pull/54077#issuecomment-2275368974 > > Change-Id: Ic3f5e88cbc52e9395339828a152d9a8ac2dbe320 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5783133 > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Patrick Thier <pthier@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#95579} Change-Id: I675b6282c30f4b8dab91e647a054ebac54d88e1c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5784408 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#95590}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies. To stay up to date, run
git pull origin gclient sync
For fetching all branches, add the following into your remote configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/* fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned at v8.dev/docs/contribute.