commit | b364ba5741122bcafb631acca994f10c869940ec | [log] [tgz] |
---|---|---|
author | Clemens Hammacher <clemensh@chromium.org> | Mon Jun 18 07:37:29 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jun 18 09:58:49 2018 |
tree | 71e1bdfd2d632814d1b25726b96126cfe3364857 | |
parent | f4f141125f72195dbfdb6db1fa1489b81618fd77 [diff] |
Merged: [wasm] Reject an exception in the start function on the promise We assumed that if the ErrorThrower is empty after instantiation, then instantiation succeeded and an instance exists which we can return. However, if the start function throws, no instance exists, which caused a crash. With this CL we handle execeptions thrown by the start function correctly. R=mstarzinger@chromium.org Bug: chromium:848966 No-Try: true No-Presubmit: true No-Treechecks: true Change-Id: If044e62ebe45b5598bf5ef6787e7dde873a21f11 Originally-reviewed-on: https://chromium-review.googlesource.com/1092234 Reviewed-on: https://chromium-review.googlesource.com/1103566 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/branch-heads/6.8@{#27} Cr-Branched-From: 44d7d7d6b1041b57644400a00cb3fee35f6c51b2-refs/heads/6.8.275@{#1} Cr-Branched-From: 5754f66f75136dc17b4c63fec84f31dfdb89186e-refs/heads/master@{#53286}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies. To stay up to date, run
git pull origin gclient sync
For fetching all branches, add the following into your remote configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/* fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.