| commit | 1bef7d219f8e00f88de655c83d115180c3d03132 | [log] [tgz] |
|---|---|---|
| author | jgruber <jgruber@chromium.org> | Mon Jul 30 06:49:30 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Jul 30 07:36:47 2018 |
| tree | 60930fd5fce52d6b467fdf495b81a3fc83411503 | |
| parent | 13401d2beb6c20c7f3e9515b49f2e9d389cb3796 [diff] |
[builtins,x64] More information about root-relative accesses When disassembling code (in particular embedded builtins), try to print better information about root-relative accesses. For example: REX.W movq rdx,[r13+0x548] REX.W movq rax,[r13+0x10a8] turns into REX.W movq rdx,[r13+0x548] (root (0x1ff420d0ccd9 <FixedArray[1672]>)) REX.W movq rax,[r13+0x10a8] (external reference (check_object_type)) This is a band-aid solution until we come up with something better. It does not understand multi-instruction sequences (such as loads from the builtins constants table), assumes every kRootRegister-relative access is actually root-relative (i.e. the register is not initialized to some other value), and is limited to a particular instruction pattern. Bug: v8:6666,v8:7969 Change-Id: I35af92e8233c9bb0f2ad6ba0e86bd0ab69177205 Reviewed-on: https://chromium-review.googlesource.com/1146806 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54777}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.