commit | 845f06338d48833e0fad762501fdf1534ccee98c | [log] [tgz] |
---|---|---|
author | Irina Yatsenko <irinayat@microsoft.com> | Tue Oct 22 20:14:33 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 23 17:14:09 2019 |
tree | 238a63b9bde78c5b61ef8d1fb7797bc3c71f7f4b | |
parent | 642bffa07fda91d6e2705f70dfaef233538f1bfd [diff] |
Race between crashkeys for collecting heap dumps Crashkeys are static and non-refcounted, so when one thread clears a crashkey, it affects all other threads. This means, we cannot set them in parallel running jobs such as ScavengePage. This change moves the crashkey about heap collection up the stack into the main thread. Change-Id: I28f16eaadd9b122c06a68d1d4207f27319994509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874384 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#64523}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies. To stay up to date, run
git pull origin gclient sync
For fetching all branches, add the following into your remote configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/* fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned at v8.dev/docs/contribute.