commit b4f01ea3ed6fd00923caa383bb2cf6f7a0b7f633
author Wan-Teh Chang <wtc@google.com> Tue Jan 14 01:06:18 2025
committer Wan-Teh Chang <wtc@google.com> Tue Jan 14 01:06:18 2025
tree 00f8fffa3dcafc6316e03701d47a24e2a0e9ba89
parent 6c1e511f487eaea026d94d0c6494a617155b5cfb

Check if long long may possibly be > LONG_MAX

Fix Coverity defect CID 1616730: Logically dead code (DEADCODE).

Change-Id: I4d9fdb8d342c1fbb01dbed1be15f552067e16dc1

mkvparser/mkvparser.cc

diff --git a/mkvparser/mkvparser.cc b/mkvparser/mkvparser.cc
index 3294400..4fa7b37 100644
--- a/mkvparser/mkvparser.cc
+++ b/mkvparser/mkvparser.cc
@@ -7890,8 +7890,10 @@
     if (frame_size <= 0)
       return E_FILE_FORMAT_INVALID;
 
+#if LLONG_MAX > LONG_MAX
     if (frame_size > LONG_MAX)
       return E_FILE_FORMAT_INVALID;
+#endif
 
     if ((pos + len) > stop)
       return E_FILE_FORMAT_INVALID;
@@ -7957,8 +7959,10 @@
       if (frame_size <= 0)
         return E_FILE_FORMAT_INVALID;
 
+#if LLONG_MAX > LONG_MAX
       if (frame_size > LONG_MAX)
         return E_FILE_FORMAT_INVALID;
+#endif
 
       curr.len = static_cast<long>(frame_size);
       // Check if size + curr.len could overflow.