Disable SimpleProcess.BindFdToSameFd test
This test is flaky in the Chromium OS builders since it fails when a
file descriptor number is big enough.
BUG=None
TEST=FEATURES=test emerge-link libbrillo
(cherry picked from commit ae40d5e67c6686d02918ba42686f94d45ac92f86)
Change-Id: If85de274539d379d39f0cb831361432ffd981876
Reviewed-on: https://chromium-review.googlesource.com/344601
Commit-Ready: Alex Deymo <deymo@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Daniel Colish <colish@chromium.org>
diff --git a/brillo/process_unittest.cc b/brillo/process_unittest.cc
index 58e2f56..d2c92e6 100644
--- a/brillo/process_unittest.cc
+++ b/brillo/process_unittest.cc
@@ -79,7 +79,13 @@
EXPECT_EQ(std::string(kMsg) + "\n", std::string(buf));
}
-TEST(SimpleProcess, BindFdToSameFd) {
+// The test framework uses the device's dash shell as "sh", which doesn't
+// support redirecting stdout to arbitrary large file descriptor numbers
+// directly, nor has /proc mounted to open /proc/self/fd/NN. This test would
+// fail if pipe.writer is big enough.
+// TODO(deymo): Write a helper program that writes "hello_world" to the passed
+// file descriptor and re-enabled this test.
+TEST(DISABLED_SimpleProcess, BindFdToSameFd) {
static const char* kMsg = "hello_world";
ScopedPipe pipe;
ProcessImpl process;
