| commit | 02044bf86ad40003cf375b99b8b1a58a8a9c209f | [log] [tgz] |
|---|---|---|
| author | findit-for-me <findit-for-me@appspot.gserviceaccount.com> | Fri Apr 28 02:49:24 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Fri Apr 28 02:49:24 2017 |
| tree | 586e3ebdc98b3a4fd35df9baf9b216673c0bc8bb | |
| parent | c5e677ab7b7d827b9e58648bdd83742d4d20b605 [diff] |
Revert of Roll googletest to 1.8.0. (patchset #7 id:340001 of https://codereview.chromium.org/2779193002/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 467833 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I1MzlmYTExMjNhMTllNjQ5OWY1ODU4MmRhNTVjYTVhZjlkZjk0YTQM Original issue's description: > Roll googletest to 1.8.0. > > GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same > googletest repository. In order to cope with this, the googletest > repository is now sourced at third_party/googletest. > > The file/directory layout of Google Test is not yet considered stable. > To minimize disruption while Google Test stabilizes, Chromium code will > be insulated from third_party/googletest. > > * testing/gtest/include/gtest/ and testing/gmock/include/gmock have > been populated with headers that forward into the appropriate locations of > third_party/googletest > > * testing/BUILD.gn has been populated with the targets > //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which > depend on the appropriate //third_party/googletest targets. > > All Chromium code should keep depending on the targets and headers > in testing/{gtest,gmock} for now. > > BUG=630705 > TBR=rkc > > Review-Url: https://codereview.chromium.org/2779193002 > Cr-Commit-Position: refs/heads/master@{#467833} > Committed: https://chromium.googlesource.com/chromium/src/+/b539fa1123a19e6499f58582da55ca5af9df94a4 TBR=thakis@chromium.org,dpranke@chromium.org,agl@chromium.org,rkc@chromium.org,skobes@chromium.org,pwnall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630705 Review-Url: https://codereview.chromium.org/2847043002 Cr-Original-Commit-Position: refs/heads/master@{#467852} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: ed7b62615d138c4d629540bab4a2757da5551134