Change TxConfig and RxConfig as optional implementation.
`TxConfig` or `RxConfig` is aimed to configure the device setting
before transmitting or receiving. But in practice we just implemented
the configuration in the TxStart or RxMeasure in most case.
We will consider to remove these APIs later.
BUG=chromium:681734
TEST=make test
Change-Id: Ib2173e8db08272fc69a77b333828b0185fdcdf19
Reviewed-on: https://chromium-review.googlesource.com/428480
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Joel Kitching <kitching@chromium.org>
diff --git a/graphyte/dut/__init__.py b/graphyte/dut/__init__.py
index 62e5ac5..b91d659 100644
--- a/graphyte/dut/__init__.py
+++ b/graphyte/dut/__init__.py
@@ -98,7 +98,8 @@
Configures the transmission settings to the DUT without arming trigger.
"""
- raise NotImplementedError
+ # TODO(akahuang): Decide whether this function should be removed.
+ pass
def TxStart(self, test):
test_case = self._CheckTestArgument(test.ToDict(), 'TX')
@@ -127,7 +128,8 @@
def _RxConfig(self, **kwargs):
"""Configures the DUT for the receiving test case."""
- raise NotImplementedError
+ # TODO(akahuang): Decide whether this function should be removed.
+ pass
def RxClearResult(self, test):
test_case = self._CheckTestArgument(test.ToDict(), 'RX')
@@ -161,7 +163,7 @@
def _TxConfig(self, component_name, center_freq,
power_level, standard, bandwidth, data_rate, chain_mask, nss,
long_preamble, **kwargs):
- raise NotImplementedError
+ pass
def _TxStart(self, component_name, center_freq,
power_level, standard, bandwidth, data_rate, chain_mask, nss,
@@ -171,7 +173,7 @@
def _RxConfig(self, component_name, center_freq,
power_level, standard, bandwidth, data_rate, chain_mask, nss,
long_preamble, rx_num_packets, **kwargs):
- raise NotImplementedError
+ pass
def _RxClearResult(self, component_name, center_freq,
power_level, standard, bandwidth, data_rate, chain_mask,
@@ -188,7 +190,7 @@
def _TxConfig(self, component_name, center_freq,
power_level, packet_type, bit_pattern, **kwargs):
- raise NotImplementedError
+ pass
def _TxStart(self, component_name, center_freq,
power_level, packet_type, bit_pattern, **kwargs):
@@ -197,7 +199,7 @@
def _RxConfig(self, component_name, center_freq,
power_level, packet_type, bit_pattern,
rx_num_packets=None, rx_num_bits=None, **kwargs):
- raise NotImplementedError
+ pass
def _RxClearResult(self, component_name, center_freq,
power_level, packet_type, bit_pattern,
@@ -214,7 +216,7 @@
def _TxConfig(self, component_name, center_freq,
power_level, **kwargs):
- raise NotImplementedError
+ pass
def _TxStart(self, component_name, center_freq,
power_level, **kwargs):
@@ -222,7 +224,7 @@
def _RxConfig(self, component_name, center_freq,
power_level, rx_num_packets, **kwargs):
- raise NotImplementedError
+ pass
def _RxClearResult(self, component_name, center_freq,
power_level, rx_num_packets, **kwargs):
diff --git a/graphyte/inst/__init__.py b/graphyte/inst/__init__.py
index d360d9a..c03eaa9 100644
--- a/graphyte/inst/__init__.py
+++ b/graphyte/inst/__init__.py
@@ -175,7 +175,8 @@
arming trigger. The method would be called before the DUT start
transmitting signal.
"""
- raise NotImplementedError
+ # TODO(akahuang): Decide whether this function should be removed.
+ pass
def TxMeasure(self, test):
test_case = self._CheckTestArgument(test.ToDict(), 'TX')
@@ -241,7 +242,8 @@
Configures the VSG and loads the waveform based on the signal information.
The method would be called before the DUT start receiving signal.
"""
- raise NotImplementedError
+ # TODO(akahuang): Decide whether this function should be removed.
+ pass
def RxGenerate(self, test):
test_case = self._CheckTestArgument(test.ToDict(), 'RX')
@@ -265,7 +267,7 @@
def _TxConfig(self, component_name, rf_type, test_type, center_freq,
power_level, standard, bandwidth, data_rate, chain_mask, nss,
long_preamble, **kwargs):
- raise NotImplementedError
+ pass
def _TxMeasure(self, component_name, rf_type, test_type, center_freq,
power_level, standard, bandwidth, data_rate, chain_mask,
@@ -280,7 +282,7 @@
def _RxConfig(self, component_name, rf_type, test_type, center_freq,
power_level, standard, bandwidth, data_rate, chain_mask, nss,
long_preamble, rx_num_packets, **kwargs):
- raise NotImplementedError
+ pass
def _RxGenerate(self, component_name, rf_type, test_type, center_freq,
power_level, standard, bandwidth, data_rate, chain_mask,
@@ -299,7 +301,7 @@
def _TxConfig(self, component_name, rf_type, test_type, center_freq,
power_level, packet_type, bit_pattern, **kwargs):
- raise NotImplementedError
+ pass
def _TxMeasure(self, component_name, rf_type, test_type, center_freq,
power_level, packet_type, bit_pattern, result_limit,
@@ -352,7 +354,7 @@
def _RxConfig(self, component_name, rf_type, test_type, center_freq,
power_level, packet_type, bit_pattern,
rx_num_packets=None, rx_num_bits=None, **kwargs):
- raise NotImplementedError
+ pass
def _RxGenerate(self, component_name, rf_type, test_type, center_freq,
power_level, packet_type, bit_pattern,
@@ -364,7 +366,7 @@
def _TxConfig(self, component_name, rf_type, test_type, center_freq,
power_level, **kwargs):
- raise NotImplementedError
+ pass
def _TxMeasure(self, component_name, rf_type, test_type, center_freq,
power_level, result_limit, **kwargs):
@@ -376,7 +378,7 @@
def _RxConfig(self, component_name, rf_type, test_type, center_freq,
power_level, rx_num_packets, **kwargs):
- raise NotImplementedError
+ pass
def _RxGenerate(self, component_name, rf_type, test_type, center_freq,
power_level, rx_num_packets, **kwargs):
