xtask: Drop `quiet` arg from kernel params
The quiet arg is good for aesthetics, but breaks some of the VM tests
that rely on the "EFI stub: UEFI Secure Boot is enabled" message. Fix by
dropping the quiet arg when setting up the image (does nothing if that
arg is not present).
BUG=b:336367262
TEST=rm workspace/disk.bin
TEST=cargo xtask setup --reven-private
TEST=cargo xtask check --vm-tests
Change-Id: I2ccc2736c5ae53d405dfc3b422a7892b370b2e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crdyboot/+/5485086
Auto-Submit: Nicholas Bishop <nicholasbishop@google.com>
Tested-by: Nicholas Bishop <nicholasbishop@google.com>
Commit-Queue: Nicholas Bishop <nicholasbishop@google.com>
Reviewed-by: Jeffery Miller <jefferymiller@google.com>
Commit-Queue: Jeffery Miller <jefferymiller@google.com>
Tested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com <chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com>
diff --git a/xtask/src/gen_disk.rs b/xtask/src/gen_disk.rs
index afd9a2c..e7b0340 100644
--- a/xtask/src/gen_disk.rs
+++ b/xtask/src/gen_disk.rs
@@ -499,6 +499,12 @@
.run()?;
let stdout = output.stdout_string_lossy();
let command_line = stdout.lines().last().unwrap();
+ // Reven builds enable the `quiet` arg so that the EFI stub doesn't
+ // print messages. However, for VM tests in this repo it's useful to
+ // show those messages so we can assert the EFI stub has started
+ // (the alternative is to wait for SSH to fully come up, which would
+ // make tests take much longer).
+ let command_line = command_line.replace("quiet ", "");
fs::write(&config, command_line)?;
// Extract vmlinuz.
