storage_info: Change smartctl -x blacklist rule to cover more version
Another Sandisk SSD hangs when we read PHY statistic from the SSD using
"smartctl -x" command. This change updates the smartctl -x blacklist
rule to cover more SSD model/firmware combination that contain this bug.
Also add unit test to test for these new rules.
BUG=chromium:340895
BUG=chromium:344036
TEST=Boot normally in chromebook with defect SSD and unit test pass
Change-Id: Ic4d8f6022ecef922af3dff9aebd194c1dfc445cc
Reviewed-on: https://chromium-review.googlesource.com/195030
Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org>
Commit-Queue: Mohammed Habibulla <moch@google.com>
Tested-by: Mohammed Habibulla <moch@google.com>
diff --git a/scripts/storage_info b/scripts/storage_info
index f2054c8..45d2c21 100755
--- a/scripts/storage_info
+++ b/scripts/storage_info
@@ -21,7 +21,9 @@
# Seen Error: U100 10.52.01 / i100 CS.51.00 / U100 10.01.04
MODEL_BLACKLIST_0="SanDisk_SSD_[iU]100.*"
VERSION_BLACKLIST_0="(CS|10)\.([01234].|5[0123])\..*"
-BLACKLIST_MAX=0
+MODEL_BLACKLIST_1="SanDisk_SDSA5GK-.*"
+VERSION_BLACKLIST_1="CS.54.06"
+BLACKLIST_MAX=1
MMC_NAME_0="cid"
MMC_NAME_1="csd"
diff --git a/test/storage_info_unit_test b/test/storage_info_unit_test
index 774c447..0dba835 100755
--- a/test/storage_info_unit_test
+++ b/test/storage_info_unit_test
@@ -8,7 +8,7 @@
. scripts/storage_info --test
-TEST_COUNT=7
+TEST_COUNT=8
# stout - old fw crbug.com/328587#c11
MODEL_1="SanDisk_SSD_U100_16GB"
@@ -45,6 +45,11 @@
VERSION_7="DS51704"
RESULT_7="NOT_MATCH"
+# butterfly
+MODEL_8="SanDisk_SDSA5GK-016G-1006"
+VERSION_8="CS.54.06"
+RESULT_8="MATCH"
+
get_is_ssd_blacklist_result() {
if is_ssd_blacklist $1 $2; then
echo "MATCH"
