| //===--- IntegerTypesCheck.cpp - clang-tidy -------------------------------===// |
| // |
| // The LLVM Compiler Infrastructure |
| // |
| // This file is distributed under the University of Illinois Open Source |
| // License. See LICENSE.TXT for details. |
| // |
| //===----------------------------------------------------------------------===// |
| |
| #include "IntegerTypesCheck.h" |
| #include "clang/AST/ASTContext.h" |
| #include "clang/ASTMatchers/ASTMatchFinder.h" |
| #include "clang/ASTMatchers/ASTMatchers.h" |
| #include "clang/Basic/CharInfo.h" |
| #include "clang/Basic/TargetInfo.h" |
| |
| namespace clang { |
| namespace tidy { |
| namespace runtime { |
| |
| using namespace ast_matchers; |
| |
| void IntegerTypesCheck::registerMatchers(MatchFinder *Finder) { |
| // Find all TypeLocs. |
| Finder->addMatcher(typeLoc().bind("tl"), this); |
| } |
| |
| void IntegerTypesCheck::check(const MatchFinder::MatchResult &Result) { |
| // The relevant Style Guide rule only applies to C++. |
| if (!Result.Context->getLangOpts().CPlusPlus) |
| return; |
| |
| auto TL = *Result.Nodes.getNodeAs<TypeLoc>("tl"); |
| SourceLocation Loc = TL.getLocStart(); |
| |
| if (Loc.isInvalid() || Loc.isMacroID()) |
| return; |
| |
| // Look through qualification. |
| if (auto QualLoc = TL.getAs<QualifiedTypeLoc>()) |
| TL = QualLoc.getUnqualifiedLoc(); |
| |
| auto BuiltinLoc = TL.getAs<BuiltinTypeLoc>(); |
| if (!BuiltinLoc) |
| return; |
| |
| bool IsSigned; |
| unsigned Width; |
| const TargetInfo &TargetInfo = Result.Context->getTargetInfo(); |
| |
| // Look for uses of short, long, long long and their unsigned versions. |
| switch (BuiltinLoc.getTypePtr()->getKind()) { |
| case BuiltinType::Short: |
| Width = TargetInfo.getShortWidth(); |
| IsSigned = true; |
| break; |
| case BuiltinType::Long: |
| Width = TargetInfo.getLongWidth(); |
| IsSigned = true; |
| break; |
| case BuiltinType::LongLong: |
| Width = TargetInfo.getLongLongWidth(); |
| IsSigned = true; |
| break; |
| case BuiltinType::UShort: |
| Width = TargetInfo.getShortWidth(); |
| IsSigned = false; |
| break; |
| case BuiltinType::ULong: |
| Width = TargetInfo.getLongWidth(); |
| IsSigned = false; |
| break; |
| case BuiltinType::ULongLong: |
| Width = TargetInfo.getLongLongWidth(); |
| IsSigned = false; |
| break; |
| default: |
| return; |
| } |
| |
| // We allow "unsigned short port" as that's reasonably common and required by |
| // the sockets API. |
| const StringRef Port = "unsigned short port"; |
| const char *Data = Result.SourceManager->getCharacterData(Loc); |
| if (!std::strncmp(Data, Port.data(), Port.size()) && |
| !isIdentifierBody(Data[Port.size()])) |
| return; |
| |
| std::string Replacement = |
| ((IsSigned ? SignedTypePrefix : UnsignedTypePrefix) + Twine(Width) + |
| (AddUnderscoreT ? "_t" : "")).str(); |
| |
| // We don't add a fix-it as changing the type can easily break code, |
| // e.g. when a function requires a 'long' argument on all platforms. |
| // QualTypes are printed with implicit quotes. |
| diag(Loc, "consider replacing %0 with '%1'") << BuiltinLoc.getType() |
| << Replacement; |
| } |
| |
| } // namespace runtime |
| } // namespace tidy |
| } // namespace clang |