blob: cb7544ec75ca53654f51198bad02d19b9d17390f [file] [log] [blame]
// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
library linter.src.rules.sort_unnamed_constructors_first;
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:linter/src/analyzer.dart';
const desc = r'Sort unnamed constructor declarations first';
const details = r'''
**DO** sort unnamed constructor declarations first, before named ones.
**Good:**
```
abstract class CancelableFuture<T> implements Future<T> {
factory CancelableFuture(computation()) => ...
factory CancelableFuture.delayed(Duration duration, [computation()]) => ...
...
}
```
**Bad:**
```
class _PriorityItem {
factory _PriorityItem.forName(bool isStatic, String name, _MemberKind kind) => ...
_PriorityItem(this.isStatic, this.kind, this.isPrivate);
...
}
```
''';
class SortUnnamedConstructorsFirst extends LintRule {
SortUnnamedConstructorsFirst()
: super(
name: 'sort_unnamed_constructors_first',
description: desc,
details: details,
group: Group.style);
@override
AstVisitor getVisitor() => new Visitor(this);
}
class Visitor extends SimpleAstVisitor {
final LintRule rule;
Visitor(this.rule);
@override
visitClassDeclaration(ClassDeclaration decl) {
// Sort members by offset.
List<ClassMember> members = decl.members.toList()
..sort((ClassMember m1, ClassMember m2) => m1.offset - m2.offset);
bool seenConstructor = false;
for (ClassMember member in members) {
if (member is ConstructorDeclaration) {
if (member.name == null) {
if (seenConstructor) {
rule.reportLint(member.returnType);
}
} else {
seenConstructor = true;
}
}
}
}
}