Merge pull request #28 from google/fixNaming
Fix naming
diff --git a/README.md b/README.md
index bcde6ec..d48424b 100644
--- a/README.md
+++ b/README.md
@@ -14,14 +14,14 @@
mv generated/* lib/src/generated/
```
-## Whitelisting
+## Limiting bindings to actual symbols
Some GL libraries come with headers that list functions not implemented. This
will fail at link time. To avoid this, you can dump the symbols in libGLESv2.so
-to be whitelisted and use the `--whitelist flag in`tools/gl_generator.dart`
+to be used with `--limit-api` flag in`tools/gl_generator.dart`
```shell
-nm -D /lib/libGLESv2.so | grep " T " | awk '{print $3}' > whitelist.txt
+nm -D /lib/libGLESv2.so | grep " T " | awk '{print $3}' > limit.txt
```
# Steps to compile the bindings
diff --git a/tools/gl_generator.dart b/tools/gl_generator.dart
index 72fceb4..2c6878c 100644
--- a/tools/gl_generator.dart
+++ b/tools/gl_generator.dart
@@ -8,7 +8,7 @@
String outPath;
/// Specific APIs that need manual bindings, but we're too lazy to write them.
-var blacklist = new Set.from([
+var manualBindingList = new Set.from([
// Commands is not a string - it is typed data of length numCommands
'glPathCommandsNV',
]);
@@ -23,10 +23,10 @@
valueHelp: 'path')
..addOption('out',
help: 'path to output directory', abbr: 'o', valueHelp: 'path')
- ..addOption('whitelist',
+ ..addOption('limit-api',
help: 'list of functions that are bound',
- abbr: 'w',
- valueHelp: 'whitelist.txt')
+ abbr: 'l',
+ valueHelp: 'limit.txt')
..addFlag('debug-dll',
negatable: true,
defaultsTo: false,
@@ -638,9 +638,9 @@
name = norms[1];
returnType = norms[0];
- if (blacklist.contains(name)) {
+ if (manualBindingList.contains(name)) {
needsManualBinding = true;
- print("$name NEEDS MANUAL BINDING: check the blacklist");
+ print("$name NEEDS MANUAL BINDING: check the manualBindingList");
}
int noName = 0;
