commit e1d1311cfb6312cd44e086c879f3e95cbfa0eb9d
author Tom Conerly <tomconerly@gmail.com> Mon Jul 27 18:35:29 2015
committer Aliaksey Kandratsenka <alk@tut.by> Sat Aug 01 19:34:08 2015
tree dc74b1b2ecdd97a419c9acd4a7cd6355a47f7c55
parent b5b79860fd2b8e1a9b0573e93f942695f2992b59

issue-699: Free list on error paths

src/heap-profile-table.cc

diff --git a/src/heap-profile-table.cc b/src/heap-profile-table.cc
index 5191afb..7486468 100644
--- a/src/heap-profile-table.cc
+++ b/src/heap-profile-table.cc
@@ -350,7 +350,10 @@
   // is remaining, and then move the maps info one last time to close
   // any gaps.  Whew!
   int map_length = snprintf(buf, size, "%s", kProcSelfMapsHeader);
-  if (map_length < 0 || map_length >= size) return 0;
+  if (map_length < 0 || map_length >= size) {
+      dealloc_(list);
+      return 0;
+  }
   bool dummy;   // "wrote_all" -- did /proc/self/maps fit in its entirety?
   map_length += FillProcSelfMaps(buf + map_length, size - map_length, &dummy);
   RAW_DCHECK(map_length <= size, "");
@@ -361,7 +364,10 @@
   Stats stats;
   memset(&stats, 0, sizeof(stats));
   int bucket_length = snprintf(buf, size, "%s", kProfileHeader);
-  if (bucket_length < 0 || bucket_length >= size) return 0;
+  if (bucket_length < 0 || bucket_length >= size) {
+      dealloc_(list);
+      return 0;
+  }
   bucket_length = UnparseBucket(total_, buf, bucket_length, size,
                                 " heapprofile", &stats);