commit 49e63e0751263a23b3c79f99c49175ac800ddda2
author Mohan Maiya <m.maiya@samsung.com> Wed Apr 03 20:22:30 2024
committer Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Apr 06 03:16:38 2024
tree e2c4853d7dc086ae14fa0922e35c47cf3f3fca50
parent ad13fec33da34c4bac8ef99441924e9386dd47c8

Vulkan: Selectively wait for WarmUp tasks

If the GraphicsPipelineDesc used by a draw call differs from the
one being used by the WarmUp tasks there is no need to wait for
their completion.

Bug: angleproject:8297
Change-Id: Ibbf3ee710036936060990455bb8657d83c7b6faf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5421594
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>

src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp

diff --git a/src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp b/src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp
index bfe2d81..ff58e50 100644
--- a/src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp
+++ b/src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp
@@ -1027,7 +1027,22 @@
         return;
     }
 
-    // Wait unconditionally for now.
+    const vk::GraphicsPipelineSubset subset =
+        contextVk->getFeatures().supportsGraphicsPipelineLibrary.enabled
+            ? vk::GraphicsPipelineSubset::Shaders
+            : vk::GraphicsPipelineSubset::Complete;
+
+    if (currentGraphicsPipelineDesc &&
+        (mWarmUpGraphicsPipelineDesc.hash(subset) != currentGraphicsPipelineDesc->hash(subset)))
+    {
+        // The GraphicsPipelineDesc used for warmup differs from the one used by the draw call.
+        // There is no need to wait for the warmup tasks to complete.
+        ANGLE_PERF_WARNING(
+            contextVk->getDebug(), GL_DEBUG_SEVERITY_LOW,
+            "GraphicsPipelineDesc used for warmup differs from the one used by draw.");
+        return;
+    }
+
     waitForPostLinkTasksImpl(contextVk);
 }