commit 21add1240950c2e2a6ec997f9a128005d84266b6
author Jamie Madill <jmadill@chromium.org> Sun Oct 25 19:55:45 2020
committer Commit Bot <commit-bot@chromium.org> Mon Oct 26 14:21:03 2020
tree 1c28775bbdcca2d9a86d2ba874b6bd883dfac3bb
parent d6d07359d2eb821b9b1b6ef1a5e6f5f25529d422

Re-enable crash testing in angle_unittests.

This is an experimental test to see if this works now.
Disabled on Win/ASAN because of conflicts with the
crash callback.

Bug: angleproject:5239
Change-Id: I280b18ab8846de79b561f26716df9ba374cfd9a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2496040
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

src/tests/test_utils/runner/TestSuite_unittest.cpp

diff --git a/src/tests/test_utils/runner/TestSuite_unittest.cpp b/src/tests/test_utils/runner/TestSuite_unittest.cpp
index fc6edd7..c5a7bd1 100644
--- a/src/tests/test_utils/runner/TestSuite_unittest.cpp
+++ b/src/tests/test_utils/runner/TestSuite_unittest.cpp
@@ -83,7 +83,10 @@
         {{"MockTestSuiteTest", "DISABLED_Pass"}, {TestResultType::Pass, 0.0}},
         {{"MockTestSuiteTest", "DISABLED_Fail"}, {TestResultType::Fail, 0.0}},
         {{"MockTestSuiteTest", "DISABLED_Timeout"}, {TestResultType::Timeout, 0.0}},
-        // {{"MockTestSuiteTest", "DISABLED_Crash"}, {TestResultType::Crash, 0.0}},
+    // Issues with ASAN on Windows. http://anglebug.com/5238
+#if !defined(ANGLE_PLATFORM_WINDOWS) || !defined(ANGLE_WITH_ASAN)
+        {{"MockTestSuiteTest", "DISABLED_Crash"}, {TestResultType::Crash, 0.0}},
+#endif  // !defined(ANGLE_PLATFORM_WINDOWS) || !defined(ANGLE_WITH_ASAN)
     };
 
     EXPECT_EQ(expectedResults, actual.results);
@@ -107,9 +110,12 @@
     angle::Sleep(20000);
 }
 
+// Issues with ASAN on Windows. http://anglebug.com/5238
+#if !defined(ANGLE_PLATFORM_WINDOWS) || !defined(ANGLE_WITH_ASAN)
 // Trigger a test crash.
-// TEST(MockTestSuiteTest, DISABLED_Crash)
-// {
-//     ANGLE_CRASH();
-// }
+TEST(MockTestSuiteTest, DISABLED_Crash)
+{
+    ANGLE_CRASH();
+}
+#endif  // !defined(ANGLE_PLATFORM_WINDOWS) || !defined(ANGLE_WITH_ASAN)
 }  // namespace