update_engine: Fix non inclusive vocabulary
BUG=None
TEST=CQ Passes
Change-Id: Ic321806ab6029c88723c220f243e2c2c7a9e94f0
Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2267058
Tested-by: Andrew Lassalle <andrewlassalle@chromium.org>
Auto-Submit: Andrew Lassalle <andrewlassalle@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Commit-Queue: Amin Hassani <ahassani@chromium.org>
diff --git a/common/test_utils.h b/common/test_utils.h
index 44b7aa1..63ea749 100644
--- a/common/test_utils.h
+++ b/common/test_utils.h
@@ -78,7 +78,7 @@
void FillWithData(brillo::Blob* buffer);
-// Compare the value of native array for download source parameter.
+// Compare the value of builtin array for download source parameter.
MATCHER_P(DownloadSourceMatcher, source_array, "") {
return std::equal(source_array, source_array + kNumDownloadSources, arg);
}
diff --git a/hardware_chromeos.cc b/hardware_chromeos.cc
index 5c32648..2aae9f0 100644
--- a/hardware_chromeos.cc
+++ b/hardware_chromeos.cc
@@ -50,7 +50,7 @@
const char kOOBECompletedMarker[] = "/home/chronos/.oobe_completed";
// The stateful directory used by update_engine to store powerwash-safe files.
-// The files stored here must be whitelisted in the powerwash scripts.
+// The files stored here must be added to the powerwash script allowlist.
const char kPowerwashSafeDirectory[] =
"/mnt/stateful_partition/unencrypted/preserve";
diff --git a/omaha_request_params.h b/omaha_request_params.h
index 3452965..76fc806 100644
--- a/omaha_request_params.h
+++ b/omaha_request_params.h
@@ -328,7 +328,7 @@
bool ToMoreStableChannel() const;
// Returns True if we should store the fw/ec versions based on our hwid_.
- // Compares hwid to a set of whitelisted prefixes.
+ // Compares hwid to a set of prefixes in the allowlist.
bool CollectECFWVersions() const;
// Gets the machine type (e.g. "i686").
diff --git a/payload_generator/delta_diff_utils.cc b/payload_generator/delta_diff_utils.cc
index 53a3cf1..ded30fb 100644
--- a/payload_generator/delta_diff_utils.cc
+++ b/payload_generator/delta_diff_utils.cc
@@ -708,15 +708,15 @@
version.OperationAllowed(InstallOperation::SOURCE_BSDIFF);
if (bsdiff_allowed &&
blocks_to_read * kBlockSize > kMaxBsdiffDestinationSize) {
- LOG(INFO) << "bsdiff blacklisted, data too big: "
- << blocks_to_read * kBlockSize << " bytes";
+ LOG(INFO) << "bsdiff ignored, data too big: " << blocks_to_read * kBlockSize
+ << " bytes";
bsdiff_allowed = false;
}
bool puffdiff_allowed = version.OperationAllowed(InstallOperation::PUFFDIFF);
if (puffdiff_allowed &&
blocks_to_read * kBlockSize > kMaxPuffdiffDestinationSize) {
- LOG(INFO) << "puffdiff blacklisted, data too big: "
+ LOG(INFO) << "puffdiff ignored, data too big: "
<< blocks_to_read * kBlockSize << " bytes";
puffdiff_allowed = false;
}
diff --git a/payload_state.cc b/payload_state.cc
index d626056..ce3e1d5 100644
--- a/payload_state.cc
+++ b/payload_state.cc
@@ -1161,7 +1161,7 @@
void PayloadState::SetRollbackVersion(const string& rollback_version) {
CHECK(powerwash_safe_prefs_);
- LOG(INFO) << "Blacklisting version " << rollback_version;
+ LOG(INFO) << "Excluding version " << rollback_version;
rollback_version_ = rollback_version;
powerwash_safe_prefs_->SetString(kPrefsRollbackVersion, rollback_version);
}
diff --git a/payload_state.h b/payload_state.h
index 5713a54..77197a7 100644
--- a/payload_state.h
+++ b/payload_state.h
@@ -368,14 +368,14 @@
// check where policy was available. This info is preserved over powerwash.
void LoadRollbackHappened();
- // Loads the blacklisted version from our prefs file.
+ // Loads the excluded version from our prefs file.
void LoadRollbackVersion();
- // Blacklists this version from getting AU'd to until we receive a new update
+ // Excludes this version from getting AU'd to until we receive a new update
// response.
void SetRollbackVersion(const std::string& rollback_version);
- // Clears any blacklisted version.
+ // Clears any excluded version.
void ResetRollbackVersion();
inline uint32_t GetUrlIndex() {
@@ -567,7 +567,7 @@
// forced updates to avoid update-rollback loops.
bool rollback_happened_;
- // This stores a blacklisted version set as part of rollback. When we rollback
+ // This stores an excluded version set as part of rollback. When we rollback
// we store the version of the os from which we are rolling back from in order
// to guarantee that we do not re-update to it on the next au attempt after
// reboot.
diff --git a/payload_state_unittest.cc b/payload_state_unittest.cc
index 0bf52d9..8667548 100644
--- a/payload_state_unittest.cc
+++ b/payload_state_unittest.cc
@@ -1016,7 +1016,7 @@
NiceMock<MockPrefs>* mock_powerwash_safe_prefs =
fake_system_state.mock_powerwash_safe_prefs();
- // Mock out the os version and make sure it's blacklisted correctly.
+ // Mock out the os version and make sure it's excluded correctly.
string rollback_version = "2345.0.0";
OmahaRequestParams params(&fake_system_state);
params.Init(rollback_version, "", false);
diff --git a/pylintrc b/pylintrc
index 33adec2..a433868 100644
--- a/pylintrc
+++ b/pylintrc
@@ -24,7 +24,7 @@
# Profiled execution.
profile=no
-# Add files or directories to the blacklist. They should be base names, not
+# Add files or directories to the ignorelist. They should be base names, not
# paths.
ignore=CVS,.svn,.git,update_metadata_pb2.py
diff --git a/update_manager/chromeos_policy.cc b/update_manager/chromeos_policy.cc
index cc10b57..c310e42 100644
--- a/update_manager/chromeos_policy.cc
+++ b/update_manager/chromeos_policy.cc
@@ -465,7 +465,7 @@
// ConnectionManager::IsUpdateAllowedOver(); be sure to deprecate the latter.
//
// TODO(garnold) The current logic generally treats the list of allowed
-// connections coming from the device policy as a whitelist, meaning that it
+// connections coming from the device policy as an allowlist, meaning that it
// can only be used for enabling connections, but not disable them. Further,
// certain connection types cannot be enabled even by policy.
// In effect, the only thing that device policy can change is to enable
