Google Git
Sign in
chromium / aosp / platform / system / update_engine / refs/heads/master / . / cros / update_attempter_unittest.cc
blob: 6d0a1860b5538ba0edfad07345eed59eb3687933 [file] [log] [blame]
//
// Copyright (C) 2012 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
#include "update_engine/cros/update_attempter.h"
#include <stdint.h>
#include <algorithm>
#include <limits>
#include <map>
#include <memory>
#include <optional>
#include <string>
#include <unordered_set>
#include <base/files/file_util.h>
#include <base/files/scoped_temp_dir.h>
#include <base/functional/callback_helpers.h>
#include <base/logging.h>
#include <base/task/single_thread_task_executor.h>
#include <brillo/message_loops/base_message_loop.h>
#include <brillo/message_loops/message_loop.h>
#include <brillo/message_loops/message_loop_utils.h>
#include <gmock/gmock.h>
#include <gtest/gtest.h>
#include <policy/libpolicy.h>
#include <policy/mock_device_policy.h>
#include <policy/mock_libpolicy.h>
#include <update_engine/dbus-constants.h>
#include "update_engine/common/constants.h"
#include "update_engine/common/dlcservice_interface.h"
#include "update_engine/common/mock_action.h"
#include "update_engine/common/mock_action_processor.h"
#include "update_engine/common/mock_http_fetcher.h"
#include "update_engine/common/mock_service_observer.h"
#include "update_engine/common/platform_constants.h"
#include "update_engine/common/prefs.h"
#include "update_engine/common/test_utils.h"
#include "update_engine/common/utils.h"
#include "update_engine/cros/download_action_chromeos.h"
#include "update_engine/cros/fake_system_state.h"
#include "update_engine/cros/metrics_reporter_omaha.h"
#include "update_engine/cros/mock_p2p_manager.h"
#include "update_engine/cros/mock_payload_state.h"
#include "update_engine/cros/omaha_utils.h"
#include "update_engine/libcurl_http_fetcher.h"
#include "update_engine/payload_consumer/filesystem_verifier_action.h"
#include "update_engine/payload_consumer/install_plan.h"
#include "update_engine/payload_consumer/payload_constants.h"
#include "update_engine/payload_consumer/postinstall_runner_action.h"
#include "update_engine/update_boot_flags_action.h"
#include "update_engine/update_manager/fake_device_policy_provider.h"
using base::Time;
using base::TimeDelta;
using chromeos_update_manager::EvalStatus;
using chromeos_update_manager::StagingSchedule;
using chromeos_update_manager::UpdateCheckAllowedPolicyData;
using chromeos_update_manager::UpdateCheckParams;
using policy::DevicePolicy;
using std::map;
using std::string;
using std::unique_ptr;
using std::unordered_set;
using std::vector;
using testing::_;
using testing::Contains;
using testing::DoAll;
using testing::ElementsAre;
using testing::Field;
using testing::InSequence;
using testing::Invoke;
using testing::Ne;
using testing::NiceMock;
using testing::Pointee;
using testing::Property;
using testing::Return;
using testing::ReturnPointee;
using testing::ReturnRef;
using testing::SaveArg;
using testing::SetArgPointee;
using update_engine::UpdateEngineStatus;
using update_engine::UpdateFlags;
using update_engine::UpdateParams;
using update_engine::UpdateStatus;
namespace chromeos_update_engine {
namespace {
const UpdateStatus kNonIdleOrRebootUpdateStatuses[] = {
UpdateStatus::CHECKING_FOR_UPDATE,
UpdateStatus::UPDATE_AVAILABLE,
UpdateStatus::DOWNLOADING,
UpdateStatus::VERIFYING,
UpdateStatus::FINALIZING,
UpdateStatus::REPORTING_ERROR_EVENT,
UpdateStatus::ATTEMPTING_ROLLBACK,
UpdateStatus::DISABLED,
UpdateStatus::NEED_PERMISSION_TO_UPDATE,
UpdateStatus::UPDATED_BUT_DEFERRED,
};
struct CheckForUpdateTestParams {
// Setups + Inputs:
UpdateStatus status = UpdateStatus::IDLE;
string app_version = "fake_app_version";
string omaha_url = "fake_omaha_url";
bool non_interactive = false;
bool is_official_build = true;
bool are_dev_features_enabled = false;
bool skip_applying = false;
// Expects:
string expected_forced_app_version = "";
string expected_forced_omaha_url = "";
bool should_schedule_updates_be_called = true;
bool expected_result = true;
};
struct OnUpdateScheduledTestParams {
// Setups + Inputs:
UpdateCheckParams params = {};
EvalStatus status = EvalStatus::kFailed;
// Expects:
UpdateStatus exit_status = UpdateStatus::IDLE;
bool should_schedule_updates_be_called = false;
bool should_update_be_called = false;
};
struct ProcessingDoneTestParams {
// Setups + Inputs:
ProcessMode pm = ProcessMode::UPDATE;
UpdateStatus status = UpdateStatus::CHECKING_FOR_UPDATE;
ActionProcessor* processor = nullptr;
ErrorCode code = ErrorCode::kSuccess;
map<string, OmahaRequestParams::AppParams> dlc_apps_params;
bool skip_applying = false;
// Expects:
const ProcessMode kExpectedProcessMode = ProcessMode::UPDATE;
bool should_schedule_updates_be_called = true;
UpdateStatus expected_exit_status = UpdateStatus::IDLE;
bool should_install_completed_be_called = false;
bool should_update_completed_be_called = false;
vector<string> args_to_install_completed;
vector<string> args_to_update_completed;
};
class MockDlcService : public DlcServiceInterface {
public:
MOCK_METHOD1(GetDlcsToUpdate, bool(vector<string>*));
MOCK_METHOD1(InstallCompleted, bool(const vector<string>&));
MOCK_METHOD1(UpdateCompleted, bool(const vector<string>&));
};
} // namespace
const char kRollbackVersion[] = "10575.39.2";
// Test a subclass rather than the main class directly so that we can mock out
// methods within the class. There're explicit unit tests for the mocked out
// methods.
class UpdateAttempterUnderTest : public UpdateAttempter {
public:
UpdateAttempterUnderTest() : UpdateAttempter(nullptr) {}
void Update(const UpdateCheckParams& params) override {
update_called_ = true;
if (do_update_) {
UpdateAttempter::Update(params);
return;
}
LOG(INFO) << "[TEST] Update() disabled.";
status_ = UpdateStatus::CHECKING_FOR_UPDATE;
}
void DisableUpdate() { do_update_ = false; }
bool WasUpdateCalled() const { return update_called_; }
// Wrap the update scheduling method, allowing us to opt out of scheduled
// updates for testing purposes.
bool ScheduleUpdates(const ScheduleUpdatesParams& params = {}) override {
schedule_updates_called_ = true;
if (do_schedule_updates_)
return UpdateAttempter::ScheduleUpdates();
LOG(INFO) << "[TEST] Update scheduling disabled.";
waiting_for_scheduled_check_ = true;
return true;
}
void DisableScheduleUpdates() { do_schedule_updates_ = false; }
// Indicates whether |ScheduleUpdates()| was called.
bool WasScheduleUpdatesCalled() const { return schedule_updates_called_; }
// Need to expose following private members of |UpdateAttempter| for tests.
const string& forced_app_version() const { return forced_app_version_; }
const string& forced_omaha_url() const { return forced_omaha_url_; }
// Need to expose |waiting_for_scheduled_check_| for testing.
void SetWaitingForScheduledCheck(bool waiting) {
waiting_for_scheduled_check_ = waiting;
}
private:
// Used for overrides of |Update()|.
bool update_called_ = false;
bool do_update_ = true;
// Used for overrides of |ScheduleUpdates()|.
bool schedule_updates_called_ = false;
bool do_schedule_updates_ = true;
};
class UpdateAttempterTest : public ::testing::Test {
protected:
void SetUp() override {
loop_.SetAsCurrent();
// Override system state members.
FakeSystemState::CreateInstance();
FakeSystemState::Get()->set_connection_manager(&mock_connection_manager);
FakeSystemState::Get()->set_update_attempter(&attempter_);
FakeSystemState::Get()->set_dlcservice(&mock_dlcservice_);
FakeSystemState::Get()->set_dlc_utils(&mock_dlc_utils_);
prefs_ = FakeSystemState::Get()->fake_prefs();
certificate_checker_.reset(
new CertificateChecker(prefs_, &openssl_wrapper_));
certificate_checker_->Init();
attempter_.set_forced_update_pending_callback(
new base::RepeatingCallback<void(bool, bool)>(base::DoNothing()));
// Finish initializing the attempter.
attempter_.Init();
EXPECT_EQ(0, attempter_.http_response_code_);
EXPECT_EQ(UpdateStatus::IDLE, attempter_.status_);
EXPECT_EQ(0.0, attempter_.download_progress_);
EXPECT_EQ(0, attempter_.last_checked_time_);
EXPECT_EQ("0.0.0.0", attempter_.new_version_);
EXPECT_EQ(0ULL, attempter_.new_payload_size_);
processor_ = new NiceMock<MockActionProcessor>();
attempter_.processor_.reset(processor_); // Transfers ownership.
// Setup store/load semantics of P2P properties via the mock |PayloadState|.
actual_using_p2p_for_downloading_ = false;
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
SetUsingP2PForDownloading(_))
.WillRepeatedly(SaveArg<0>(&actual_using_p2p_for_downloading_));
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
GetUsingP2PForDownloading())
.WillRepeatedly(ReturnPointee(&actual_using_p2p_for_downloading_));
actual_using_p2p_for_sharing_ = false;
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
SetUsingP2PForSharing(_))
.WillRepeatedly(SaveArg<0>(&actual_using_p2p_for_sharing_));
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
GetUsingP2PForDownloading())
.WillRepeatedly(ReturnPointee(&actual_using_p2p_for_sharing_));
}
void TearDown() override {
prefs_->Delete(kPrefsAllowRepeatedUpdates);
prefs_->Delete(kPrefsConsecutiveUpdateCount);
}
public:
void ScheduleQuitMainLoop();
// Callbacks to run the different tests from the main loop.
void UpdateTestStart();
void UpdateTestVerify();
void RollbackTestStart(bool enterprise_rollback, bool valid_slot);
void RollbackTestVerify();
void PingOmahaTestStart();
void ReadScatterFactorFromPolicyTestStart();
void DecrementUpdateCheckCountTestStart();
void NoScatteringDoneDuringManualUpdateTestStart();
void P2PNotEnabledStart();
void P2PEnabledStart();
void P2PEnabledInteractiveStart();
void P2PEnabledStartingFailsStart();
void P2PEnabledHousekeepingFailsStart();
void SessionIdTestChange();
void SessionIdTestEnforceEmptyStrPingOmaha();
void SessionIdTestConsistencyInUpdateFlow();
void SessionIdTestInDownloadAction();
void ResetRollbackHappenedStart(bool is_consumer,
bool is_policy_available,
bool expected_reset);
// Staging related callbacks.
void SetUpStagingTest(const StagingSchedule& schedule);
void CheckStagingOff();
void StagingSetsPrefsAndTurnsOffScatteringStart();
void StagingOffIfInteractiveStart();
void StagingOffIfOobeStart();
bool actual_using_p2p_for_downloading() {
return actual_using_p2p_for_downloading_;
}
bool actual_using_p2p_for_sharing() { return actual_using_p2p_for_sharing_; }
// |CheckForUpdate()| related member functions.
void TestCheckForUpdate();
// |OnUpdateScheduled()| related member functions.
void TestOnUpdateScheduled();
// |ProcessingDone()| related member functions.
void TestProcessingDone();
base::SingleThreadTaskExecutor base_loop_{base::MessagePumpType::IO};
brillo::BaseMessageLoop loop_{base_loop_.task_runner()};
UpdateAttempterUnderTest attempter_;
OpenSSLWrapper openssl_wrapper_;
std::unique_ptr<CertificateChecker> certificate_checker_;
MockDlcService mock_dlcservice_;
MockDlcUtils mock_dlc_utils_;
NiceMock<MockActionProcessor>* processor_;
NiceMock<MockConnectionManager> mock_connection_manager;
FakePrefs* prefs_;
// |CheckForUpdate()| test params.
CheckForUpdateTestParams cfu_params_;
// |OnUpdateScheduled()| test params.
OnUpdateScheduledTestParams ous_params_;
// |ProcessingDone()| test params.
ProcessingDoneTestParams pd_params_;
bool actual_using_p2p_for_downloading_;
bool actual_using_p2p_for_sharing_;
};
void UpdateAttempterTest::TestCheckForUpdate() {
// Setup
attempter_.status_ = cfu_params_.status;
FakeSystemState::Get()->fake_hardware()->SetIsOfficialBuild(
cfu_params_.is_official_build);
FakeSystemState::Get()->fake_hardware()->SetAreDevFeaturesEnabled(
cfu_params_.are_dev_features_enabled);
// Invocation
UpdateParams update_params;
update_params.set_app_version(cfu_params_.app_version);
update_params.set_omaha_url(cfu_params_.omaha_url);
update_params.mutable_update_flags()->set_non_interactive(
cfu_params_.non_interactive);
update_params.set_skip_applying(cfu_params_.skip_applying);
EXPECT_EQ(cfu_params_.expected_result,
attempter_.CheckForUpdate(update_params));
// Verify
EXPECT_EQ(cfu_params_.expected_forced_app_version,
attempter_.forced_app_version());
EXPECT_EQ(cfu_params_.expected_forced_omaha_url,
attempter_.forced_omaha_url());
EXPECT_EQ(cfu_params_.should_schedule_updates_be_called,
attempter_.WasScheduleUpdatesCalled());
}
void UpdateAttempterTest::TestProcessingDone() {
// Setup
attempter_.DisableScheduleUpdates();
attempter_.pm_ = pd_params_.pm;
attempter_.status_ = pd_params_.status;
attempter_.omaha_request_params_->set_dlc_apps_params(
pd_params_.dlc_apps_params);
attempter_.skip_applying_ = pd_params_.skip_applying;
// Expects
if (pd_params_.should_install_completed_be_called)
EXPECT_CALL(mock_dlcservice_,
InstallCompleted(pd_params_.args_to_install_completed))
.WillOnce(Return(true));
else
EXPECT_CALL(mock_dlcservice_, InstallCompleted(_)).Times(0);
if (pd_params_.should_update_completed_be_called)
EXPECT_CALL(mock_dlcservice_,
UpdateCompleted(pd_params_.args_to_update_completed))
.WillOnce(Return(true));
else
EXPECT_CALL(mock_dlcservice_, UpdateCompleted(_)).Times(0);
// Invocation
attempter_.ProcessingDone(pd_params_.processor, pd_params_.code);
// Verify
EXPECT_EQ(pd_params_.kExpectedProcessMode, attempter_.pm_);
EXPECT_EQ(pd_params_.should_schedule_updates_be_called,
attempter_.WasScheduleUpdatesCalled());
EXPECT_EQ(pd_params_.expected_exit_status, attempter_.status_);
}
void UpdateAttempterTest::ScheduleQuitMainLoop() {
loop_.PostTask(
FROM_HERE,
base::BindOnce([](brillo::BaseMessageLoop* loop) { loop->BreakLoop(); },
base::Unretained(&loop_)));
}
void UpdateAttempterTest::SessionIdTestChange() {
EXPECT_NE(UpdateStatus::UPDATED_NEED_REBOOT, attempter_.status());
const auto old_session_id = attempter_.session_id_;
attempter_.Update({});
EXPECT_NE(old_session_id, attempter_.session_id_);
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, SessionIdTestChange) {
loop_.PostTask(FROM_HERE,
base::BindOnce(&UpdateAttempterTest::SessionIdTestChange,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::SessionIdTestEnforceEmptyStrPingOmaha() {
// The |session_id_| should not be changed and should remain as an empty
// string when |status_| is |UPDATED_NEED_REBOOT| (only for consistency)
// and |PingOmaha()| is called.
attempter_.DisableScheduleUpdates();
attempter_.status_ = UpdateStatus::UPDATED_NEED_REBOOT;
const auto old_session_id = attempter_.session_id_;
auto CheckIfEmptySessionId = [](AbstractAction* aa) {
if (aa->Type() == OmahaRequestAction::StaticType()) {
EXPECT_TRUE(static_cast<OmahaRequestAction*>(aa)->session_id_.empty());
}
};
EXPECT_CALL(*processor_, EnqueueAction(Pointee(_)))
.WillRepeatedly(Invoke(CheckIfEmptySessionId));
EXPECT_CALL(*processor_, StartProcessing());
attempter_.PingOmaha();
EXPECT_EQ(old_session_id, attempter_.session_id_);
EXPECT_EQ(UpdateStatus::UPDATED_NEED_REBOOT, attempter_.status_);
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, SessionIdTestEnforceEmptyStrPingOmaha) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(
&UpdateAttempterTest::SessionIdTestEnforceEmptyStrPingOmaha,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::SessionIdTestConsistencyInUpdateFlow() {
// All session IDs passed into |OmahaRequestActions| should be enforced to
// have the same value in |BuildUpdateActions()|.
unordered_set<string> session_ids;
// Gather all the session IDs being passed to |OmahaRequestActions|.
auto CheckSessionId = [&session_ids](AbstractAction* aa) {
if (aa->Type() == OmahaRequestAction::StaticType())
session_ids.insert(static_cast<OmahaRequestAction*>(aa)->session_id_);
};
EXPECT_CALL(*processor_, EnqueueAction(Pointee(_)))
.WillRepeatedly(Invoke(CheckSessionId));
attempter_.BuildUpdateActions({
.interactive = false,
});
// Validate that all the session IDs are the same.
EXPECT_EQ(1, session_ids.size());
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, SessionIdTestConsistencyInUpdateFlow) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::SessionIdTestConsistencyInUpdateFlow,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::SessionIdTestInDownloadAction() {
// The session ID passed into |DownloadAction|'s |LibcurlHttpFetcher| should
// be enforced to be included in the HTTP header as X-Goog-Update-SessionId.
string header_value;
auto CheckSessionIdInDownloadAction = [&header_value](AbstractAction* aa) {
if (aa->Type() == DownloadActionChromeos::StaticType()) {
DownloadActionChromeos* da = static_cast<DownloadActionChromeos*>(aa);
EXPECT_TRUE(da->http_fetcher()->GetHeader(kXGoogleUpdateSessionId,
&header_value));
}
};
EXPECT_CALL(*processor_, EnqueueAction(Pointee(_)))
.WillRepeatedly(Invoke(CheckSessionIdInDownloadAction));
attempter_.BuildUpdateActions({
.interactive = false,
});
// Validate that X-Goog-Update_SessionId is set correctly in HTTP Header.
EXPECT_EQ(attempter_.session_id_, header_value);
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, SessionIdTestInDownloadAction) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::SessionIdTestInDownloadAction,
base::Unretained(this)));
loop_.Run();
}
TEST_F(UpdateAttempterTest, ActionCompletedDownloadTest) {
auto fetcher = std::make_unique<MockHttpFetcher>("", 0, nullptr);
fetcher->FailTransfer(503); // Sets the HTTP response code.
DownloadActionChromeos action(std::move(fetcher), /*interactive=*/false);
attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
EXPECT_FALSE(prefs_->Exists(kPrefsDeltaUpdateFailures));
EXPECT_EQ(UpdateStatus::FINALIZING, attempter_.status());
EXPECT_EQ(0.0, attempter_.download_progress_);
ASSERT_EQ(nullptr, attempter_.error_event_.get());
}
TEST_F(UpdateAttempterTest, ActionCompletedErrorTest) {
MockAction action;
EXPECT_CALL(action, Type()).WillRepeatedly(Return("MockAction"));
attempter_.status_ = UpdateStatus::DOWNLOADING;
attempter_.ActionCompleted(nullptr, &action, ErrorCode::kError);
ASSERT_NE(nullptr, attempter_.error_event_.get());
}
TEST_F(UpdateAttempterTest, DownloadProgressAccumulationTest) {
// Simple test case, where all the values match (nothing was skipped)
uint64_t bytes_progressed_1 = 1024 * 1024; // 1MB
uint64_t bytes_progressed_2 = 1024 * 1024; // 1MB
uint64_t bytes_received_1 = bytes_progressed_1;
uint64_t bytes_received_2 = bytes_received_1 + bytes_progressed_2;
uint64_t bytes_total = 20 * 1024 * 1024; // 20MB
double progress_1 =
static_cast<double>(bytes_received_1) / static_cast<double>(bytes_total);
double progress_2 =
static_cast<double>(bytes_received_2) / static_cast<double>(bytes_total);
EXPECT_EQ(0.0, attempter_.download_progress_);
// This is set via inspecting the InstallPlan payloads when the
// |OmahaResponseAction| is completed.
attempter_.new_payload_size_ = bytes_total;
NiceMock<MockServiceObserver> observer;
EXPECT_CALL(observer,
SendStatusUpdate(AllOf(
Field(&UpdateEngineStatus::progress, progress_1),
Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
EXPECT_CALL(observer,
SendStatusUpdate(AllOf(
Field(&UpdateEngineStatus::progress, progress_2),
Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
attempter_.AddObserver(&observer);
attempter_.BytesReceived(bytes_progressed_1, bytes_received_1, bytes_total);
EXPECT_EQ(progress_1, attempter_.download_progress_);
// This iteration validates that a later set of updates to the variables are
// properly handled (so that |getStatus()| will return the same progress info
// as the callback is receiving.
attempter_.BytesReceived(bytes_progressed_2, bytes_received_2, bytes_total);
EXPECT_EQ(progress_2, attempter_.download_progress_);
}
TEST_F(UpdateAttempterTest, ChangeToDownloadingOnReceivedBytesTest) {
// The transition into |UpdateStatus::DOWNLOADING| happens when the
// first bytes are received.
uint64_t bytes_progressed = 1024 * 1024; // 1MB
uint64_t bytes_received = 2 * 1024 * 1024; // 2MB
uint64_t bytes_total = 20 * 1024 * 1024; // 300MB
attempter_.status_ = UpdateStatus::CHECKING_FOR_UPDATE;
// This is set via inspecting the InstallPlan payloads when the
// |OmahaResponseAction| is completed.
attempter_.new_payload_size_ = bytes_total;
EXPECT_EQ(0.0, attempter_.download_progress_);
NiceMock<MockServiceObserver> observer;
EXPECT_CALL(observer,
SendStatusUpdate(AllOf(
Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
attempter_.AddObserver(&observer);
attempter_.BytesReceived(bytes_progressed, bytes_received, bytes_total);
EXPECT_EQ(UpdateStatus::DOWNLOADING, attempter_.status_);
}
TEST_F(UpdateAttempterTest, BroadcastCompleteDownloadTest) {
// There is a special case to ensure that at 100% downloaded,
// |download_progress_| is updated and broadcastest.
uint64_t bytes_progressed = 0; // ignored
uint64_t bytes_received = 5 * 1024 * 1024; // ignored
uint64_t bytes_total = 5 * 1024 * 1024; // 300MB
attempter_.status_ = UpdateStatus::DOWNLOADING;
attempter_.new_payload_size_ = bytes_total;
EXPECT_EQ(0.0, attempter_.download_progress_);
NiceMock<MockServiceObserver> observer;
EXPECT_CALL(observer,
SendStatusUpdate(AllOf(
Field(&UpdateEngineStatus::progress, 1.0),
Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
attempter_.AddObserver(&observer);
attempter_.BytesReceived(bytes_progressed, bytes_received, bytes_total);
EXPECT_EQ(1.0, attempter_.download_progress_);
}
TEST_F(UpdateAttempterTest, ActionCompletedOmahaRequestTest) {
unique_ptr<MockHttpFetcher> fetcher(new MockHttpFetcher("", 0, nullptr));
fetcher->FailTransfer(500); // Sets the HTTP response code.
OmahaRequestAction action(nullptr, std::move(fetcher), false, "");
ObjectCollectorAction<OmahaResponse> collector_action;
BondActions(&action, &collector_action);
OmahaResponse response;
response.poll_interval = 234;
action.SetOutputObject(response);
attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
EXPECT_FALSE(prefs_->Exists(kPrefsDeltaUpdateFailures));
EXPECT_EQ(500, attempter_.http_response_code());
EXPECT_EQ(UpdateStatus::IDLE, attempter_.status());
EXPECT_EQ(234U, attempter_.server_dictated_poll_interval_);
ASSERT_TRUE(attempter_.error_event_.get() == nullptr);
}
TEST_F(UpdateAttempterTest, ActionCompletedSkipApplying) {
unique_ptr<MockHttpFetcher> fetcher(new MockHttpFetcher("", 0, nullptr));
OmahaRequestAction action(nullptr, std::move(fetcher), false, "");
ObjectCollectorAction<OmahaResponse> collector_action;
BondActions(&action, &collector_action);
{
OmahaResponse response{.update_exists = true, .version = "123.0.0"};
action.SetOutputObject(response);
attempter_.skip_applying_ = true;
attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
EXPECT_EQ("123.0.0", attempter_.new_version_);
}
{
OmahaResponse response{.update_exists = false, .version = "234.0.0"};
action.SetOutputObject(response);
attempter_.skip_applying_ = true;
attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
// Should still be the old version, since technically there is no update to
// apply.
EXPECT_EQ("123.0.0", attempter_.new_version_);
}
}
TEST_F(UpdateAttempterTest, ActionCompletedNewVersionSet) {
unique_ptr<MockHttpFetcher> fetcher(new MockHttpFetcher("", 0, nullptr));
OmahaResponseHandlerAction action;
action.install_plan_.version = "123.0.0";
attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
EXPECT_EQ("123.0.0", attempter_.new_version_);
}
TEST_F(UpdateAttempterTest, ConstructWithUpdatedMarkerTest) {
string boot_id;
EXPECT_TRUE(utils::GetBootId(&boot_id));
FakeSystemState::Get()->fake_prefs()->SetString(kPrefsUpdateCompletedOnBootId,
boot_id);
attempter_.Init();
EXPECT_EQ(UpdateStatus::UPDATED_NEED_REBOOT, attempter_.status());
}
TEST_F(UpdateAttempterTest, GetErrorCodeForActionTest) {
EXPECT_EQ(ErrorCode::kSuccess,
GetErrorCodeForAction(nullptr, ErrorCode::kSuccess));
OmahaRequestAction omaha_request_action(nullptr, nullptr, false, "");
EXPECT_EQ(ErrorCode::kOmahaRequestError,
GetErrorCodeForAction(&omaha_request_action, ErrorCode::kError));
OmahaResponseHandlerAction omaha_response_handler_action;
EXPECT_EQ(
ErrorCode::kOmahaResponseHandlerError,
GetErrorCodeForAction(&omaha_response_handler_action, ErrorCode::kError));
DynamicPartitionControlStub dynamic_control_stub;
FilesystemVerifierAction filesystem_verifier_action(&dynamic_control_stub);
EXPECT_EQ(
ErrorCode::kFilesystemVerifierError,
GetErrorCodeForAction(&filesystem_verifier_action, ErrorCode::kError));
PostinstallRunnerAction postinstall_runner_action(
FakeSystemState::Get()->fake_boot_control(),
FakeSystemState::Get()->fake_hardware());
EXPECT_EQ(
ErrorCode::kPostinstallRunnerError,
GetErrorCodeForAction(&postinstall_runner_action, ErrorCode::kError));
MockAction action_mock;
EXPECT_CALL(action_mock, Type()).WillOnce(Return("MockAction"));
EXPECT_EQ(ErrorCode::kError,
GetErrorCodeForAction(&action_mock, ErrorCode::kError));
}
TEST_F(UpdateAttempterTest, DisableDeltaUpdateIfNeededTest) {
attempter_.omaha_request_params_->set_delta_okay(true);
attempter_.DisableDeltaUpdateIfNeeded();
EXPECT_TRUE(attempter_.omaha_request_params_->delta_okay());
prefs_->SetInt64(kPrefsDeltaUpdateFailures,
UpdateAttempter::kMaxDeltaUpdateFailures - 1);
attempter_.DisableDeltaUpdateIfNeeded();
EXPECT_TRUE(attempter_.omaha_request_params_->delta_okay());
prefs_->SetInt64(kPrefsDeltaUpdateFailures,
UpdateAttempter::kMaxDeltaUpdateFailures);
attempter_.DisableDeltaUpdateIfNeeded();
EXPECT_FALSE(attempter_.omaha_request_params_->delta_okay());
attempter_.DisableDeltaUpdateIfNeeded();
EXPECT_FALSE(attempter_.omaha_request_params_->delta_okay());
}
TEST_F(UpdateAttempterTest, MarkDeltaUpdateFailureTest) {
attempter_.MarkDeltaUpdateFailure();
EXPECT_TRUE(prefs_->SetInt64(kPrefsDeltaUpdateFailures, -1));
attempter_.MarkDeltaUpdateFailure();
int64_t value = 0;
EXPECT_TRUE(prefs_->GetInt64(kPrefsDeltaUpdateFailures, &value));
EXPECT_EQ(value, 1);
attempter_.MarkDeltaUpdateFailure();
EXPECT_TRUE(prefs_->GetInt64(kPrefsDeltaUpdateFailures, &value));
EXPECT_EQ(value, 2);
EXPECT_TRUE(prefs_->SetInt64(kPrefsDeltaUpdateFailures,
UpdateAttempter::kMaxDeltaUpdateFailures));
attempter_.MarkDeltaUpdateFailure();
EXPECT_TRUE(prefs_->GetInt64(kPrefsDeltaUpdateFailures, &value));
EXPECT_EQ(value, UpdateAttempter::kMaxDeltaUpdateFailures + 1);
}
TEST_F(UpdateAttempterTest, ScheduleErrorEventActionNoEventTest) {
EXPECT_CALL(*processor_, EnqueueAction(_)).Times(0);
EXPECT_CALL(*processor_, StartProcessing()).Times(0);
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(), UpdateFailed(_))
.Times(0);
OmahaResponse response;
string url1 = "http://url1";
response.packages.push_back({.payload_urls = {url1, "https://url"}});
EXPECT_CALL(*(FakeSystemState::Get()->mock_payload_state()), GetCurrentUrl())
.WillRepeatedly(Return(url1));
FakeSystemState::Get()->mock_payload_state()->SetResponse(response);
attempter_.ScheduleErrorEventAction();
EXPECT_EQ(url1,
FakeSystemState::Get()->mock_payload_state()->GetCurrentUrl());
}
TEST_F(UpdateAttempterTest, ScheduleErrorEventActionTest) {
EXPECT_CALL(*processor_,
EnqueueAction(Pointee(Property(
&AbstractAction::Type, OmahaRequestAction::StaticType()))));
EXPECT_CALL(*processor_, StartProcessing());
ErrorCode err = ErrorCode::kError;
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(), UpdateFailed(err));
attempter_.error_event_.reset(new OmahaEvent(
OmahaEvent::kTypeUpdateComplete, OmahaEvent::kResultError, err));
attempter_.ScheduleErrorEventAction();
EXPECT_EQ(UpdateStatus::REPORTING_ERROR_EVENT, attempter_.status());
}
namespace {
// Actions that will be built as part of an update check.
vector<string> GetUpdateActionTypes() {
return {OmahaRequestAction::StaticType(),
OmahaResponseHandlerAction::StaticType(),
UpdateBootFlagsAction::StaticType(),
OmahaRequestAction::StaticType(),
DownloadActionChromeos::StaticType(),
OmahaRequestAction::StaticType(),
FilesystemVerifierAction::StaticType(),
PostinstallRunnerAction::StaticType(),
OmahaRequestAction::StaticType()};
}
// Actions that will be built as part of a user-initiated rollback.
vector<string> GetRollbackActionTypes() {
return {InstallPlanAction::StaticType(),
PostinstallRunnerAction::StaticType()};
}
const StagingSchedule kValidStagingSchedule = {
{4, 10}, {10, 40}, {19, 70}, {26, 100}};
} // namespace
void UpdateAttempterTest::UpdateTestStart() {
attempter_.set_http_response_code(200);
// Expect that the device policy is loaded by the |UpdateAttempter| at some
// point by calling |RefreshDevicePolicy()|.
auto device_policy = std::make_unique<policy::MockDevicePolicy>();
EXPECT_CALL(*device_policy, LoadPolicy(false))
.Times(testing::AtLeast(1))
.WillRepeatedly(Return(true));
attempter_.policy_provider_.reset(
new policy::PolicyProvider(std::move(device_policy)));
{
InSequence s;
for (const auto& update_action_type : GetUpdateActionTypes()) {
EXPECT_CALL(*processor_,
EnqueueAction(Pointee(
Property(&AbstractAction::Type, update_action_type))));
}
EXPECT_CALL(*processor_, StartProcessing());
}
attempter_.Update({});
loop_.PostTask(FROM_HERE,
base::BindOnce(&UpdateAttempterTest::UpdateTestVerify,
base::Unretained(this)));
}
void UpdateAttempterTest::UpdateTestVerify() {
EXPECT_EQ(0, attempter_.http_response_code());
EXPECT_EQ(&attempter_, processor_->delegate());
EXPECT_EQ(UpdateStatus::CHECKING_FOR_UPDATE, attempter_.status());
loop_.BreakLoop();
}
void UpdateAttempterTest::RollbackTestStart(bool enterprise_rollback,
bool valid_slot) {
// Create a device policy so that we can change settings.
auto device_policy = std::make_unique<policy::MockDevicePolicy>();
EXPECT_CALL(*device_policy, LoadPolicy(false)).WillRepeatedly(Return(true));
FakeSystemState::Get()->set_device_policy(device_policy.get());
if (enterprise_rollback) {
// We return an empty owner as this is an enterprise.
EXPECT_CALL(*device_policy, GetOwner(_))
.WillRepeatedly(DoAll(SetArgPointee<0>(string("")), Return(true)));
} else {
// We return a fake owner as this is an owned consumer device.
EXPECT_CALL(*device_policy, GetOwner(_))
.WillRepeatedly(DoAll(SetArgPointee<0>(string("fake.mail@fake.com")),
Return(true)));
}
attempter_.policy_provider_.reset(
new policy::PolicyProvider(std::move(device_policy)));
if (valid_slot) {
BootControlInterface::Slot rollback_slot = 1;
LOG(INFO) << "Test Mark Bootable: "
<< BootControlInterface::SlotName(rollback_slot);
FakeSystemState::Get()->fake_boot_control()->SetSlotBootable(rollback_slot,
true);
}
bool is_rollback_allowed = false;
// We only allow rollback on devices that are not enterprise enrolled and
// which have a valid slot to rollback to.
if (!enterprise_rollback && valid_slot) {
is_rollback_allowed = true;
}
if (is_rollback_allowed) {
InSequence s;
for (const auto& rollback_action_type : GetRollbackActionTypes()) {
EXPECT_CALL(*processor_,
EnqueueAction(Pointee(
Property(&AbstractAction::Type, rollback_action_type))));
}
EXPECT_CALL(*processor_, StartProcessing());
EXPECT_TRUE(attempter_.Rollback(true));
loop_.PostTask(FROM_HERE,
base::BindOnce(&UpdateAttempterTest::RollbackTestVerify,
base::Unretained(this)));
} else {
EXPECT_FALSE(attempter_.Rollback(true));
loop_.BreakLoop();
}
}
void UpdateAttempterTest::RollbackTestVerify() {
// Verifies the actions that were enqueued.
EXPECT_EQ(&attempter_, processor_->delegate());
EXPECT_EQ(UpdateStatus::ATTEMPTING_ROLLBACK, attempter_.status());
EXPECT_EQ(0U, attempter_.install_plan_->partitions.size());
EXPECT_EQ(attempter_.install_plan_->powerwash_required, true);
loop_.BreakLoop();
}
TEST_F(UpdateAttempterTest, UpdateTest) {
UpdateTestStart();
loop_.Run();
}
TEST_F(UpdateAttempterTest, RollbackTest) {
loop_.PostTask(FROM_HERE,
base::BindOnce(&UpdateAttempterTest::RollbackTestStart,
base::Unretained(this),
false,
true));
loop_.Run();
}
TEST_F(UpdateAttempterTest, InvalidSlotRollbackTest) {
loop_.PostTask(FROM_HERE,
base::BindOnce(&UpdateAttempterTest::RollbackTestStart,
base::Unretained(this),
false,
false));
loop_.Run();
}
TEST_F(UpdateAttempterTest, EnterpriseRollbackTest) {
loop_.PostTask(FROM_HERE,
base::BindOnce(&UpdateAttempterTest::RollbackTestStart,
base::Unretained(this),
true,
true));
loop_.Run();
}
void UpdateAttempterTest::PingOmahaTestStart() {
EXPECT_CALL(*processor_,
EnqueueAction(Pointee(Property(
&AbstractAction::Type, OmahaRequestAction::StaticType()))));
EXPECT_CALL(*processor_, StartProcessing());
attempter_.PingOmaha();
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, PingOmahaTest) {
EXPECT_FALSE(attempter_.waiting_for_scheduled_check_);
EXPECT_FALSE(attempter_.WasScheduleUpdatesCalled());
// Disable scheduling of subsequnet checks; we're using the |DefaultPolicy| in
// testing, which is more permissive than we want to handle here.
attempter_.DisableScheduleUpdates();
loop_.PostTask(FROM_HERE,
base::BindOnce(&UpdateAttempterTest::PingOmahaTestStart,
base::Unretained(this)));
brillo::MessageLoopRunMaxIterations(&loop_, 100);
EXPECT_EQ(UpdateStatus::UPDATED_NEED_REBOOT, attempter_.status());
EXPECT_TRUE(attempter_.WasScheduleUpdatesCalled());
}
TEST_F(UpdateAttempterTest, CreatePendingErrorEventTest) {
MockAction action;
const ErrorCode kCode = ErrorCode::kDownloadTransferError;
attempter_.CreatePendingErrorEvent(&action, kCode);
ASSERT_NE(nullptr, attempter_.error_event_.get());
EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
EXPECT_EQ(OmahaEvent::kResultError, attempter_.error_event_->result);
EXPECT_EQ(
static_cast<ErrorCode>(static_cast<int>(kCode) |
static_cast<int>(ErrorCode::kTestOmahaUrlFlag)),
attempter_.error_event_->error_code);
}
TEST_F(UpdateAttempterTest, CreatePendingErrorEventResumedTest) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->is_resume = true;
MockAction action;
const ErrorCode kCode = ErrorCode::kInstallDeviceOpenError;
attempter_.CreatePendingErrorEvent(&action, kCode);
ASSERT_NE(nullptr, attempter_.error_event_.get());
EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
EXPECT_EQ(OmahaEvent::kResultError, attempter_.error_event_->result);
EXPECT_EQ(
static_cast<ErrorCode>(static_cast<int>(kCode) |
static_cast<int>(ErrorCode::kResumedFlag) |
static_cast<int>(ErrorCode::kTestOmahaUrlFlag)),
attempter_.error_event_->error_code);
}
TEST_F(UpdateAttempterTest, P2PNotStartedAtStartupWhenNotEnabled) {
MockP2PManager mock_p2p_manager;
FakeSystemState::Get()->set_p2p_manager(&mock_p2p_manager);
mock_p2p_manager.fake().SetP2PEnabled(false);
EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning()).Times(0);
attempter_.UpdateEngineStarted();
}
TEST_F(UpdateAttempterTest, P2PNotStartedAtStartupWhenEnabledButNotSharing) {
MockP2PManager mock_p2p_manager;
FakeSystemState::Get()->set_p2p_manager(&mock_p2p_manager);
mock_p2p_manager.fake().SetP2PEnabled(true);
EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning()).Times(0);
attempter_.UpdateEngineStarted();
}
TEST_F(UpdateAttempterTest, P2PStartedAtStartupWhenEnabledAndSharing) {
MockP2PManager mock_p2p_manager;
FakeSystemState::Get()->set_p2p_manager(&mock_p2p_manager);
mock_p2p_manager.fake().SetP2PEnabled(true);
mock_p2p_manager.fake().SetCountSharedFilesResult(1);
EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning());
attempter_.UpdateEngineStarted();
}
TEST_F(UpdateAttempterTest, P2PNotEnabled) {
loop_.PostTask(FROM_HERE,
base::BindOnce(&UpdateAttempterTest::P2PNotEnabledStart,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::P2PNotEnabledStart() {
// If P2P is not enabled, check that we do not attempt housekeeping
// and do not convey that P2P is to be used.
MockP2PManager mock_p2p_manager;
FakeSystemState::Get()->set_p2p_manager(&mock_p2p_manager);
mock_p2p_manager.fake().SetP2PEnabled(false);
EXPECT_CALL(mock_p2p_manager, PerformHousekeeping()).Times(0);
attempter_.Update({});
EXPECT_FALSE(actual_using_p2p_for_downloading_);
EXPECT_FALSE(actual_using_p2p_for_sharing());
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, P2PEnabledStartingFails) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::P2PEnabledStartingFailsStart,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::P2PEnabledStartingFailsStart() {
// If P2P is enabled, but starting it fails ensure we don't do
// any housekeeping and do not convey that P2P should be used.
MockP2PManager mock_p2p_manager;
FakeSystemState::Get()->set_p2p_manager(&mock_p2p_manager);
mock_p2p_manager.fake().SetP2PEnabled(true);
mock_p2p_manager.fake().SetEnsureP2PRunningResult(false);
mock_p2p_manager.fake().SetPerformHousekeepingResult(false);
EXPECT_CALL(mock_p2p_manager, PerformHousekeeping()).Times(0);
attempter_.Update({});
EXPECT_FALSE(actual_using_p2p_for_downloading());
EXPECT_FALSE(actual_using_p2p_for_sharing());
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, P2PEnabledHousekeepingFails) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::P2PEnabledHousekeepingFailsStart,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::P2PEnabledHousekeepingFailsStart() {
// If P2P is enabled, starting it works but housekeeping fails, ensure
// we do not convey P2P is to be used.
MockP2PManager mock_p2p_manager;
FakeSystemState::Get()->set_p2p_manager(&mock_p2p_manager);
mock_p2p_manager.fake().SetP2PEnabled(true);
mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
mock_p2p_manager.fake().SetPerformHousekeepingResult(false);
EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
attempter_.Update({});
EXPECT_FALSE(actual_using_p2p_for_downloading());
EXPECT_FALSE(actual_using_p2p_for_sharing());
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, P2PEnabled) {
loop_.PostTask(FROM_HERE,
base::BindOnce(&UpdateAttempterTest::P2PEnabledStart,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::P2PEnabledStart() {
MockP2PManager mock_p2p_manager;
FakeSystemState::Get()->set_p2p_manager(&mock_p2p_manager);
// If P2P is enabled and starting it works, check that we performed
// housekeeping and that we convey P2P should be used.
mock_p2p_manager.fake().SetP2PEnabled(true);
mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
mock_p2p_manager.fake().SetPerformHousekeepingResult(true);
EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
attempter_.Update({});
EXPECT_TRUE(actual_using_p2p_for_downloading());
EXPECT_TRUE(actual_using_p2p_for_sharing());
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, P2PEnabledInteractive) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::P2PEnabledInteractiveStart,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::P2PEnabledInteractiveStart() {
MockP2PManager mock_p2p_manager;
FakeSystemState::Get()->set_p2p_manager(&mock_p2p_manager);
// For an interactive check, if P2P is enabled and starting it
// works, check that we performed housekeeping and that we convey
// P2P should be used for sharing but NOT for downloading.
mock_p2p_manager.fake().SetP2PEnabled(true);
mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
mock_p2p_manager.fake().SetPerformHousekeepingResult(true);
EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
attempter_.Update({.interactive = true});
EXPECT_FALSE(actual_using_p2p_for_downloading());
EXPECT_TRUE(actual_using_p2p_for_sharing());
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, ReadScatterFactorFromPolicy) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::ReadScatterFactorFromPolicyTestStart,
base::Unretained(this)));
loop_.Run();
}
// Tests that the scatter_factor_in_seconds value is properly fetched
// from the device policy.
void UpdateAttempterTest::ReadScatterFactorFromPolicyTestStart() {
int64_t scatter_factor_in_seconds = 36000;
auto device_policy = std::make_unique<policy::MockDevicePolicy>();
EXPECT_CALL(*device_policy, LoadPolicy(false)).WillRepeatedly(Return(true));
FakeSystemState::Get()->set_device_policy(device_policy.get());
EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
.WillRepeatedly(
DoAll(SetArgPointee<0>(scatter_factor_in_seconds), Return(true)));
attempter_.policy_provider_.reset(
new policy::PolicyProvider(std::move(device_policy)));
attempter_.Update({});
EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, DecrementUpdateCheckCountTest) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::DecrementUpdateCheckCountTestStart,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::DecrementUpdateCheckCountTestStart() {
// Tests that the scatter_factor_in_seconds value is properly fetched
// from the device policy and is decremented if value > 0.
int64_t initial_value = 5;
auto* fake_prefs = FakeSystemState::Get()->fake_prefs();
FakeSystemState::Get()->fake_hardware()->SetIsOOBEComplete(Time::UnixEpoch());
EXPECT_TRUE(fake_prefs->SetInt64(kPrefsUpdateCheckCount, initial_value));
int64_t scatter_factor_in_seconds = 10;
auto device_policy = std::make_unique<policy::MockDevicePolicy>();
EXPECT_CALL(*device_policy, LoadPolicy(false)).WillRepeatedly(Return(true));
FakeSystemState::Get()->set_device_policy(device_policy.get());
EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
.WillRepeatedly(
DoAll(SetArgPointee<0>(scatter_factor_in_seconds), Return(true)));
attempter_.policy_provider_.reset(
new policy::PolicyProvider(std::move(device_policy)));
attempter_.Update({});
EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
// Make sure the file still exists.
EXPECT_TRUE(fake_prefs->Exists(kPrefsUpdateCheckCount));
int64_t new_value;
EXPECT_TRUE(fake_prefs->GetInt64(kPrefsUpdateCheckCount, &new_value));
EXPECT_EQ(initial_value - 1, new_value);
EXPECT_TRUE(
attempter_.omaha_request_params_->update_check_count_wait_enabled());
// However, if the count is already 0, it's not decremented. Test that.
initial_value = 0;
EXPECT_TRUE(fake_prefs->SetInt64(kPrefsUpdateCheckCount, initial_value));
attempter_.Update({});
EXPECT_TRUE(fake_prefs->Exists(kPrefsUpdateCheckCount));
EXPECT_TRUE(fake_prefs->GetInt64(kPrefsUpdateCheckCount, &new_value));
EXPECT_EQ(initial_value, new_value);
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, NoScatteringDoneDuringManualUpdateTestStart) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(
&UpdateAttempterTest::NoScatteringDoneDuringManualUpdateTestStart,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::NoScatteringDoneDuringManualUpdateTestStart() {
// Tests that no scattering logic is enabled if the update check
// is manually done (as opposed to a scheduled update check)
int64_t initial_value = 8;
auto* fake_prefs = FakeSystemState::Get()->fake_prefs();
FakeSystemState::Get()->fake_hardware()->SetIsOOBEComplete(Time::UnixEpoch());
EXPECT_TRUE(
fake_prefs->SetInt64(kPrefsWallClockScatteringWaitPeriod, initial_value));
EXPECT_TRUE(fake_prefs->SetInt64(kPrefsUpdateCheckCount, initial_value));
// make sure scatter_factor is non-zero as scattering is disabled
// otherwise.
int64_t scatter_factor_in_seconds = 50;
auto device_policy = std::make_unique<policy::MockDevicePolicy>();
EXPECT_CALL(*device_policy, LoadPolicy(false)).WillRepeatedly(Return(true));
FakeSystemState::Get()->set_device_policy(device_policy.get());
EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
.WillRepeatedly(
DoAll(SetArgPointee<0>(scatter_factor_in_seconds), Return(true)));
attempter_.policy_provider_.reset(
new policy::PolicyProvider(std::move(device_policy)));
// Trigger an interactive check so we can test that scattering is disabled.
attempter_.Update({.interactive = true});
EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
// Make sure scattering is disabled for manual (i.e. user initiated) update
// checks and all artifacts are removed.
EXPECT_FALSE(
attempter_.omaha_request_params_->wall_clock_based_wait_enabled());
EXPECT_FALSE(fake_prefs->Exists(kPrefsWallClockScatteringWaitPeriod));
EXPECT_EQ(0, attempter_.omaha_request_params_->waiting_period().InSeconds());
EXPECT_FALSE(
attempter_.omaha_request_params_->update_check_count_wait_enabled());
EXPECT_FALSE(fake_prefs->Exists(kPrefsUpdateCheckCount));
ScheduleQuitMainLoop();
}
void UpdateAttempterTest::SetUpStagingTest(const StagingSchedule& schedule) {
int64_t initial_value = 8;
EXPECT_TRUE(
prefs_->SetInt64(kPrefsWallClockScatteringWaitPeriod, initial_value));
EXPECT_TRUE(prefs_->SetInt64(kPrefsUpdateCheckCount, initial_value));
attempter_.scatter_factor_ = base::Seconds(20);
auto device_policy = std::make_unique<policy::MockDevicePolicy>();
EXPECT_CALL(*device_policy, LoadPolicy(false)).WillRepeatedly(Return(true));
FakeSystemState::Get()->set_device_policy(device_policy.get());
EXPECT_CALL(*device_policy, GetDeviceUpdateStagingSchedule(_))
.WillRepeatedly(DoAll(SetArgPointee<0>(schedule), Return(true)));
attempter_.policy_provider_.reset(
new policy::PolicyProvider(std::move(device_policy)));
}
TEST_F(UpdateAttempterTest, StagingSetsPrefsAndTurnsOffScattering) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(
&UpdateAttempterTest::StagingSetsPrefsAndTurnsOffScatteringStart,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::StagingSetsPrefsAndTurnsOffScatteringStart() {
// Tests that staging sets its prefs properly and turns off scattering.
FakeSystemState::Get()->fake_hardware()->SetIsOOBEComplete(Time::UnixEpoch());
SetUpStagingTest(kValidStagingSchedule);
attempter_.Update({});
auto* fake_prefs = FakeSystemState::Get()->fake_prefs();
// Check that prefs have the correct values.
int64_t update_count;
EXPECT_TRUE(fake_prefs->GetInt64(kPrefsUpdateCheckCount, &update_count));
int64_t waiting_time_days;
EXPECT_TRUE(fake_prefs->GetInt64(kPrefsWallClockStagingWaitPeriod,
&waiting_time_days));
EXPECT_GT(waiting_time_days, 0);
// Update count should have been decremented.
EXPECT_EQ(7, update_count);
// Check that Omaha parameters were updated correctly.
EXPECT_TRUE(
attempter_.omaha_request_params_->update_check_count_wait_enabled());
EXPECT_TRUE(
attempter_.omaha_request_params_->wall_clock_based_wait_enabled());
EXPECT_EQ(waiting_time_days,
attempter_.omaha_request_params_->waiting_period().InDays());
// Check class variables.
EXPECT_EQ(waiting_time_days, attempter_.staging_wait_time_.InDays());
EXPECT_EQ(kValidStagingSchedule, attempter_.staging_schedule_);
// Check that scattering is turned off
EXPECT_EQ(0, attempter_.scatter_factor_.InSeconds());
EXPECT_FALSE(fake_prefs->Exists(kPrefsWallClockScatteringWaitPeriod));
ScheduleQuitMainLoop();
}
void UpdateAttempterTest::CheckStagingOff() {
// Check that all prefs were removed.
EXPECT_FALSE(prefs_->Exists(kPrefsUpdateCheckCount));
EXPECT_FALSE(prefs_->Exists(kPrefsWallClockScatteringWaitPeriod));
EXPECT_FALSE(prefs_->Exists(kPrefsWallClockStagingWaitPeriod));
// Check that the Omaha parameters have the correct value.
EXPECT_EQ(0, attempter_.omaha_request_params_->waiting_period().InDays());
EXPECT_EQ(attempter_.omaha_request_params_->waiting_period(),
attempter_.staging_wait_time_);
EXPECT_FALSE(
attempter_.omaha_request_params_->update_check_count_wait_enabled());
EXPECT_FALSE(
attempter_.omaha_request_params_->wall_clock_based_wait_enabled());
// Check that scattering is turned off too.
EXPECT_EQ(0, attempter_.scatter_factor_.InSeconds());
}
TEST_F(UpdateAttempterTest, StagingOffIfInteractive) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::StagingOffIfInteractiveStart,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::StagingOffIfInteractiveStart() {
// Tests that staging is turned off when an interactive update is requested.
FakeSystemState::Get()->fake_hardware()->SetIsOOBEComplete(Time::UnixEpoch());
SetUpStagingTest(kValidStagingSchedule);
attempter_.Update({.interactive = true});
CheckStagingOff();
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, StagingOffIfOobe) {
loop_.PostTask(FROM_HERE,
base::BindOnce(&UpdateAttempterTest::StagingOffIfOobeStart,
base::Unretained(this)));
loop_.Run();
}
void UpdateAttempterTest::StagingOffIfOobeStart() {
// Tests that staging is turned off if OOBE hasn't been completed.
FakeSystemState::Get()->fake_hardware()->SetIsOOBEEnabled(true);
FakeSystemState::Get()->fake_hardware()->UnsetIsOOBEComplete();
SetUpStagingTest(kValidStagingSchedule);
attempter_.Update({.interactive = true});
CheckStagingOff();
ScheduleQuitMainLoop();
}
// Checks that we only report daily metrics at most every 24 hours.
TEST_F(UpdateAttempterTest, ReportDailyMetrics) {
auto* fake_clock = FakeSystemState::Get()->fake_clock();
Time epoch = Time::FromInternalValue(0);
fake_clock->SetWallclockTime(epoch);
// If there is no kPrefsDailyMetricsLastReportedAt state variable,
// we should report.
EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
// We should not report again if no time has passed.
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
// We should not report if only 10 hours has passed.
fake_clock->SetWallclockTime(epoch + base::Hours(10));
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
// We should not report if only 24 hours - 1 sec has passed.
fake_clock->SetWallclockTime(epoch + base::Hours(24) - base::Seconds(1));
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
// We should report if 24 hours has passed.
fake_clock->SetWallclockTime(epoch + base::Hours(24));
EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
// But then we should not report again..
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
// .. until another 24 hours has passed
fake_clock->SetWallclockTime(epoch + base::Hours(47));
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
fake_clock->SetWallclockTime(epoch + base::Hours(48));
EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
// .. and another 24 hours
fake_clock->SetWallclockTime(epoch + base::Hours(71));
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
fake_clock->SetWallclockTime(epoch + base::Hours(72));
EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
// If the span between time of reporting and present time is
// negative, we report. This is in order to reset the timestamp and
// avoid an edge condition whereby a distant point in the future is
// in the state variable resulting in us never ever reporting again.
fake_clock->SetWallclockTime(epoch + base::Hours(71));
EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
// In this case we should not update until the clock reads 71 + 24 = 95.
// Check that.
fake_clock->SetWallclockTime(epoch + base::Hours(94));
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
fake_clock->SetWallclockTime(epoch + base::Hours(95));
EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
}
TEST_F(UpdateAttempterTest, BootTimeInUpdateMarkerFile) {
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.Init();
Time boot_time;
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(&boot_time));
attempter_.WriteUpdateCompletedMarker();
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(&boot_time));
EXPECT_EQ(boot_time.ToTimeT(), 42);
}
TEST_F(UpdateAttempterTest, AnyUpdateSourceAllowedUnofficial) {
FakeSystemState::Get()->fake_hardware()->SetIsOfficialBuild(false);
EXPECT_TRUE(attempter_.IsAnyUpdateSourceAllowed());
}
TEST_F(UpdateAttempterTest, AnyUpdateSourceAllowedOfficialDevmode) {
FakeSystemState::Get()->fake_hardware()->SetIsOfficialBuild(true);
FakeSystemState::Get()->fake_hardware()->SetAreDevFeaturesEnabled(true);
EXPECT_TRUE(attempter_.IsAnyUpdateSourceAllowed());
}
TEST_F(UpdateAttempterTest, AnyUpdateSourceDisallowedOfficialNormal) {
FakeSystemState::Get()->fake_hardware()->SetIsOfficialBuild(true);
FakeSystemState::Get()->fake_hardware()->SetAreDevFeaturesEnabled(false);
EXPECT_FALSE(attempter_.IsAnyUpdateSourceAllowed());
}
// TODO(kimjae): Follow testing pattern with params for |CheckForInstall()|.
// When adding, remove older tests related to |CheckForInstall()|.
TEST_F(UpdateAttempterTest, CheckForInstallNotIdleFails) {
for (const auto status : kNonIdleOrRebootUpdateStatuses) {
// GIVEN a non-idle status.
attempter_.status_ = status;
EXPECT_FALSE(attempter_.CheckForInstall({}, ""));
}
// Installing not allowed when waiting for reboot.
attempter_.status_ = UpdateStatus::UPDATED_NEED_REBOOT;
EXPECT_FALSE(attempter_.CheckForInstall({}, ""));
}
TEST_F(UpdateAttempterTest, CheckForUpdateNotIdleFails) {
for (const auto status : kNonIdleOrRebootUpdateStatuses) {
// GIVEN a non-idle status.
cfu_params_.status = status;
// THEN |ScheduleUpdates()| should not be called.
cfu_params_.should_schedule_updates_be_called = false;
// THEN result should indicate failure.
cfu_params_.expected_result = false;
TestCheckForUpdate();
}
}
TEST_F(UpdateAttempterTest, CheckForUpdateOfficalBuildClearsSource) {
// GIVEN a official build.
// THEN we expect forced app version + forced omaha url to be cleared.
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForUpdateSkipApplying) {
// GIVEN a official build.
// THEN we expect forced app version + forced omaha url to be cleared.
cfu_params_.skip_applying = true;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForUpdateUnofficialBuildChangesSource) {
// GIVEN a nonofficial build with dev features enabled.
cfu_params_.is_official_build = false;
cfu_params_.are_dev_features_enabled = true;
// THEN the forced app version + forced omaha url changes based on input.
cfu_params_.expected_forced_app_version = cfu_params_.app_version;
cfu_params_.expected_forced_omaha_url = cfu_params_.omaha_url;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForUpdateOfficialBuildScheduledAUTest) {
// GIVEN a scheduled autest omaha url.
cfu_params_.omaha_url = "autest-scheduled";
// THEN forced app version is cleared.
// THEN forced omaha url changes to default constant.
cfu_params_.expected_forced_omaha_url = constants::kOmahaDefaultAUTestURL;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForUpdateUnofficialBuildScheduledAUTest) {
// GIVEN a scheduled autest omaha url.
cfu_params_.omaha_url = "autest-scheduled";
// GIVEN a nonofficial build with dev features enabled.
cfu_params_.is_official_build = false;
cfu_params_.are_dev_features_enabled = true;
// THEN forced app version changes based on input.
cfu_params_.expected_forced_app_version = cfu_params_.app_version;
// THEN forced omaha url changes to default constant.
cfu_params_.expected_forced_omaha_url = constants::kOmahaDefaultAUTestURL;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForUpdateOfficialBuildAUTest) {
// GIVEN a autest omaha url.
cfu_params_.omaha_url = "autest";
// THEN forced app version is cleared.
// THEN forced omaha url changes to default constant.
cfu_params_.expected_forced_omaha_url = constants::kOmahaDefaultAUTestURL;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForUpdateUnofficialBuildAUTest) {
// GIVEN a autest omha url.
cfu_params_.omaha_url = "autest";
// GIVEN a nonofficial build with dev features enabled.
cfu_params_.is_official_build = false;
cfu_params_.are_dev_features_enabled = true;
// THEN forced app version changes based on input.
cfu_params_.expected_forced_app_version = cfu_params_.app_version;
// THEN forced omaha url changes to default constant.
cfu_params_.expected_forced_omaha_url = constants::kOmahaDefaultAUTestURL;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest,
CheckForUpdateNonInteractiveOfficialBuildScheduledAUTest) {
// GIVEN a scheduled autest omaha url.
cfu_params_.omaha_url = "autest-scheduled";
// GIVEN a noninteractive update.
cfu_params_.non_interactive = true;
// THEN forced app version is cleared.
// THEN forced omaha url changes to default constant.
cfu_params_.expected_forced_omaha_url = constants::kOmahaDefaultAUTestURL;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest,
CheckForUpdateNonInteractiveUnofficialBuildScheduledAUTest) {
// GIVEN a scheduled autest omaha url.
cfu_params_.omaha_url = "autest-scheduled";
// GIVEN a noninteractive update.
cfu_params_.non_interactive = true;
// GIVEN a nonofficial build with dev features enabled.
cfu_params_.is_official_build = false;
cfu_params_.are_dev_features_enabled = true;
// THEN forced app version changes based on input.
cfu_params_.expected_forced_app_version = cfu_params_.app_version;
// THEN forced omaha url changes to default constant.
cfu_params_.expected_forced_omaha_url = constants::kOmahaDefaultAUTestURL;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForUpdateNonInteractiveOfficialBuildAUTest) {
// GIVEN a autest omaha url.
cfu_params_.omaha_url = "autest";
// GIVEN a noninteractive update.
cfu_params_.non_interactive = true;
// THEN forced app version is cleared.
// THEN forced omaha url changes to default constant.
cfu_params_.expected_forced_omaha_url = constants::kOmahaDefaultAUTestURL;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForUpdateNonInteractiveUnofficialBuildAUTest) {
// GIVEN a autest omaha url.
cfu_params_.omaha_url = "autest";
// GIVEN a noninteractive update.
cfu_params_.non_interactive = true;
// GIVEN a nonofficial build with dev features enabled.
cfu_params_.is_official_build = false;
cfu_params_.are_dev_features_enabled = true;
// THEN forced app version changes based on input.
cfu_params_.expected_forced_app_version = cfu_params_.app_version;
// THEN forced omaha url changes to default constant.
cfu_params_.expected_forced_omaha_url = constants::kOmahaDefaultAUTestURL;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForUpdateMissingForcedCallback1) {
// GIVEN a official build.
// GIVEN forced callback is not set.
attempter_.set_forced_update_pending_callback(nullptr);
// THEN we except forced app version + forced omaha url to be cleared.
// THEN |ScheduleUpdates()| should not be called.
cfu_params_.should_schedule_updates_be_called = false;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForUpdateMissingForcedCallback2) {
// GIVEN a nonofficial build with dev features enabled.
cfu_params_.is_official_build = false;
cfu_params_.are_dev_features_enabled = true;
// GIVEN forced callback is not set.
attempter_.set_forced_update_pending_callback(nullptr);
// THEN the forced app version + forced omaha url changes based on input.
cfu_params_.expected_forced_app_version = cfu_params_.app_version;
cfu_params_.expected_forced_omaha_url = cfu_params_.omaha_url;
// THEN |ScheduleUpdates()| should not be called.
cfu_params_.should_schedule_updates_be_called = false;
TestCheckForUpdate();
}
TEST_F(UpdateAttempterTest, CheckForInstallTest) {
FakeSystemState::Get()->fake_hardware()->SetIsOfficialBuild(true);
FakeSystemState::Get()->fake_hardware()->SetAreDevFeaturesEnabled(false);
attempter_.CheckForInstall({}, "autest");
EXPECT_EQ(constants::kOmahaDefaultAUTestURL, attempter_.forced_omaha_url());
attempter_.CheckForInstall({}, "autest-scheduled");
EXPECT_EQ(constants::kOmahaDefaultAUTestURL, attempter_.forced_omaha_url());
attempter_.CheckForInstall({}, "http://omaha.phishing");
EXPECT_EQ("", attempter_.forced_omaha_url());
}
TEST_F(UpdateAttempterTest, CheckForInstallScaledTest) {
FakeSystemState::Get()->fake_hardware()->SetIsOfficialBuild(true);
FakeSystemState::Get()->fake_hardware()->SetAreDevFeaturesEnabled(false);
EXPECT_FALSE(attempter_.CheckForInstall({}, "autest", /*scaled=*/true));
EXPECT_TRUE(attempter_.CheckForInstall({"dlc_a"}, "autest", /*scaled=*/true));
EXPECT_EQ(constants::kOmahaDefaultAUTestURL, attempter_.forced_omaha_url());
EXPECT_FALSE(attempter_.CheckForInstall(
{"dlc_a", "dlc_b"}, "autest", /*scaled=*/true));
}
TEST_F(UpdateAttempterTest, InstallSetsStatusIdle) {
attempter_.CheckForInstall({}, "http://foo.bar");
attempter_.status_ = UpdateStatus::DOWNLOADING;
EXPECT_FALSE(attempter_.IsUpdating());
attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
UpdateEngineStatus status;
attempter_.GetStatus(&status);
// Should set status to idle after an install operation.
EXPECT_EQ(UpdateStatus::IDLE, status.status);
}
TEST_F(UpdateAttempterTest, RollbackAfterInstall) {
attempter_.pm_ = ProcessMode::INSTALL;
attempter_.Rollback(false);
EXPECT_TRUE(attempter_.IsUpdating());
}
TEST_F(UpdateAttempterTest, RollbackAfterScaledInstall) {
attempter_.pm_ = ProcessMode::SCALED_INSTALL;
attempter_.Rollback(false);
EXPECT_TRUE(attempter_.IsUpdating());
}
TEST_F(UpdateAttempterTest, UpdateAfterInstall) {
attempter_.pm_ = ProcessMode::INSTALL;
attempter_.CheckForUpdate({});
EXPECT_TRUE(attempter_.IsUpdating());
}
TEST_F(UpdateAttempterTest, UpdateAfterScaledInstall) {
attempter_.pm_ = ProcessMode::SCALED_INSTALL;
attempter_.CheckForUpdate({});
EXPECT_TRUE(attempter_.IsUpdating());
}
TEST_F(UpdateAttempterTest, TargetVersionPrefixSetAndReset) {
UpdateCheckParams params;
attempter_.CalculateUpdateParams({.target_version_prefix = "1234"});
EXPECT_EQ("1234",
FakeSystemState::Get()->request_params()->target_version_prefix());
attempter_.CalculateUpdateParams({});
EXPECT_TRUE(FakeSystemState::Get()
->request_params()
->target_version_prefix()
.empty());
}
TEST_F(UpdateAttempterTest, ChannelDowngradeNoRollback) {
base::ScopedTempDir tempdir;
ASSERT_TRUE(tempdir.CreateUniqueTempDir());
FakeSystemState::Get()->request_params()->set_root(tempdir.GetPath().value());
attempter_.CalculateUpdateParams({
.target_channel = kStableChannel,
});
EXPECT_FALSE(
FakeSystemState::Get()->request_params()->is_powerwash_allowed());
}
TEST_F(UpdateAttempterTest, ChannelDowngradeRollback) {
base::ScopedTempDir tempdir;
ASSERT_TRUE(tempdir.CreateUniqueTempDir());
FakeSystemState::Get()->request_params()->set_root(tempdir.GetPath().value());
attempter_.CalculateUpdateParams({
.rollback_on_channel_downgrade = true,
.target_channel = kStableChannel,
});
EXPECT_TRUE(FakeSystemState::Get()->request_params()->is_powerwash_allowed());
}
TEST_F(UpdateAttempterTest, UpdateDeferredByPolicyTest) {
// Construct an OmahaResponseHandlerAction that has processed an InstallPlan,
// but the update is being deferred by the Policy.
OmahaResponseHandlerAction response_action;
response_action.install_plan_.version = "a.b.c.d";
response_action.install_plan_.payloads.push_back(
{.size = 1234ULL, .type = InstallPayloadType::kFull});
// Inform the UpdateAttempter that the OmahaResponseHandlerAction has
// completed, with the deferred-update error code.
attempter_.ActionCompleted(
nullptr, &response_action, ErrorCode::kOmahaUpdateDeferredPerPolicy);
{
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_EQ(UpdateStatus::UPDATE_AVAILABLE, status.status);
EXPECT_TRUE(attempter_.install_plan_);
EXPECT_EQ(attempter_.install_plan_->version, status.new_version);
EXPECT_EQ(attempter_.install_plan_->payloads[0].size,
status.new_size_bytes);
}
// An "error" event should have been created to tell Omaha that the update is
// being deferred.
EXPECT_TRUE(nullptr != attempter_.error_event_);
EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
EXPECT_EQ(OmahaEvent::kResultUpdateDeferred, attempter_.error_event_->result);
ErrorCode expected_code = static_cast<ErrorCode>(
static_cast<int>(ErrorCode::kOmahaUpdateDeferredPerPolicy) |
static_cast<int>(ErrorCode::kTestOmahaUrlFlag));
EXPECT_EQ(expected_code, attempter_.error_event_->error_code);
// End the processing
attempter_.ProcessingDone(nullptr, ErrorCode::kOmahaUpdateDeferredPerPolicy);
// Validate the state of the attempter.
{
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_EQ(UpdateStatus::REPORTING_ERROR_EVENT, status.status);
EXPECT_EQ(response_action.install_plan_.version, status.new_version);
EXPECT_EQ(response_action.install_plan_.payloads[0].size,
status.new_size_bytes);
}
}
TEST_F(UpdateAttempterTest, UpdateIsNotRunningWhenUpdateAvailable) {
// Default construction for |waiting_for_scheduled_check_| is false.
EXPECT_FALSE(attempter_.IsBusyOrUpdateScheduled());
// Verify in-progress update with UPDATE_AVAILABLE is running
attempter_.status_ = UpdateStatus::UPDATE_AVAILABLE;
EXPECT_TRUE(attempter_.IsBusyOrUpdateScheduled());
}
// TODO(ahassani): Refactor these to not use the |policy_data_| of |attempter_|
// directly.
TEST_F(UpdateAttempterTest, UpdateFlagsCachedAtUpdateStart) {
UpdateFlags flags;
flags.set_non_interactive(true);
attempter_.SetUpdateFlags(flags);
attempter_.policy_data_.reset(
new UpdateCheckAllowedPolicyData({.updates_enabled = true}));
attempter_.OnUpdateScheduled(EvalStatus::kSucceeded);
EXPECT_TRUE(attempter_.GetCurrentUpdateFlags().non_interactive());
}
void UpdateAttempterTest::ResetRollbackHappenedStart(bool is_consumer,
bool is_policy_loaded,
bool expected_reset) {
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
GetRollbackHappened())
.WillRepeatedly(Return(true));
auto mock_policy_provider =
std::make_unique<NiceMock<policy::MockPolicyProvider>>();
EXPECT_CALL(*mock_policy_provider, IsConsumerDevice())
.WillRepeatedly(Return(is_consumer));
EXPECT_CALL(*mock_policy_provider, device_policy_is_loaded())
.WillRepeatedly(Return(is_policy_loaded));
const policy::MockDevicePolicy device_policy;
EXPECT_CALL(*mock_policy_provider, GetDevicePolicy())
.WillRepeatedly(ReturnRef(device_policy));
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
SetRollbackHappened(false))
.Times(expected_reset ? 1 : 0);
attempter_.policy_provider_ = std::move(mock_policy_provider);
attempter_.Update({});
ScheduleQuitMainLoop();
}
TEST_F(UpdateAttempterTest, ResetRollbackHappenedOobe) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::ResetRollbackHappenedStart,
base::Unretained(this),
/*is_consumer=*/false,
/*is_policy_loaded=*/false,
/*expected_reset=*/false));
loop_.Run();
}
TEST_F(UpdateAttempterTest, ResetRollbackHappenedConsumer) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::ResetRollbackHappenedStart,
base::Unretained(this),
/*is_consumer=*/true,
/*is_policy_loaded=*/false,
/*expected_reset=*/true));
loop_.Run();
}
TEST_F(UpdateAttempterTest, ResetRollbackHappenedEnterprise) {
loop_.PostTask(
FROM_HERE,
base::BindOnce(&UpdateAttempterTest::ResetRollbackHappenedStart,
base::Unretained(this),
/*is_consumer=*/false,
/*is_policy_loaded=*/true,
/*expected_reset=*/true));
loop_.Run();
}
TEST_F(UpdateAttempterTest, SetRollbackHappenedRollback) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->is_rollback = true;
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
SetRollbackHappened(true))
.Times(1);
attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
}
TEST_F(UpdateAttempterTest, SetRollbackHappenedNotRollback) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->is_rollback = false;
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
SetRollbackHappened(true))
.Times(0);
attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
}
TEST_F(UpdateAttempterTest, RollbackMetricsRollbackSuccess) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->is_rollback = true;
attempter_.install_plan_->version = kRollbackVersion;
EXPECT_CALL(*FakeSystemState::Get()->mock_metrics_reporter(),
ReportEnterpriseRollbackMetrics(
metrics::kMetricEnterpriseRollbackSuccess, kRollbackVersion))
.Times(1);
attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
}
TEST_F(UpdateAttempterTest, RollbackMetricsNotRollbackSuccess) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->is_rollback = false;
attempter_.install_plan_->version = kRollbackVersion;
EXPECT_CALL(*FakeSystemState::Get()->mock_metrics_reporter(),
ReportEnterpriseRollbackMetrics(_, _))
.Times(0);
attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
}
TEST_F(UpdateAttempterTest, RollbackMetricsRollbackFailure) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->is_rollback = true;
attempter_.install_plan_->version = kRollbackVersion;
EXPECT_CALL(*FakeSystemState::Get()->mock_metrics_reporter(),
ReportEnterpriseRollbackMetrics(
metrics::kMetricEnterpriseRollbackFailure, kRollbackVersion))
.Times(1);
MockAction action;
attempter_.CreatePendingErrorEvent(&action, ErrorCode::kRollbackNotPossible);
attempter_.ProcessingDone(nullptr, ErrorCode::kRollbackNotPossible);
}
TEST_F(UpdateAttempterTest, RollbackMetricsNotRollbackFailure) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->is_rollback = false;
attempter_.install_plan_->version = kRollbackVersion;
EXPECT_CALL(*FakeSystemState::Get()->mock_metrics_reporter(),
ReportEnterpriseRollbackMetrics(_, _))
.Times(0);
MockAction action;
attempter_.CreatePendingErrorEvent(&action, ErrorCode::kRollbackNotPossible);
attempter_.ProcessingDone(nullptr, ErrorCode::kRollbackNotPossible);
}
TEST_F(UpdateAttempterTest, ProcessingDoneUpdated) {
// GIVEN an update finished.
// THEN update_engine should call update completion.
pd_params_.should_update_completed_be_called = true;
// THEN need reboot since update applied.
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
// THEN install indication should be false.
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ProcessingDoneUpdatedDlcFilter) {
// GIVEN an update finished.
// GIVEN DLC |AppParams| list.
auto dlc_1 = "dlc_1", dlc_2 = "dlc_2";
pd_params_.dlc_apps_params = {{dlc_1, {.name = dlc_1, .updated = false}},
{dlc_2, {.name = dlc_2}}};
// THEN update_engine should call update completion.
pd_params_.should_update_completed_be_called = true;
pd_params_.args_to_update_completed = {dlc_2};
// THEN need reboot since update applied.
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
// THEN install indication should be false.
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ProcessingDoneSkipApplying) {
// GIVEN an update finished.
// GIVEN skip applying.
pd_params_.skip_applying = true;
// THEN update_engine should not call install completion.
// THEN go idle.
// THEN install indication should be false.
TestProcessingDone();
EXPECT_FALSE(attempter_.skip_applying_);
}
TEST_F(UpdateAttempterTest, ProcessingDoneInstalled) {
// GIVEN an install finished.
pd_params_.pm = ProcessMode::INSTALL;
// THEN update_engine should call install completion.
pd_params_.should_install_completed_be_called = true;
// THEN go idle.
// THEN install indication should be false.
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ProcessingDoneInstalledDlcFilter) {
// GIVEN an install finished.
pd_params_.pm = ProcessMode::INSTALL;
// GIVEN DLC |AppParams| list.
auto dlc_1 = "dlc_1", dlc_2 = "dlc_2";
pd_params_.dlc_apps_params = {{dlc_1, {.name = dlc_1, .updated = false}},
{dlc_2, {.name = dlc_2}}};
// THEN update_engine should call install completion.
pd_params_.should_install_completed_be_called = true;
pd_params_.args_to_install_completed = {dlc_2};
// THEN go idle.
// THEN install indication should be false.
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ProcessingDoneInstallReportingError) {
// GIVEN an install finished.
pd_params_.pm = ProcessMode::INSTALL;
// GIVEN a reporting error occurred.
pd_params_.status = UpdateStatus::REPORTING_ERROR_EVENT;
// THEN update_engine should not call install completion.
// THEN go idle.
// THEN install indication should be false.
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ProcessingDoneNoUpdate) {
// GIVEN an update finished.
// GIVEN an action error occured.
pd_params_.code = ErrorCode::kNoUpdate;
// THEN update_engine should not call update completion.
// THEN go idle.
// THEN install indication should be false.
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ProcessingDoneNoInstall) {
// GIVEN an install finished.
pd_params_.pm = ProcessMode::INSTALL;
// GIVEN an action error occured.
pd_params_.code = ErrorCode::kNoUpdate;
// THEN update_engine should not call install completion.
// THEN go idle.
// THEN install indication should be false.
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ProcessingDoneNoUpdateReboot) {
// GIVEN an update finished.
pd_params_.code = ErrorCode::kNoUpdate;
pd_params_.status = UpdateStatus::CHECKING_FOR_UPDATE;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
// Waiting to reboot.
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
// Since there is an update on the inactive slot with higher priority, set
// status to |UPDATED_NEED_REBOOT|.
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ProcessingDoneIdle) {
// GIVEN an update finished.
pd_params_.code = ErrorCode::kNoUpdate;
pd_params_.status = UpdateStatus::CHECKING_FOR_UPDATE;
pd_params_.expected_exit_status = UpdateStatus::IDLE;
// Since there is no bootable slot with higher priority, the status resets to
// |IDLE|.
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ProcessingDoneUpdateError) {
// GIVEN an update finished.
// GIVEN an action error occured.
pd_params_.code = ErrorCode::kError;
// GIVEN an event error is set.
attempter_.error_event_.reset(new OmahaEvent(OmahaEvent::kTypeUpdateComplete,
OmahaEvent::kResultError,
ErrorCode::kError));
// THEN indicate a error event.
pd_params_.expected_exit_status = UpdateStatus::REPORTING_ERROR_EVENT;
// THEN install indication should be false.
// THEN update_engine should not call update completion.
// THEN expect critical actions of |ScheduleErrorEventAction()|.
EXPECT_CALL(*processor_, EnqueueAction(Pointee(_))).Times(1);
EXPECT_CALL(*processor_, StartProcessing()).Times(1);
// THEN |ScheduleUpdates()| will be called next |ProcessingDone()| so skip.
pd_params_.should_schedule_updates_be_called = false;
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ProcessingDoneInstallError) {
// GIVEN an install finished.
pd_params_.pm = ProcessMode::INSTALL;
// GIVEN an action error occured.
pd_params_.code = ErrorCode::kError;
// GIVEN an event error is set.
attempter_.error_event_.reset(new OmahaEvent(OmahaEvent::kTypeUpdateComplete,
OmahaEvent::kResultError,
ErrorCode::kError));
// THEN indicate a error event.
pd_params_.expected_exit_status = UpdateStatus::REPORTING_ERROR_EVENT;
// THEN install indication should be false.
// THEN update_engine should not call install completion.
// THEN expect critical actions of |ScheduleErrorEventAction()|.
EXPECT_CALL(*processor_, EnqueueAction(Pointee(_))).Times(1);
EXPECT_CALL(*processor_, StartProcessing()).Times(1);
// THEN |ScheduleUpdates()| will be called next |ProcessingDone()| so skip.
pd_params_.should_schedule_updates_be_called = false;
TestProcessingDone();
}
TEST_F(UpdateAttempterTest, ScheduleUpdateSpamHandlerTest) {
EXPECT_TRUE(attempter_.ScheduleUpdates());
// Now there is an update scheduled which means that all subsequent
// |ScheduleUpdates()| should fail.
EXPECT_FALSE(attempter_.ScheduleUpdates());
EXPECT_FALSE(attempter_.ScheduleUpdates());
EXPECT_FALSE(attempter_.ScheduleUpdates());
}
// Critical tests to always make sure that an update is scheduled. The following
// unittest(s) try and cover the correctness in synergy between
// |UpdateAttempter| and |UpdateManager|. Also it is good to remember the
// actions that happen in the flow when |UpdateAttempter| get callbacked on
// |OnUpdateScheduled()| -> (various cases which leads to) -> |ProcessingDone()|
void UpdateAttempterTest::TestOnUpdateScheduled() {
// Setup
attempter_.SetWaitingForScheduledCheck(true);
attempter_.DisableUpdate();
attempter_.DisableScheduleUpdates();
// Invocation
attempter_.policy_data_.reset(
new UpdateCheckAllowedPolicyData(ous_params_.params));
attempter_.OnUpdateScheduled(ous_params_.status);
// Verify
EXPECT_EQ(ous_params_.exit_status, attempter_.status());
EXPECT_EQ(ous_params_.should_schedule_updates_be_called,
attempter_.WasScheduleUpdatesCalled());
EXPECT_EQ(ous_params_.should_update_be_called, attempter_.WasUpdateCalled());
}
TEST_F(UpdateAttempterTest, OnUpdatesScheduledFailed) {
// GIVEN failed status.
// THEN update should be scheduled.
ous_params_.should_schedule_updates_be_called = true;
TestOnUpdateScheduled();
}
TEST_F(UpdateAttempterTest, OnUpdatesScheduledAskMeAgainLater) {
// GIVEN ask me again later status.
ous_params_.status = EvalStatus::kAskMeAgainLater;
// THEN update should be scheduled.
ous_params_.should_schedule_updates_be_called = true;
TestOnUpdateScheduled();
}
TEST_F(UpdateAttempterTest, OnUpdatesScheduledContinue) {
// GIVEN continue status.
ous_params_.status = EvalStatus::kContinue;
// THEN update should be scheduled.
ous_params_.should_schedule_updates_be_called = true;
TestOnUpdateScheduled();
}
TEST_F(UpdateAttempterTest, OnUpdatesScheduledSucceededButUpdateDisabledFails) {
// GIVEN updates disabled.
ous_params_.params = {.updates_enabled = false};
// GIVEN succeeded status.
ous_params_.status = EvalStatus::kSucceeded;
// THEN update should not be scheduled.
TestOnUpdateScheduled();
}
TEST_F(UpdateAttempterTest, OnUpdatesScheduledSucceeded) {
// GIVEN updates enabled.
ous_params_.params = {.updates_enabled = true};
// GIVEN succeeded status.
ous_params_.status = EvalStatus::kSucceeded;
// THEN update should be called indicating status change.
ous_params_.exit_status = UpdateStatus::CHECKING_FOR_UPDATE;
ous_params_.should_update_be_called = true;
TestOnUpdateScheduled();
}
TEST_F(UpdateAttempterTest, IsEnterpriseRollbackInGetStatusDefault) {
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_FALSE(status.is_enterprise_rollback);
}
TEST_F(UpdateAttempterTest, IsEnterpriseRollbackInGetStatusFalse) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->is_rollback = false;
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_FALSE(status.is_enterprise_rollback);
}
TEST_F(UpdateAttempterTest, IsEnterpriseRollbackInGetStatusTrue) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->is_rollback = true;
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_TRUE(status.is_enterprise_rollback);
}
TEST_F(UpdateAttempterTest, PowerwashInGetStatusDefault) {
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_FALSE(status.will_powerwash_after_reboot);
}
TEST_F(UpdateAttempterTest, PowerwashInGetStatusTrueBecausePowerwashRequired) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->powerwash_required = true;
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_TRUE(status.will_powerwash_after_reboot);
}
TEST_F(UpdateAttempterTest, PowerwashInGetStatusTrueBecauseRollback) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->is_rollback = true;
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_TRUE(status.will_powerwash_after_reboot);
}
TEST_F(UpdateAttempterTest, CriticalUpdateDefault) {
attempter_.install_plan_.reset(new InstallPlan);
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_EQ(status.update_urgency_internal,
update_engine::UpdateUrgencyInternal::REGULAR);
}
TEST_F(UpdateAttempterTest, CriticalUpdate) {
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->update_urgency =
update_engine::UpdateUrgencyInternal::CRITICAL;
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_EQ(status.update_urgency_internal,
update_engine::UpdateUrgencyInternal::CRITICAL);
}
TEST_F(UpdateAttempterTest, FutureEolTest) {
EolDate eol_date = std::numeric_limits<int64_t>::max();
EXPECT_TRUE(prefs_->SetString(kPrefsOmahaEolDate, EolDateToString(eol_date)));
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_EQ(eol_date, status.eol_date);
}
TEST_F(UpdateAttempterTest, PastEolTest) {
EolDate eol_date = 1;
EXPECT_TRUE(prefs_->SetString(kPrefsOmahaEolDate, EolDateToString(eol_date)));
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_EQ(eol_date, status.eol_date);
}
TEST_F(UpdateAttempterTest, MissingEolTest) {
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_EQ(kEolDateInvalid, status.eol_date);
}
TEST_F(UpdateAttempterTest, LastAttemptError) {
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_EQ(static_cast<int32_t>(ErrorCode::kSuccess),
status.last_attempt_error);
}
TEST_F(UpdateAttempterTest, NoUpdateLastAttemptError) {
attempter_.ProcessingDone(nullptr, ErrorCode::kNoUpdate);
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_EQ(static_cast<int32_t>(ErrorCode::kNoUpdate),
status.last_attempt_error);
}
TEST_F(UpdateAttempterTest, SomeOtherLastAttemptError) {
attempter_.ProcessingDone(nullptr, ErrorCode::kVerityCalculationError);
UpdateEngineStatus status;
attempter_.GetStatus(&status);
EXPECT_EQ(static_cast<int32_t>(ErrorCode::kError), status.last_attempt_error);
}
TEST_F(UpdateAttempterTest, RepeatedUpdateFeatureDisabledByDefault) {
UpdateEngineStatus status;
attempter_.GetStatus(&status);
auto end = std::end(status.features);
auto feature_itr =
std::find_if(std::begin(status.features),
end,
[](decltype(status.features)::value_type v) {
return v.name == update_engine::kFeatureRepeatedUpdates;
});
EXPECT_TRUE(feature_itr != end);
EXPECT_FALSE(feature_itr->enabled);
}
TEST_F(UpdateAttempterTest, RepeatedUpdateFeatureEnabled) {
auto* fake_prefs = FakeSystemState::Get()->prefs();
fake_prefs->SetBoolean(kPrefsAllowRepeatedUpdates, true);
UpdateEngineStatus status;
attempter_.GetStatus(&status);
auto end = std::end(status.features);
auto feature_itr =
std::find_if(std::begin(status.features),
end,
[](decltype(status.features)::value_type v) {
return v.name == update_engine::kFeatureRepeatedUpdates;
});
EXPECT_TRUE(feature_itr != end);
EXPECT_TRUE(feature_itr->enabled);
}
TEST_F(UpdateAttempterTest, ConsumerAutoUpdateFeatureEnabledByDefault) {
UpdateEngineStatus status;
attempter_.GetStatus(&status);
auto end = std::end(status.features);
auto feature_itr =
std::find_if(std::begin(status.features),
end,
[](decltype(status.features)::value_type v) {
return v.name == update_engine::kFeatureConsumerAutoUpdate;
});
EXPECT_TRUE(feature_itr != end);
EXPECT_TRUE(feature_itr->enabled);
}
TEST_F(UpdateAttempterTest, ConsumerAutoUpdateFeatureDisabled) {
auto* fake_prefs = FakeSystemState::Get()->prefs();
fake_prefs->SetBoolean(kPrefsConsumerAutoUpdateDisabled, true);
UpdateEngineStatus status;
attempter_.GetStatus(&status);
auto end = std::end(status.features);
auto feature_itr =
std::find_if(std::begin(status.features),
end,
[](decltype(status.features)::value_type v) {
return v.name == update_engine::kFeatureConsumerAutoUpdate;
});
EXPECT_TRUE(feature_itr != end);
EXPECT_FALSE(feature_itr->enabled);
}
TEST_F(UpdateAttempterTest, SetStatusAndNotifyTest) {
MockServiceObserver observer;
attempter_.AddObserver(&observer);
EXPECT_CALL(observer,
SendStatusUpdate(Field(&UpdateEngineStatus::status,
UpdateStatus::UPDATED_NEED_REBOOT)));
attempter_.SetStatusAndNotify(UpdateStatus::UPDATED_NEED_REBOOT);
UpdateEngineStatus engine_status;
attempter_.GetStatus(&engine_status);
EXPECT_EQ(UpdateStatus::UPDATED_NEED_REBOOT, engine_status.status);
}
TEST_F(UpdateAttempterTest, CalculateDlcParamsInstallTest) {
EXPECT_CALL(mock_dlc_utils_, GetDlcManifest)
.WillOnce(testing::Return(nullptr));
string dlc_id = "dlc0";
attempter_.pm_ = ProcessMode::INSTALL;
attempter_.dlc_ids_ = {dlc_id};
attempter_.CalculateDlcParams();
OmahaRequestParams* params = FakeSystemState::Get()->request_params();
EXPECT_EQ(1, params->dlc_apps_params().count(params->GetDlcAppId(dlc_id)));
OmahaRequestParams::AppParams dlc_app_params =
params->dlc_apps_params().at(params->GetDlcAppId(dlc_id));
EXPECT_STREQ(dlc_id.c_str(), dlc_app_params.name.c_str());
EXPECT_EQ(false, dlc_app_params.send_ping);
// When the DLC gets installed, a ping is not sent, therefore we don't store
// the values sent by Omaha.
auto last_active_key = PrefsInterface::CreateSubKey(
{kDlcPrefsSubDir, dlc_id, kPrefsPingLastActive});
EXPECT_FALSE(FakeSystemState::Get()->prefs()->Exists(last_active_key));
auto last_rollcall_key = PrefsInterface::CreateSubKey(
{kDlcPrefsSubDir, dlc_id, kPrefsPingLastRollcall});
EXPECT_FALSE(FakeSystemState::Get()->prefs()->Exists(last_rollcall_key));
}
TEST_F(UpdateAttempterTest, CalculateDlcParamsNoPrefFilesTest) {
string dlc_id = "dlc0";
EXPECT_CALL(mock_dlcservice_, GetDlcsToUpdate(_))
.WillOnce(
DoAll(SetArgPointee<0>(std::vector<string>({dlc_id})), Return(true)));
EXPECT_CALL(mock_dlc_utils_, GetDlcManifest)
.WillOnce(testing::Return(nullptr));
attempter_.pm_ = ProcessMode::UPDATE;
attempter_.CalculateDlcParams();
OmahaRequestParams* params = FakeSystemState::Get()->request_params();
EXPECT_EQ(1, params->dlc_apps_params().count(params->GetDlcAppId(dlc_id)));
OmahaRequestParams::AppParams dlc_app_params =
params->dlc_apps_params().at(params->GetDlcAppId(dlc_id));
EXPECT_STREQ(dlc_id.c_str(), dlc_app_params.name.c_str());
EXPECT_EQ(true, dlc_app_params.send_ping);
EXPECT_EQ(0, dlc_app_params.ping_active);
EXPECT_EQ(-1, dlc_app_params.ping_date_last_active);
EXPECT_EQ(-1, dlc_app_params.ping_date_last_rollcall);
EXPECT_EQ("", dlc_app_params.last_fp);
}
TEST_F(UpdateAttempterTest, CalculateDlcParamsNonParseableValuesTest) {
string dlc_id = "dlc0";
MemoryPrefs prefs;
FakeSystemState::Get()->set_prefs(&prefs);
EXPECT_CALL(mock_dlcservice_, GetDlcsToUpdate(_))
.WillOnce(
DoAll(SetArgPointee<0>(std::vector<string>({dlc_id})), Return(true)));
EXPECT_CALL(mock_dlc_utils_, GetDlcManifest)
.WillOnce(testing::Return(nullptr));
// Write non numeric values in the metadata files.
auto active_key =
PrefsInterface::CreateSubKey({kDlcPrefsSubDir, dlc_id, kPrefsPingActive});
auto last_active_key = PrefsInterface::CreateSubKey(
{kDlcPrefsSubDir, dlc_id, kPrefsPingLastActive});
auto last_rollcall_key = PrefsInterface::CreateSubKey(
{kDlcPrefsSubDir, dlc_id, kPrefsPingLastRollcall});
FakeSystemState::Get()->prefs()->SetString(active_key, "z2yz");
FakeSystemState::Get()->prefs()->SetString(last_active_key, "z2yz");
FakeSystemState::Get()->prefs()->SetString(last_rollcall_key, "z2yz");
attempter_.pm_ = ProcessMode::UPDATE;
attempter_.CalculateDlcParams();
OmahaRequestParams* params = FakeSystemState::Get()->request_params();
EXPECT_EQ(1, params->dlc_apps_params().count(params->GetDlcAppId(dlc_id)));
OmahaRequestParams::AppParams dlc_app_params =
params->dlc_apps_params().at(params->GetDlcAppId(dlc_id));
EXPECT_STREQ(dlc_id.c_str(), dlc_app_params.name.c_str());
EXPECT_EQ(true, dlc_app_params.send_ping);
EXPECT_EQ(0, dlc_app_params.ping_active);
EXPECT_EQ(-2, dlc_app_params.ping_date_last_active);
EXPECT_EQ(-2, dlc_app_params.ping_date_last_rollcall);
}
TEST_F(UpdateAttempterTest, CalculateDlcParamsValidValuesTest) {
string dlc_id = "dlc0";
EXPECT_CALL(mock_dlcservice_, GetDlcsToUpdate(_))
.WillOnce(
DoAll(SetArgPointee<0>(std::vector<string>({dlc_id})), Return(true)));
EXPECT_CALL(mock_dlc_utils_, GetDlcManifest)
.WillOnce(testing::Return(nullptr));
// Write numeric values in the metadata files.
auto active_key =
PrefsInterface::CreateSubKey({kDlcPrefsSubDir, dlc_id, kPrefsPingActive});
auto last_active_key = PrefsInterface::CreateSubKey(
{kDlcPrefsSubDir, dlc_id, kPrefsPingLastActive});
auto last_rollcall_key = PrefsInterface::CreateSubKey(
{kDlcPrefsSubDir, dlc_id, kPrefsPingLastRollcall});
auto last_fp_key =
PrefsInterface::CreateSubKey({kDlcPrefsSubDir, dlc_id, kPrefsLastFp});
FakeSystemState::Get()->prefs()->SetInt64(active_key, 1);
FakeSystemState::Get()->prefs()->SetInt64(last_active_key, 78);
FakeSystemState::Get()->prefs()->SetInt64(last_rollcall_key, 99);
FakeSystemState::Get()->prefs()->SetString(last_fp_key, "3.75");
attempter_.pm_ = ProcessMode::UPDATE;
attempter_.CalculateDlcParams();
OmahaRequestParams* params = FakeSystemState::Get()->request_params();
EXPECT_EQ(1, params->dlc_apps_params().count(params->GetDlcAppId(dlc_id)));
OmahaRequestParams::AppParams dlc_app_params =
params->dlc_apps_params().at(params->GetDlcAppId(dlc_id));
EXPECT_STREQ(dlc_id.c_str(), dlc_app_params.name.c_str());
EXPECT_EQ(true, dlc_app_params.send_ping);
EXPECT_EQ(1, dlc_app_params.ping_active);
EXPECT_EQ(78, dlc_app_params.ping_date_last_active);
EXPECT_EQ(99, dlc_app_params.ping_date_last_rollcall);
EXPECT_EQ("3.75", dlc_app_params.last_fp);
}
TEST_F(UpdateAttempterTest, ConsecutiveUpdateBeforeRebootSuccess) {
FakeSystemState::Get()->prefs()->SetString(kPrefsLastFp, "3.75");
attempter_.pm_ = ProcessMode::UPDATE;
attempter_.install_plan_.reset(new InstallPlan);
attempter_.install_plan_->payloads.push_back(
{.size = 1234ULL, .type = InstallPayloadType::kFull, .fp = "4.0"});
// Call |ProcessingDoneUpdate|.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
// Consecutive update metric should be updated.
int64_t num_updates;
prefs_->GetInt64(kPrefsConsecutiveUpdateCount, &num_updates);
EXPECT_EQ(num_updates, 1);
// Validate that consecutive count gets incremented on updates.
TestProcessingDone();
prefs_->GetInt64(kPrefsConsecutiveUpdateCount, &num_updates);
EXPECT_EQ(num_updates, 2);
}
TEST_F(UpdateAttempterTest, ConsecutiveUpdateBeforeRebootLimited) {
// Default should be true.
EXPECT_TRUE(attempter_.IsRepeatedUpdatesEnabled());
// Disabled feature.
EXPECT_TRUE(prefs_->SetBoolean(kPrefsAllowRepeatedUpdates, false));
EXPECT_FALSE(attempter_.IsRepeatedUpdatesEnabled());
EXPECT_TRUE(prefs_->SetBoolean(kPrefsAllowRepeatedUpdates, true));
EXPECT_TRUE(attempter_.IsRepeatedUpdatesEnabled());
EXPECT_TRUE(prefs_->SetInt64(kPrefsConsecutiveUpdateCount,
kConsecutiveUpdateLimit - 1));
EXPECT_TRUE(attempter_.IsRepeatedUpdatesEnabled());
EXPECT_TRUE(
prefs_->SetInt64(kPrefsConsecutiveUpdateCount, kConsecutiveUpdateLimit));
EXPECT_FALSE(attempter_.IsRepeatedUpdatesEnabled());
}
TEST_F(UpdateAttempterTest, ConsecutiveUpdateFailureMetric) {
MockAction action;
// Two previous consecutive updates.
prefs_->SetInt64(kPrefsConsecutiveUpdateCount, 2);
// Fail an update.
EXPECT_CALL(action, Type()).WillRepeatedly(Return("MockAction"));
attempter_.status_ = UpdateStatus::DOWNLOADING;
EXPECT_CALL(*FakeSystemState::Get()->mock_metrics_reporter(),
ReportFailedConsecutiveUpdate());
attempter_.ActionCompleted(nullptr, &action, ErrorCode::kError);
ASSERT_NE(nullptr, attempter_.error_event_.get());
}
TEST_F(UpdateAttempterTest, InvalidateLastUpdate) {
// Mock a previous update.
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
attempter_.status_ = UpdateStatus::UPDATED_NEED_REBOOT;
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
SetRollbackHappened(false))
.Times(1);
// Invalidate an update.
MockAction action;
attempter_.ActionCompleted(
nullptr, &action, ErrorCode::kInvalidateLastUpdate);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
EXPECT_FALSE(FakeSystemState::Get()->fake_hardware()->IsPowerwashScheduled());
EXPECT_TRUE(FakeSystemState::Get()->fake_hardware()->IsFWTryNextSlotReset());
}
TEST_F(UpdateAttempterTest, InvalidateLastPowerwashUpdate) {
// Mock a previous update.
bool save_rollback_data = true;
FakeSystemState::Get()->fake_hardware()->SchedulePowerwash(
save_rollback_data);
FakeSystemState::Get()
->fake_hardware()
->SetIsPowerwashScheduledByUpdateEngine(true);
EXPECT_TRUE(FakeSystemState::Get()->fake_hardware()->IsPowerwashScheduled());
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
attempter_.status_ = UpdateStatus::UPDATED_NEED_REBOOT;
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
SetRollbackHappened(false))
.Times(1);
// Invalidate an update.
MockAction action;
attempter_.ActionCompleted(
nullptr, &action, ErrorCode::kInvalidateLastUpdate);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
EXPECT_FALSE(FakeSystemState::Get()->fake_hardware()->IsPowerwashScheduled());
EXPECT_TRUE(FakeSystemState::Get()->fake_hardware()->IsFWTryNextSlotReset());
}
TEST_F(UpdateAttempterTest, InvalidateLastUpdateNoPowerwashFile) {
// Mock a previous update.
bool save_rollback_data = true;
FakeSystemState::Get()->fake_hardware()->SchedulePowerwash(
save_rollback_data);
EXPECT_TRUE(FakeSystemState::Get()->fake_hardware()->IsPowerwashScheduled());
FakeSystemState::Get()
->fake_hardware()
->SetIsPowerwashScheduledByUpdateEngine(std::nullopt);
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
attempter_.status_ = UpdateStatus::UPDATED_NEED_REBOOT;
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
SetRollbackHappened(false))
.Times(1);
// Invalidate an update.
MockAction action;
attempter_.ActionCompleted(
nullptr, &action, ErrorCode::kInvalidateLastUpdate);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
EXPECT_TRUE(FakeSystemState::Get()->fake_hardware()->IsPowerwashScheduled());
EXPECT_TRUE(FakeSystemState::Get()->fake_hardware()->IsFWTryNextSlotReset());
}
TEST_F(UpdateAttempterTest, InvalidateLastUpdateExternalPowerwash) {
// Mock a previous update.
bool save_rollback_data = true;
FakeSystemState::Get()->fake_hardware()->SchedulePowerwash(
save_rollback_data);
EXPECT_TRUE(FakeSystemState::Get()->fake_hardware()->IsPowerwashScheduled());
FakeSystemState::Get()
->fake_hardware()
->SetIsPowerwashScheduledByUpdateEngine(false);
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
attempter_.status_ = UpdateStatus::UPDATED_NEED_REBOOT;
EXPECT_CALL(*FakeSystemState::Get()->mock_payload_state(),
SetRollbackHappened(false))
.Times(1);
// Invalidate an update.
MockAction action;
attempter_.ActionCompleted(
nullptr, &action, ErrorCode::kInvalidateLastUpdate);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
EXPECT_TRUE(FakeSystemState::Get()->fake_hardware()->IsPowerwashScheduled());
EXPECT_TRUE(FakeSystemState::Get()->fake_hardware()->IsFWTryNextSlotReset());
}
TEST_F(UpdateAttempterTest, CalculateDlcParamsRemoveStaleMetadata) {
string dlc_id = "dlc0";
auto active_key =
PrefsInterface::CreateSubKey({kDlcPrefsSubDir, dlc_id, kPrefsPingActive});
auto last_active_key = PrefsInterface::CreateSubKey(
{kDlcPrefsSubDir, dlc_id, kPrefsPingLastActive});
auto last_rollcall_key = PrefsInterface::CreateSubKey(
{kDlcPrefsSubDir, dlc_id, kPrefsPingLastRollcall});
FakeSystemState::Get()->prefs()->SetInt64(active_key, kPingInactiveValue);
FakeSystemState::Get()->prefs()->SetInt64(last_active_key, 0);
FakeSystemState::Get()->prefs()->SetInt64(last_rollcall_key, 0);
EXPECT_TRUE(FakeSystemState::Get()->prefs()->Exists(active_key));
EXPECT_TRUE(FakeSystemState::Get()->prefs()->Exists(last_active_key));
EXPECT_TRUE(FakeSystemState::Get()->prefs()->Exists(last_rollcall_key));
attempter_.dlc_ids_ = {dlc_id};
attempter_.pm_ = ProcessMode::INSTALL;
attempter_.CalculateDlcParams();
EXPECT_FALSE(FakeSystemState::Get()->prefs()->Exists(last_active_key));
EXPECT_FALSE(FakeSystemState::Get()->prefs()->Exists(last_rollcall_key));
// Active key is set on install.
EXPECT_TRUE(FakeSystemState::Get()->prefs()->Exists(active_key));
int64_t temp_int;
EXPECT_TRUE(FakeSystemState::Get()->prefs()->GetInt64(active_key, &temp_int));
EXPECT_EQ(temp_int, kPingActiveValue);
}
TEST_F(UpdateAttempterTest, SetDlcActiveValue) {
string dlc_id = "dlc0";
attempter_.SetDlcActiveValue(true, dlc_id);
int64_t temp_int;
auto active_key =
PrefsInterface::CreateSubKey({kDlcPrefsSubDir, dlc_id, kPrefsPingActive});
EXPECT_TRUE(FakeSystemState::Get()->prefs()->Exists(active_key));
EXPECT_TRUE(FakeSystemState::Get()->prefs()->GetInt64(active_key, &temp_int));
EXPECT_EQ(temp_int, kPingActiveValue);
}
TEST_F(UpdateAttempterTest, SetDlcInactive) {
string dlc_id = "dlc0";
auto sub_keys = {
kPrefsPingActive, kPrefsPingLastActive, kPrefsPingLastRollcall};
for (auto& sub_key : sub_keys) {
auto key = PrefsInterface::CreateSubKey({kDlcPrefsSubDir, dlc_id, sub_key});
FakeSystemState::Get()->prefs()->SetInt64(key, 1);
EXPECT_TRUE(FakeSystemState::Get()->prefs()->Exists(key));
}
attempter_.SetDlcActiveValue(false, dlc_id);
for (auto& sub_key : sub_keys) {
auto key = PrefsInterface::CreateSubKey({kDlcPrefsSubDir, dlc_id, sub_key});
EXPECT_FALSE(FakeSystemState::Get()->prefs()->Exists(key));
}
}
TEST_F(UpdateAttempterTest, GetSuccessfulDlcIds) {
auto dlc_1 = "1", dlc_2 = "2", dlc_3 = "3";
attempter_.omaha_request_params_->set_dlc_apps_params(
{{dlc_1, {.name = dlc_1, .updated = false}},
{dlc_2, {.name = dlc_2}},
{dlc_3, {.name = dlc_3, .updated = false}}});
EXPECT_THAT(attempter_.GetSuccessfulDlcIds(), ElementsAre(dlc_2));
}
TEST_F(UpdateAttempterTest, MoveToPrefs) {
string key1 = kPrefsLastActivePingDay;
string key2 = kPrefsPingLastRollcall;
FakePrefs fake_prefs;
EXPECT_TRUE(fake_prefs.SetString(key2, "current-rollcall"));
FakeSystemState::Get()->set_prefs(&fake_prefs);
FakePrefs powerwash_safe_prefs;
EXPECT_TRUE(powerwash_safe_prefs.SetString(key1, "powerwash-last-active"));
EXPECT_TRUE(powerwash_safe_prefs.SetString(key2, "powerwash-last-rollcall"));
FakeSystemState::Get()->set_powerwash_safe_prefs(&powerwash_safe_prefs);
attempter_.Init();
attempter_.MoveToPrefs({key1, key2});
string pref_value_1;
fake_prefs.GetString(key1, &pref_value_1);
EXPECT_EQ(pref_value_1, "powerwash-last-active");
// Do not overwrite if value already exists.
string pref_value_2;
fake_prefs.GetString(key2, &pref_value_2);
EXPECT_EQ(pref_value_2, "current-rollcall");
// Make sure keys are deleted from powerwash safe prefs regardless of whether
// they are written to prefs.
EXPECT_FALSE(FakeSystemState::Get()->powerwash_safe_prefs()->Exists(key1));
EXPECT_FALSE(FakeSystemState::Get()->powerwash_safe_prefs()->Exists(key2));
}
TEST_F(UpdateAttempterTest, ResetUpdatePrefs) {
// Write update prefs.
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
auto* fake_prefs = FakeSystemState::Get()->prefs();
fake_prefs->SetString(kPrefsLastFp, "3.14");
fake_prefs->SetString(kPrefsPreviousVersion, "prev-version");
fake_prefs->SetString(kPrefsDeferredUpdateCompleted, "");
// Make sure prefs are deleted.
EXPECT_TRUE(attempter_.ResetUpdatePrefs());
EXPECT_FALSE(fake_prefs->Exists(kPrefsDeferredUpdateCompleted));
EXPECT_FALSE(fake_prefs->Exists(kPrefsUpdateCompletedOnBootId));
EXPECT_FALSE(fake_prefs->Exists(kPrefsUpdateCompletedBootTime));
EXPECT_FALSE(fake_prefs->Exists(kPrefsLastFp));
EXPECT_FALSE(fake_prefs->Exists(kPrefsPreviousVersion));
}
TEST_F(UpdateAttempterTest, InstallZeroDlcTest) {
attempter_.Install();
EXPECT_EQ(UpdateStatus::IDLE, attempter_.status_);
}
TEST_F(UpdateAttempterTest, InstallSingleDlcTest) {
attempter_.dlc_ids_ = {"dlc_a"};
attempter_.Install();
EXPECT_EQ(UpdateStatus::CHECKING_FOR_UPDATE, attempter_.status_);
loop_.BreakLoop();
}
TEST_F(UpdateAttempterTest, InstallMultiDlcTest) {
attempter_.dlc_ids_ = {"dlc_a", "dlc_b"};
attempter_.Install();
EXPECT_EQ(UpdateStatus::IDLE, attempter_.status_);
}
TEST_F(UpdateAttempterTest,
ShouldCancelReturnsTrueIfEnterpriseUpdatesDisabled) {
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
ErrorCode error_code = ErrorCode::kSuccess;
EXPECT_EQ(attempter_.ShouldCancel(&error_code), true);
EXPECT_EQ(error_code, ErrorCode::kDownloadCancelledPerPolicy);
}
TEST_F(UpdateAttempterTest, ShouldCancelReturnsFalseIfNonEnterprise) {
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(false));
ErrorCode error_code = ErrorCode::kSuccess;
EXPECT_EQ(attempter_.ShouldCancel(&error_code), false);
EXPECT_EQ(error_code, ErrorCode::kSuccess);
}
TEST_F(UpdateAttempterTest,
ShouldCancelReturnsFalseIfEnterpriseUpdatesEnabled) {
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(false));
ErrorCode error_code = ErrorCode::kSuccess;
EXPECT_EQ(attempter_.ShouldCancel(&error_code), false);
EXPECT_EQ(error_code, ErrorCode::kSuccess);
}
TEST_F(UpdateAttempterTest, AfterRestartUpdateInvalidationScheduled) {
// Mock a previous update.
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
attempter_.Init();
EXPECT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
}
TEST_F(UpdateAttempterTest, AfterRestartNoInvalidationScheduledIfNoUpdate) {
ASSERT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
attempter_.Init();
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
}
TEST_F(UpdateAttempterTest,
AfterRestartNoInvalidationScheduledIfDeferredUpdate) {
// Mock a previous update.
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
FakeSystemState::Get()->fake_prefs()->SetString(kPrefsDeferredUpdateCompleted,
"");
attempter_.Init();
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
}
TEST_F(UpdateAttempterTest, AfterRestartInvalidatesUpdate) {
// Mock a previous update.
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
// Init the update attempter to schedule the update invalidation.
attempter_.Init();
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Configure the enterprise policy.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterRestartSubscribesInvalidatesUpdate) {
// Mock a previous update.
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
// Init the update attempter to schedule the update invalidation.
attempter_.Init();
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Enable updates first, so that the update attempter subscribes to
// the policy changes.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(false));
loop_.RunOnce(false);
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
// Disables the enterprise updates and notify the policy request.
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->NotifyValueChanged();
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest,
AfterRestartSkipsUpdateInvalidationIfNonEnterprise) {
// Mock a previous update.
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
// Init the update attempter to schedule the update invalidation.
attempter_.Init();
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Configure the non enterprise policy.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(false));
device_policy_provider->var_update_disabled()->reset(new bool(false));
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterRestartSkipsUpdateInvalidationIfNotIdle) {
// Mock a previous update.
FakeSystemState::Get()->fake_clock()->SetBootTime(Time::FromTimeT(42));
attempter_.WriteUpdateCompletedMarker();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
// Init the update attempter to schedule the update invalidation.
attempter_.Init();
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Disable the updates via the enterprise policy, but make
// the update engine non IDLE.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
attempter_.status_ = UpdateStatus::CHECKING_FOR_UPDATE;
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterUpdateInvalidatesUpdate) {
// Disables the updates via the enterprise policy.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
// Complete an update cycle.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterUpdateInvalidatesUpdateMetrics) {
// Disables the updates via the enterprise policy.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
EXPECT_CALL(*FakeSystemState::Get()->mock_metrics_reporter(),
ReportEnterpriseUpdateInvalidatedResult(true))
.Times(1);
// Complete an update cycle.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterUpdateInvalidatesUpdateFailureMetrics) {
// Disables the updates via the enterprise policy.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
FakeSystemState::Get()->fake_hardware()->SetFailResetFwTryNextSlot(true);
EXPECT_CALL(*FakeSystemState::Get()->mock_metrics_reporter(),
ReportEnterpriseUpdateInvalidatedResult(false))
.Times(1);
// Complete an update cycle.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterUpdateSubscribesInvalidatesUpdate) {
// First enable the updates.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(false));
// Complete an update cycle.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Also disable the updates after the completion and notify
// the policy request.
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->NotifyValueChanged();
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterUpdateSkipsUpdateInvalidationIfNonEnterprise) {
// Configure the non enterprise policy.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(false));
// Complete an update cycle.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterUpdateSkipsInvalidationIfDeferredUpdates) {
// Disable the updates via the enterprise policy.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
// Complete an update cycle.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Fake a deferred update.
attempter_.status_ = UpdateStatus::UPDATED_BUT_DEFERRED;
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterUpdateSkipsUpdateInvalidationIfNonIdle) {
// Disable the updates via the enterprise policy.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
// Complete an update cycle.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Make the update engine non IDLE.
attempter_.status_ = UpdateStatus::CHECKING_FOR_UPDATE;
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterRepeatedUpdateInvalidatesUpdate) {
// Enable the updates.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(false));
// Complete the first update cycle.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
loop_.RunOnce(false);
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Complete a repeated update cycle.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Disable the updates and notify the policy request.
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->NotifyValueChanged();
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
}
TEST_F(UpdateAttempterTest, AfterRepeatedInvalidatesUpdateOnError) {
// Enable the updates.
chromeos_update_manager::FakeDevicePolicyProvider* device_policy_provider =
FakeSystemState::Get()
->fake_update_manager()
->state()
->device_policy_provider();
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(false));
// Complete the first update cycle.
pd_params_.should_update_completed_be_called = true;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
loop_.RunOnce(false);
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Error out in the next repeated update cycle.
pd_params_.code = ErrorCode::kNoUpdate;
pd_params_.should_update_completed_be_called = false;
pd_params_.expected_exit_status = UpdateStatus::UPDATED_NEED_REBOOT;
TestProcessingDone();
ASSERT_TRUE(attempter_.GetBootTimeAtUpdate(nullptr));
ASSERT_TRUE(attempter_.enterprise_update_invalidation_check_scheduled_);
// Disable the updates and notify the policy request.
device_policy_provider->var_is_enterprise_enrolled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->reset(new bool(true));
device_policy_provider->var_update_disabled()->NotifyValueChanged();
loop_.RunOnce(false);
EXPECT_FALSE(attempter_.enterprise_update_invalidation_check_scheduled_);
EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(nullptr));
}
} // namespace chromeos_update_engine