Google Git
Sign in
chromium / chromium / src.git / 011e9e9186497ce3d03e6860cbf2862bf7b4f07d
commit011e9e9186497ce3d03e6860cbf2862bf7b4f07d[log] [tgz]
authorMohamed Amir Yosef <mamir@chromium.org>Thu May 23 10:12:14 2019
committerCommit Bot <commit-bot@chromium.org>Thu May 23 10:12:14 2019
treee6724ccc215a1b6e1c8a7ff2ea1e971d7794de5d
parent46534e7b11c447871d643bb32d9f12f8a80d2fdf [diff]
[PasswordManager] Report error in PasswordStore::AddLogin()

PasswordStore::AddLogin() can fail for various reasons.
Before this CL:
AddLogin() returns an empty change list in case of error.
After this CL:
AddLogin() accepts an optional output parameter to report the exact
error. This is required for Sync machinery because it will react
differently to different bugs.

Follow up patches will consume this output parameter.

Change-Id: I2e58d945cbd4f3a099e27dce75075062f24b0785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621135
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662562}
17 files changed
tree: e6724ccc215a1b6e1c8a7ff2ea1e971d7794de5d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .