CSS: Remove unused CSSURLImageValue::Create() method.
This seems to have no callsites. Also remove FromCSSValue() which is
just a wrapper around MakeGarbageCollected.
Change-Id: I3fd79d58fd54606555d80f716c9ca979cc975ccf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680121
Auto-Submit: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672833}
diff --git a/third_party/blink/renderer/core/css/cssom/css_url_image_value.cc b/third_party/blink/renderer/core/css/cssom/css_url_image_value.cc
index 97005aba..922cd34 100644
--- a/third_party/blink/renderer/core/css/cssom/css_url_image_value.cc
+++ b/third_party/blink/renderer/core/css/cssom/css_url_image_value.cc
@@ -5,34 +5,11 @@
#include "third_party/blink/renderer/core/css/cssom/css_url_image_value.h"
#include "third_party/blink/renderer/core/css/css_image_value.h"
-#include "third_party/blink/renderer/core/execution_context/execution_context.h"
#include "third_party/blink/renderer/core/loader/resource/image_resource_content.h"
#include "third_party/blink/renderer/core/style/style_image.h"
-#include "third_party/blink/renderer/platform/bindings/exception_state.h"
-#include "third_party/blink/renderer/platform/bindings/script_state.h"
namespace blink {
-CSSURLImageValue* CSSURLImageValue::Create(ScriptState* script_state,
- const AtomicString& url,
- ExceptionState& exception_state) {
- const auto* execution_context = ExecutionContext::From(script_state);
- DCHECK(execution_context);
- KURL parsed_url = execution_context->CompleteURL(url);
- if (!parsed_url.IsValid()) {
- exception_state.ThrowTypeError("Failed to parse URL from " + url);
- return nullptr;
- }
- // Use absolute URL for CSSImageValue but keep relative URL for
- // getter and serialization.
- return MakeGarbageCollected<CSSURLImageValue>(
- *CSSImageValue::Create(url, parsed_url, Referrer()));
-}
-
-CSSURLImageValue* CSSURLImageValue::FromCSSValue(const CSSImageValue& value) {
- return MakeGarbageCollected<CSSURLImageValue>(value);
-}
-
const String& CSSURLImageValue::url() const {
return value_->RelativeUrl();
}
diff --git a/third_party/blink/renderer/core/css/cssom/css_url_image_value.h b/third_party/blink/renderer/core/css/cssom/css_url_image_value.h
index 9635cb3..f8ca0aa2 100644
--- a/third_party/blink/renderer/core/css/cssom/css_url_image_value.h
+++ b/third_party/blink/renderer/core/css/cssom/css_url_image_value.h
@@ -10,17 +10,10 @@
namespace blink {
-class ScriptState;
class CSSImageValue;
class CORE_EXPORT CSSURLImageValue final : public CSSStyleImageValue {
public:
- static CSSURLImageValue* Create(ScriptState*,
- const AtomicString& url,
- ExceptionState&);
-
- static CSSURLImageValue* FromCSSValue(const CSSImageValue&);
-
explicit CSSURLImageValue(const CSSImageValue& value) : value_(value) {}
const String& url() const;
diff --git a/third_party/blink/renderer/core/css/cssom/style_value_factory.cc b/third_party/blink/renderer/core/css/cssom/style_value_factory.cc
index 7638247..03372727 100644
--- a/third_party/blink/renderer/core/css/cssom/style_value_factory.cc
+++ b/third_party/blink/renderer/core/css/cssom/style_value_factory.cc
@@ -54,9 +54,8 @@
return CSSKeywordValue::FromCSSValue(value);
if (auto* primitive_value = DynamicTo<CSSPrimitiveValue>(value))
return CSSNumericValue::FromCSSValue(*primitive_value);
- if (auto* image_value = DynamicTo<CSSImageValue>(value)) {
- return CSSURLImageValue::FromCSSValue(*image_value->Clone());
- }
+ if (auto* image_value = DynamicTo<CSSImageValue>(value))
+ return MakeGarbageCollected<CSSURLImageValue>(*image_value->Clone());
return nullptr;
}
