Google Git
Sign in
chromium / chromium / src.git / 0394d57117743f8f4619d4c41cde279f558129e2
commit0394d57117743f8f4619d4c41cde279f558129e2[log] [tgz]
authorTomasz Wiszkowski <ender@google.com>Thu Aug 06 18:44:31 2020
committerCommit Bot <commit-bot@chromium.org>Thu Aug 06 18:44:31 2020
tree445a2312ce73713c206d559f3eba2c615ae6a13b
parent7b60c7f77c1c385b48022c4e97419159a28bacf6 [diff]
Reland "Log abandoned omnibox interactions."

The previous change was reverted because the newly introduced focus_resulted_in_navigation_ member
caused MSAN failures as in some test scenarios the value would end up being uninitialized.

The value is now default-initialized in constructor.

This is a reland of 2ce4939f0bf1156753672332445e19b26c163216

Original change's description:
> Log abandoned omnibox interactions.
> 
> Introduces new metric recording outcome of every Omnibox focus event.
> Logged result will allow us to monitor for increase in abandoned
> interactions as we introduce new suggestion types.
> 
> Bug: 1105156
> Change-Id: I0b12e8cfa748e6a33f1d44e96ade77bf0b39cdd5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329878
> Commit-Queue: Ender 💬 = 🕐 (ping me for faster reviews) <ender@google.com>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#795155}

Bug: 1105156
Change-Id: I67231a7c653617f3f197b66bf9c25a0183710fc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340411
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#795560}
6 files changed
tree: 445a2312ce73713c206d559f3eba2c615ae6a13b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.