commit | 1030264cfa996a494a9d093b0777b8eaace8252a | [log] [tgz] |
---|---|---|
author | Peter Boström <pbos@chromium.org> | Thu Jun 27 22:49:20 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jun 27 22:49:20 2019 |
tree | 0ff6df12fbcfdd22b04b79a5f35ec4b794845468 | |
parent | f915ba7cac7cb58b9694ea26314df813c7f64dce [diff] |
Fix crash during ToolbarActionsBar destruction Prevents observing changes to the ToolbarActionsModel due to destruction of members of ToolbarActionsBar that are declared after the ScopedObserver. Observing the destruction of |pending_bubble_controller_| is theorized as the root cause for a crash that calls back into BrowserActionsContainer while it's being destructed (which is what triggers ToolbarActionsBar destruction). Bug: chromium:978367 Change-Id: Ib4372c46776dca1ddb085408b7f80ac027a610f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680377 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#673102}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .