Google Git
Sign in
chromium / chromium / src.git / 129650cb78882d2657d77cbd56799c58bb16e493
commit129650cb78882d2657d77cbd56799c58bb16e493[log] [tgz]
authorKuo Jen Wei <inker@chromium.org>Thu Jul 25 10:36:34 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jul 25 10:36:34 2019
tree9758d232f4a0cdc2a86e1c91cb3529a5fad8bd3c
parent44dcbd18a9567c6536cdf3e4c0a612c0340fe6fa [diff]
Revert "Remove WeakPtrFactory from MediaRecorderHandler"

This reverts commit 2a4f7981b942733a3e3f14385666ff10e695a263.

Reason for revert: CCA video playback can't work after 2nd video recording

BUG: 987559

Original change's description:
> Remove WeakPtrFactory from MediaRecorderHandler
>
> This CL removes WeakPtrFactory from MediaRecorderHandler class that
> is garbage collected and replaces the weak pointer with
> WeakPersistent references.
>
> Bug: 981572
> Change-Id: I5dbfc268177cac290b85246ec029833e6baf64ce
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688966
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#675183}

TBR=guidou@chromium.org,myid.shin@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 981572
Change-Id: I586bc94cdbfbdaf3d84ec7411e707eeb7d7df038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718004
Reviewed-by: Kuo Jen Wei <inker@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680801}
2 files changed
tree: 9758d232f4a0cdc2a86e1c91cb3529a5fad8bd3c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .