Google Git
Sign in
chromium / chromium / src.git / 1299ce3445a531b8d1203da6074f05baf2ef7483
commit1299ce3445a531b8d1203da6074f05baf2ef7483[log] [tgz]
authorFriedrich Horschig <fhorschig@chromium.org>Tue Jul 16 09:23:37 2019
committerCommit Bot <commit-bot@chromium.org>Tue Jul 16 09:23:37 2019
tree34bebd29595eb97c6489876501851c7bb0eb6152
parentf53596161bfcbf5d6f32dc525ea2b2b078a4c81c [diff]
[Mfill Android] Prevent keyboard opening when autofill UI dies

Before this change, the filling UI would open the keyboard when autofill
UI was destroyed. This is usually invisible since the whole page closes
usually when that happens. In rare cases, that happens earlier (e.g. the
linked bug where a navigation is stopped by confirmation).

With this change, the filling UI will hide if a source that populates it
disappears but trigger an opening animation. Net effect: open UIs are
closed when the last relevant source disappeared but remain untouched
otherwise.

Bug: 983421
Change-Id: I4f6aed2012069670f789ccaf73f70b3ce442511c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702243
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677692}
2 files changed
tree: 34bebd29595eb97c6489876501851c7bb0eb6152
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .