Google Git
Sign in
chromium / chromium / src.git / 13e89a7c7591fe36c1811bb6f1f2a9fd446dde8a
commit13e89a7c7591fe36c1811bb6f1f2a9fd446dde8a[log] [tgz]
authorDarren Shen <shend@chromium.org>Mon May 20 22:14:30 2019
committerCommit Bot <commit-bot@chromium.org>Mon May 20 22:14:30 2019
treefb54624f757cbbb89daa26986b7bc19f34e3a334
parent1bea34c21c77b213b2e8f32db67921d43c9df9e3 [diff]
vk: Create KeyboardUIModel and put state logic in there.

We wish to refactor the keyboard code using MVC in order to reduce the
size and responsibility of KeyboardController.

The plan is to have MVC for both the keyboard (configuration, enable
flags) and the keyboard UI (window management / animations etc.), akin
to how //ash/assistant has both |assistant_controller| and
|assistant_ui_controller|.

This patch creates a KeyboardUIModel, meant to contain information
related to the keyboard window & UI. We'll start by putting the UI state
code in there.

Future patches will move more code into the model and clean things up.

Bug: 964191
Change-Id: Ia2b026874ee72e48a21140cd3db4a0d86b62c7b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616826
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661496}
5 files changed
tree: fb54624f757cbbb89daa26986b7bc19f34e3a334
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .