commit 1552b481f541f870952505758cb277a5827ab0e1
author Christian Biesinger <cbiesinger@chromium.org> Thu May 16 22:40:42 2019
committer Commit Bot <commit-bot@chromium.org> Thu May 16 22:40:42 2019
tree a87736ffbdf1f4e71bdd62f25ecc4d1d60b94295
parent 96a124e126a9d7f94b29dcb8a5ea466c2725ad4d

[css-flexbox] Only do the initial child layout in one place

Instead of calling Layout in both ConstructAndAppendFlexItem and
ComputeInnerFlexBaseSize, only call it once in ConstructAndAppendFlexItem.

This has the side-effect that the scrollbar size can't change after
we compute it in ConstructAndAppendFlexItem, thus avoiding a check failure.

This will also avoid double layouts if UpdateBlockChildDirtyBits triggers
a layout.

The change to MainAxisContentExtentForChildIncludingScrollbar is a followup
to https://chromium-review.googlesource.com/c/chromium/src/+/1548326; this
now made a test fail without that change but I should have made the change
back then.

R=dgrogan@chromium.org

Bug: 963137
Change-Id: I28691c5e9d30d8425f16efcc95d2430098ca11f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614058
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660621}