Google Git
Sign in
chromium / chromium / src.git / 171e5eb40ad75f3b960a9a9c36a5877619d0626c
commit171e5eb40ad75f3b960a9a9c36a5877619d0626c[log] [tgz]
authorRobbie McElrath <rmcelrath@chromium.org>Mon Jun 17 19:38:06 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jun 17 19:38:06 2019
tree5fc17325b14936e9be58288880fb8f1e3abe4ba1
parentb86ce7907f420cffaffbbbc24a16075baab98b40 [diff]
Let NetworkService manage the NetworkChangeNotifier in unit tests

We jumped through a lot of hoops to deal with the NetworkChangeNotifier
leaking due to the NetworkService leaking, but now that
NetworkService is deleted between tests, we can remove the special
NetworkChangeNotifier test logic.

Bug: 901092
Change-Id: I49bd022fe2679f1b2ef7b716177af1f11df1457e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658644
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669776}
8 files changed
tree: 5fc17325b14936e9be58288880fb8f1e3abe4ba1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .