commit 1ccc5eeed0f535fe0c181f1ad3e6f0a05ed7f186
author Yutaka Hirano <yhirano@chromium.org> Mon Jul 29 03:54:15 2019
committer Commit Bot <commit-bot@chromium.org> Mon Jul 29 03:54:15 2019
tree c0260be8fba0992f8ddd63ce76b4924d5874bb18
parent cb1ad4625df51e74e66b5b4f727a1b9836ba7d05

Unify allow_credentials and credentials_mode on network::ResourceRequest

Remove allow_credentials, map allow_credentials: false to
credentials_mode: kOmit and map allow_credentials: true to
credentials_mode: kInclude.

network::URLLoader cannot handle kSameOrigin. This CL doesn't change
that. CORSURLLoader translates the value to either kOmit or kInclude.

This works correctly even when OOR-CORS is disabled because in that
case load flags are set in the renderer. One caveat is we will not
be able to remove the load flags until we remove the blink-side CORS
code (M78? M79?) with this change.

This CL removes a validity check for credentials related settings in
CorsURLLoaderFactory. Originally the check was introduced to check the
inconsistency between credentials_mode and load flags. After that
allow_credentials was introduced, and at
https://crrev.com/c/chromium/src/+/1443976 the logic was changed to
check the inconsistency between credentials_mode and allow_credentials.
Now they are merged and we don't need the check.

Bug: 799935
Change-Id: Ic05b2d41456d91fd3f48416a3a3e8fc98e235756
Tbr: bsimonnet@chromium.org, dimich@chromium.org, groby@chromium.org, markusheintz@chromium.org, olka@chromium.org, satorux@chromium.org, tbansal@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695341
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Greg Levin <glevin@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681698}