commit | 1e388b0752dd47ca0f5c7168127d9824af9b6d0b | [log] [tgz] |
---|---|---|
author | Pavol Marko <pmarko@chromium.org> | Wed Dec 05 14:00:07 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 05 14:00:07 2018 |
tree | 957255b2d4ce8e9e52bc2c0d420fda92362cbae2 | |
parent | 4619e61d0c042ddfecc652c75ea797c39f4f457f [diff] |
Revert "PIP activation fix." This reverts commit 14b73df744547f1a0443a92540d9304a567b7743. Reason for revert: Suspected to cause build failures in network_service_browser_tests (PictureInPictureWindowControllerBrowserTest.CreationAndVisibilityAndActivation). Example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17330 [24104:4611:1205/045208.445953:WARNING:notification_platform_bridge_mac.mm(521)] AlertNotificationService: XPC connection invalidated. ../../chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc:203: Failure Value of: platform_util::IsWindowActive(native_window) Actual: false Expected: true Original change's description: > PIP activation fix. > > * The initial state is also wrong because widget overwite the > activatable state. > * Deactivate when it exits PIP. > This may not be an issue for ChromePIP, but nothing prevent it from > swithing state so it's better to move that logic to windowstate. > * Cnsolidates the PIP activation logic > in Chrome PIP and Android PIP into WindowState. > > Bug: 911267 > Test: covered by unittests > Change-Id: Idf447771ccaa1d4ad95260c4c44f182946f64c0b > Reviewed-on: https://chromium-review.googlesource.com/c/1357819 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Eliot Courtney <edcourtney@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613901} TBR=oshima@chromium.org,mlamouri@chromium.org,edcourtney@chromium.org Change-Id: I5c52bbbb07e76f96571309bcdeb5839502a176b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911267 Reviewed-on: https://chromium-review.googlesource.com/c/1363198 Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#613958}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .