commit 21c96984f11a34073ef19fdac91341fb9e03bd94
author Daniel Murphy <dmurph@chromium.org> Fri Apr 18 19:52:26 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Apr 18 19:52:26 2025
tree 2ee60ceea7c2308111674a7a9ab9b084aad09edd
parent b9b997334394a18d300cf11208e7e603749a60d2

[PWA] Move migrations from running every database opens to just once.

This refactors the database migrations out of the WebAppSyncBridge and
to be part of the database migration routine instead. This means that
they will occur before any app is loaded into the registry.

This refactoring does not add or change any behavior, and keeps the
existing web app behavior intact. However it does begin to change how
migrations & deserializations & serializations happen in the Web App
database:
- Migration logic is designed to happen once as a version upgrade. Tests
  are made specifically for these migrations.
- Random web app generation is modified to only generate 'valid', post-
  migration web apps.
- Deserialization logic from the proto::WebApp to the WebApp object now
  returns a `nullptr` for any data that is invalid that should have
  been corrected by a migration.
- Migration tests are removed from the database unit tests.

Not ALL migrations that happen on deserialization have migrated here,
but the main ones are moved.

1. Shortcut apps => DIY app.
2. Default display mode => platform user display mode.
3. Partially installed apps => installed without os integration.

Follow-up patches will include:
- Tests specifically for deserializing the proto::WebApp object to
  make sure invalid states return a `nullptr`.
- Other migrations-on-deserializations (found tested in the
  web_app_database_unittest.cc file) can also be moved to an upgrade
  from 2 to 3.

OBSOLETE_HISTOGRAM[WebApp.Migrations.ShortcutAppsToDiy]=Replaced by WebApp.Migrations.ShortcutAppsToDiy2, which is recorded in a one-time migration instead of every profile startup.

Bug: 380063410
Low-Coverage-Reason: No tests for invalid states, but that is in follow-up CL.
Change-Id: I5373ac95ae9cc4bc9f4e0a2c78e1dec7b0e88ed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6464131
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1448976}