commit | 24b40b6c3cd7d8bf1a6970243d4b71f6e95b131e | [log] [tgz] |
---|---|---|
author | JunHo Seo <junho0924.seo@lge.com> | Fri Jul 26 08:19:42 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jul 26 08:19:42 2024 |
tree | d977497e67436631ea467842afd939caf4e4c39f | |
parent | 9b30b14deaa167fb758c8911d6cac9c9259c84fc [diff] |
Snav: Beautify snav test results on failure Changes: 1) Don't replace to '\n'. 2) Remove duplicated information. 3) Add detailed information about each step. Example: - Before: [FAIL] [snav-fragmented-link-partially-offscreen] Focus movements:\n[["Down","a"]\n["Down","a"]\n["Down","b"]\n["Down","b"]\n["Down","b"]\n["Down","b"]]\n assert_equals: step 3: expected focus b, actual focus a expected Element node <a href="#" id="b">bbbbb bbbbbbbbbbbbbb bbbb</a> but got Element node <a href="#" id="a">aaa</a> - After: [FAIL] [snav-fragmented-link-partially-offscreen] Focus movements: [["Down","a"],["Down","a"],["Down","b"],["Down","b"],["Down","b"],["Down","b"]] assert_equals: step 3 ["Down","b"]: expected Element node <a href="#" id="b">bbbbb bbbbbbbbbbbbbb bbbb</a> but got Element node <a href="#" id="a">aaa</a> What is 'duplicated information'?: info1: 'expected focus b, actual focus a' info2: 'expected Element node <a href="#" id="b">bbbbb bbbbbbbbbbbbbbbbbb</a> but got Element node <a href="#" id="a">aaa</a>' info1 and info2 are actually same each other. Rather such duplication causes confusing. This CL removes info1 from snav-testharness.js(info2 is from testharness.js). Change-Id: I1dac2f09fc75a9b094e2157165ba883bad9b0f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5740776 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/main@{#1333423}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.