commit 28b34a934ac8a2a3c54339c71096b85034085534
author Greg Thompson <grt@chromium.org> Mon May 19 12:18:31 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon May 19 12:18:31 2025
tree 4474182a75206ff016a7230ee5b714b6401be027
parent 7eb55392e209cd2929c2538bf7eb06c35d13d12d

More diagnostics for failures to read pak files

This is another attempt to understand why Chrome sometimes fails to
start due to an inability to load resource .pak files.

- DataPack: Add a new LoadFromPathWithError() method that returns error
  details, such as an identifier of the reason for the failure and
  (where relevant) the OS error code.
- ResourceBundle: Use the above in LoadLocaleResources and include all
  of the state in crash keys for analysis.
- ResourceBundle: Add some new crash keys to the error codepath in
  LoadLocaleResources for the case where no locale path is found. These
  will be included in any subsequent crashes (e.g., the one in Chrome's
  InitResourceBundleAndDetermineLocale).
- ResourceBundle: Add a Windows-specific implementation of
  LocaleDataPakExists that returns true for .pak files that exist but
  cannot be accessed. This can happen for many reasons, one of which is
  because of scanners (e.g., A/V) processing Chrome's files while Chrome
  is starting. Crash keys are set when this happens so that subsequent
  crashes (e.g., when the file is loaded) contain useful information.

Bug: 40688225, 394631579
Change-Id: I9dd240fce0070ea0104f1632e60d6d6f3b691e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6554209
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1462081}