commit 2af2d08972d14d5bdd91e0515eb5b15b4444aee9
author git-bruh <prathamIN@proton.me> Mon May 22 13:26:57 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon May 22 13:26:57 2023
tree fb348858a40f834059f67929c085481231d87642
parent 2e3a20e37b51168deb06a21d0619d03b351c8eaf

blink::HTMLMediaElement::ShouldReusePlayer: avoid dereferencing a potentally NULL domWindow

The domWindow() method of the Document class can potentially return nullptr
as noted in renderer/core/dom/document.h

> // A document may or may not have a browsing context
> // (https://html.spec.whatwg.org/#browsing-context). A document with a browsing
> // context is created by navigation, and has a non-null domWindow(), GetFrame(),
> // Loader(), etc., and is visible to the user. It will have a valid
> // GetExecutionContext(), which will be equal to domWindow(). If the Document
> // constructor receives a DocumentInit created WithDocumentLoader(), it will
> // have a browsing context.
> // Documents created by all other APIs do not have a browsing context. These
> // Documents still have a valid GetExecutionContext() (i.e., the domWindow() of
> // the Document in which they were created), so they can still access
> // script, but return null for domWindow(), GetFrame() and Loader(). Generally,
> // they should not downcast the ExecutionContext to a LocalDOMWindow and access
> // the properties of the window directly.

Upon checking further, the offending document returns null for GetFrame() and
Loader() aswell so this was likely just an oversight and no invariants are being
violated

Introduced in https://chromium-review.googlesource.com/c/chromium/src/+/4202152

More details https://bugs.chromium.org/p/chromium/issues/detail?id=1447388

Fixed: 1447388
Change-Id: I85a6ef52baaac0ec7f5ec188d5d5bb2c518a8ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4546610
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1147184}