commit | 3584d76a5a269642fd6ade3459ac142b2429d3ac | [log] [tgz] |
---|---|---|
author | Hirokazu Honda <hiroh@chromium.org> | Thu Oct 18 08:31:34 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Oct 18 08:31:34 2018 |
tree | 2c751194d0cdc67412c4b8f0d0e6b9d9a612d7f5 | |
parent | 81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f [diff] |
media/base/VideoFrameLayout: Create VFL with factory functions using base::Optional This enables VideoFrameLayout (VFL) to be created always by factory functions. They return base::Optional. With invalid configured values, they should return base::nullopt. However, VFL is often created in VideoFrame's factory functions. Some of VideoFrame factory function's input rule is unclear. It may leads to pass invalid values to VFL and returns nullptr as VideoFrame. Becuase VideoFrame is widely used on Chrome video stack on any platform, it is dangerous to change a logic at one time. In this CL, VFL's factory functions always create VFL. Therefore, a logic in VideoFrame is unchanged. This also changes buffer_sizes is empty if it is not specified. BUG=896135 TEST=media_unittests on Linux TEST=VEA and VDA unittest on eve Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibf4191f2e8674ccff084ac8fb4d7e48f89594d6c Reviewed-on: https://chromium-review.googlesource.com/c/1250682 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#600694}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .