Google Git
Sign in
chromium / chromium / src.git / 379c4d392d4ae96f8abba73053273bc5acbfdd59
commit379c4d392d4ae96f8abba73053273bc5acbfdd59[log] [tgz]
authorGabriel Marin <gmx@chromium.org>Wed Jun 19 20:24:13 2019
committerCommit Bot <commit-bot@chromium.org>Wed Jun 19 20:24:13 2019
treef82f7250db505166ab29b9ac91f46b82c7a364b0
parent1c21e156fbccd8fb096239a42d8cc67df3d3b668 [diff]
Get WeakPtrs using a WeakPtrFactory and pure virtual methods

This avoids lifetime issues with SupportsWeakPointer, which is unsafe with
respect to the order in which collectors are destroyed and when weak pointers
are invalidated.

BUG=b:134761848

Change-Id: I4a09dabd81079811b456acb7aca8c653c804edc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666802
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670622}
8 files changed
tree: f82f7250db505166ab29b9ac91f46b82c7a364b0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .