commit | 38370805b498c4d48646b7d4f1a521d847343df3 | [log] [tgz] |
---|---|---|
author | Chris Cunningham <chcunningham@chromium.org> | Fri Feb 02 02:26:01 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 02 02:26:01 2018 |
tree | 7adbd93a5395b815717c15c0179a848be9126b3f | |
parent | 15ac173128e4e22c58e8edfc956ff4c99cca5460 [diff] |
Clean up proprietary codec checks/expectations in LayoutTests This is mostly a reland of https://chromium-review.googlesource.com/c/chromium/src/+/807604 with some improvements and now unblocked by changes to bots. Media layout tests need repair 1) Many tests check for proprietary codec support by only asking about "video/mp4" without specifying a codec. This check is busted because MP4 is no longer considered proprietary while codecs like H264 and AAC still are. We currently claim "video/mp4" is entirely unsupported via test hacks to avoid breaking those checks. 2) Some MSE tests focus on MP4 with H264. While many bots now have the needed codecs, we artificially remove their support via test-only hacks in order to keep expectations the same for all runners. This CL does the following 1) Remove incomplete checks for "video/mp4" - instead hardcode use of the .ogv files (preserving the existing behavior). 2) Update MSE mp4/h264 test expectations to PASS|FAIL. This gives us some coverage on bots with proprietary codecs while allowing failure on bots that lack codecs. 3) Remove test hacks that artificially reduce codec support. It is also not a goal to make LayoutTests try all the supported codecs. That is covered by unit/integration tests. Due to 3) above, some external/wpt/media-source tests now fail because they select mp4. Fixing these failures is tracked in Issue 794338. Bug: 327115,746579,787575,568704,794338,807110 Change-Id: I05565d7ca9d8d5b12391785888701723810671d5 Reviewed-on: https://chromium-review.googlesource.com/849641 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#533924}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .