Google Git
Sign in
chromium / chromium / src.git / 38703614b353273ac8f5629eeecc9f983013b40d
commit38703614b353273ac8f5629eeecc9f983013b40d[log] [tgz]
authoredchin <edchin@chromium.org>Wed May 08 19:00:13 2019
committerCommit Bot <commit-bot@chromium.org>Wed May 08 19:00:13 2019
tree7803d4c5b79828c23847ff503a7d98ec0a238a49
parentce99b3c20036851bd12c2d9277776e15d8167b34 [diff]
[ios] Improve page placeholder placement

Previously, the grey page placeholder image attempted to use the
webProxyView's contentInset property to properly position the
placeholder. This used frame setting.

The preferred way to position content in the BVC is to use the
ContentArea NamedGuide with autolayout contraints.

Using the preferred autolayout + NamedGuide approach also fixes a
placeholder malpositioning bug related to fullscreen experiments.

Bug: 956077
Change-Id: Ia3d115ae203bacb59d41cdb3c377a4a75c00dc95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593921
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657797}
4 files changed
tree: 7803d4c5b79828c23847ff503a7d98ec0a238a49
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .