Google Git
Sign in
chromium / chromium / src.git / 3a2804a6067854d89ff6bbe2ba23d04010c949f3
commit3a2804a6067854d89ff6bbe2ba23d04010c949f3[log] [tgz]
authorNick Diego Yamane <nickdiego@igalia.com>Thu May 21 15:07:38 2020
committerCommit Bot <commit-bot@chromium.org>Thu May 21 15:07:38 2020
treeef0388d3bc45a9222c0696d74608f6c1cba494f5
parentc7a66b1e7c1bd7cacda7a051d6d593ff96b00f40 [diff]
ozone/wayland: Decouple data drag code from WaylandDataDevice

Until now, both code that deals with the Wayland DND protocol and logic
for handling regular drag and drop operations has been living in the
same component, WaylandDataDevice (which also has code for handling
Clipboard operations).

As a means of supporting alternative DND use cases, mainly Window/Tab
dragging, this patch introduces DragDelegate interfaces into
DataDevice and DataSource classes, and shifts most of the use-case
specific responsibility to them.

WaylandDataDragController implements these brand new interfaces for the
usual "data" drag and drop operations, basically containing most of the
code previously in WaylandDataDevice. A second implementation for them
will be introduced in follow up CLs, aimed at supporting tab dragging.

Bug: 896640
Change-Id: I07ff12722230c1f5c065de857e77b086c75c18e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205881
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#771044}
13 files changed
tree: ef0388d3bc45a9222c0696d74608f6c1cba494f5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.