Google Git
Sign in
chromium / chromium / src.git / 3b8d50a27c5880e8cc4e1a11531a476995e868b9
commit3b8d50a27c5880e8cc4e1a11531a476995e868b9[log] [tgz]
authorYue Zhang <yuezhanggg@chromium.org>Wed Jul 24 16:41:39 2019
committerCommit Bot <commit-bot@chromium.org>Wed Jul 24 16:41:39 2019
treebb3c375eebc4c8113ae3414ea79fc4997d2124a2
parent2eefad982d456f3a720e6ec7c5233b735937fd1b [diff]
Remove dropped view correctly in TabGridItemTouchHelperCallback

https://crrev.com/c/1666270 this CL uses recyclerView.removeViewAt to
manually remove dropped view and avoid calling notifyDataSetChanged().
However, removing using index can be problematic if there are scrolling
and recycling in recyclerView. This CL fixes this issue.

Bug: 985904
Change-Id: I207206bbd4830b1762bfd1a22f998b2617f43fe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714215
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680466}
4 files changed
tree: bb3c375eebc4c8113ae3414ea79fc4997d2124a2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .