Google Git
Sign in
chromium / chromium / src.git / 3fef335bdba3410b39b2d50a843e372e42bf01b7
commit3fef335bdba3410b39b2d50a843e372e42bf01b7[log] [tgz]
authorW. James MacLean <wjmaclean@chromium.org>Fri Apr 20 06:31:32 2018
committerCommit Bot <commit-bot@chromium.org>Fri Apr 20 06:31:32 2018
tree38b5500115e94974c219e814669d02b14d61deb0
parentf582ff2a8dd2e14e5f9140bfd5b3bfc1b68a9e7a [diff]
Improve tool-tip handling for OOPIFs.

This CL changes to how tooltips are handled for OOPIFs.

It uses CursorManager in the browser to only set the tooltip if
it is received from a view that currently is controlling the mouse cursor.
This prevents an iframe element in a parent renderer from overriding the
tooltip sent by the child's renderer, keeping in mind this can happen
primarily due to races in the responses to the last MouseMove in the
parent and the first MouseMove in the child.

Bug: 808074
Change-Id: I1bede992a1e8daa8025f3f2e392d721dbe701e95
Reviewed-on: https://chromium-review.googlesource.com/1012268
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552276}
11 files changed
tree: 38b5500115e94974c219e814669d02b14d61deb0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. notification_helper/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. webrunner/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .