commit | 4d1fb0d1b5b2e173b9d432b884d51ba170f7e383 | [log] [tgz] |
---|---|---|
author | Ian Kilpatrick <ikilpatrick@chromium.org> | Fri Jun 30 17:02:23 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 30 17:02:23 2023 |
tree | 5c26c8945f50327e278ba2d365bea7f0f4c9eac7 | |
parent | 809016bfd467797214f5d7ad69c04f3ae6b44740 [diff] |
[RemoveLegacy] Remove NeedsPositionedMovementLayout flag. This flag was used when an inset/margin changed on non-static positioned elements. In NG we didn't skip the LayoutResult cache if it was marked as dirty with this flag, and legacy performed a special type of "movement" layout when dirty. We don't need this flag anymore, instead we can directly invalidate the containing block (needing "simplified" layout if the element is OOF positioned, or "normal" layout if not). This patch will likely result in some elements not requiring full layout anymore. E.g. DependenceOnContentHeightHasChanged triggered a full layout on a rel-pos element when not required. For rel-pos we could always just require "simplified" layout if we undid the rel-pos offset, then recalculated it correctly. There is some complexity with %-insets under this scheme however. Bug: 1229581 Change-Id: I409195ee5aa2e14cd2004b0bfca43485cd5f64db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4655244 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1164753}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.