commit | 5e7f46ab9a9197acf3e86ed55d8f2bfc83ca58e8 | [log] [tgz] |
---|---|---|
author | Piotr Pawliczek <pawliczek@chromium.org> | Fri Aug 02 15:59:19 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Aug 02 15:59:19 2019 |
tree | ea55f41a5c68fbd592b9f6543ac6d6e81d35974a | |
parent | db5345c17082870359df99e556775dbd0da1a90d [diff] |
Life time of BulkPrintersCalculator objects Instances of BulkPrintersCalculator class dispensed by BulkPrintersCalculatorFactory cause random crashes in test environment. Sometimes, BulkPrintersCalculatorFactory is not cleared and it may hold pointers to BulkPrintersCalculator created in previous tests. These objects are used by two different modules (policies and printing) and there is no simple rule when they should be deleted, because in many tests different parts of the real chrome environment are available. I have decided to bind their lifetime to objects responsible for handling external policies. BUG=chromium:966561 TEST=on my workstation Change-Id: I894e67ab9c1fe61da2ab67832d6e6d65d157719e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722196 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683614}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .