commit 5f0e92207cbe16c66ca597377bb7e3eeaa4900cc
author Domenic Denicola <domenic@chromium.org> Mon Jul 15 20:18:55 2019
committer Commit Bot <commit-bot@chromium.org> Mon Jul 15 20:18:55 2019
tree 42eae2660c94f621f06b75ebe88d509e9aba2d44
parent 939161f65f1b4cb042eaa02a2cfe755d80065117

KV Storage: tweak secure context restriction and expand tests

Recent discussions on the KV Storage spec (https://github.com/WICG/kv-storage/pull/53, https://github.com/WICG/kv-storage/pull/68) have decided on a slightly different model for restricting modules to secure contexts, that is based on preventing them from entering the module map, instead of throwing an error at module evaluation time.

This is mostly observably the same, with a few small differences:
* The error type changes from DOMException "SecurityError" to TypeError. This CL updates the implementation's runtime check, and all associated tests, to match the new error type.
* Not being present in the module map means module graph initialization fails earlier, preventing any side effects from earlier modules in the graph from being evaluated. This is tested in the new WPT kv-storage/secure-context/side-effects.html, which we fail for now.
* Not being present in the module map means that import map failover works. This is is tested in the new WPT kv-storage/secure-context/import-maps.html, which we fail for now.

https://crbug.com/977470 tracks the infrastructure work necessary to move from a runtime check to selectively filling the module map, which will allow us to pass the two newly-added tests.

BUG=977470

Change-Id: I9371400e9beed5be4ed5fbb0c94747a7bc0b3e86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670572
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677454}